From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 489D6C433E1 for ; Mon, 29 Jun 2020 16:38:15 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1348A25596 for ; Mon, 29 Jun 2020 16:38:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="S/H9EN6y"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="q5EC2Oaf" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1348A25596 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=64eddLdzezvbfO5nh+Cze10RBSQlz7912QLM3tAchYg=; b=S/H9EN6yP50sMhvgmjgi8wXib PiAVE6D0fvWoZaFrZ5WONevtFPrjTuNgqtgI8VKmZ77woQk19SXl4GEnnefvEPmLMDTlNblO+0U6a CHjlGJd/nvDBuqGqKxCskYSGY6BNdqA3iCsSTjnKuhWeuPmhURd24TTV9lT775s8O42XXqX9usoOh 4Aus1O1njCYEkXhYQq8tobKQ6OZ6jxH8aCt1D1fIW+W5z7YUfIvi+T2vBm4cBgA5+Y0e5qA+W70us 0nwRFGX9BYbVb8PT2KPENxTzPDPEJQGxwwWmeQ4YoXBsYuIYRTkETBMODiLVFkmibBgDzx5tzA7WU GPhYamVmw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jpwmD-00054m-HC; Mon, 29 Jun 2020 16:37:01 +0000 Received: from mail-pl1-x641.google.com ([2607:f8b0:4864:20::641]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jpwmB-00054E-H6 for linux-arm-kernel@lists.infradead.org; Mon, 29 Jun 2020 16:37:00 +0000 Received: by mail-pl1-x641.google.com with SMTP id f2so7298974plr.8 for ; Mon, 29 Jun 2020 09:36:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=cP6iQsVZnZL9cfv3sLl/5r6hzqX0rVayprzDZmD8fls=; b=q5EC2OafxVTf2u/iQVD0g8yJF3Y1bDOuicqD7IHdDsvf5/fGCEdbx9n3vhiYTT2qiC fXBtNHHkfMBVzxvHYFkKG4rc+UqQ1k+C6Zc1++iOwPtLEWdKwxKR0b4Hexnp5badz2e9 Emob2Nui7WvtyIQWV2bepfCdG5Z+H4LQOzS6+qE7Mk/UpmWlaayYsRadT8JfLDeJuF7b ekEIDf7quMaUYxhU8LTapw6ta8ft2Dnmm1EFyyS+Va4/NSNILgilR0dN32QjzYEyHoPS cVvD1LHMsN1bihCtlFjyMsdBqea389T0XZ7BeI/GjaXKXlZmPjNU8WYzYSUbXsvl1n2F 1iIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=cP6iQsVZnZL9cfv3sLl/5r6hzqX0rVayprzDZmD8fls=; b=cLbaoZi0UfmYzPjjukW8T/JEszh8O/XURbT69t32NaTG+//5nM/RoX/cRZd6rIWRcr jPdGIkFzYVNgP5ikmfo38ohdSqf1xoCzNOC6isRj4ZnIEo8kE/6cfd8WnjuUUPv7IqvY o/kNipUiYOJc86SFE8GKMLyG++Q/7SR6PxSH4bkA5XEYVg8DFiJI2D7K8qXOpXdmVH7X XcfigJ1+ykUcwKYeA8Yr7bHZAjogOmXa4ozz3L6e2to7wMoij7XNj0q4Dcu0p82YkDH7 xZjbDe/UHdkzxO+ASUX85Fdh4A0SzDUNhvyw6k7Q5lF89obdJZPiF/r/SPgMmW8uvJ05 R44g== X-Gm-Message-State: AOAM533kUF2lF5vpL+L1gXBhNN3pTlttWJ3jbX975Fsns5nlcP6A9euT qPlIlkdFxf3r8SJEQhcQ9P203mjfX2bXwYC2Ch4= X-Google-Smtp-Source: ABdhPJxY0TieHGnK37IC/NZ8PHvS+nU0xr2yP6SeSbn2otyH5MinztJSPrmwBVJET9OWG4mysZKu95H1GtfccfKlpyw= X-Received: by 2002:a17:90a:b30d:: with SMTP id d13mr18146343pjr.181.1593448616001; Mon, 29 Jun 2020 09:36:56 -0700 (PDT) MIME-Version: 1.0 References: <20200629112242.18380-1-a.hajda@samsung.com> <20200629112242.18380-3-a.hajda@samsung.com> In-Reply-To: <20200629112242.18380-3-a.hajda@samsung.com> From: Andy Shevchenko Date: Mon, 29 Jun 2020 19:36:42 +0300 Message-ID: Subject: Re: [PATCH v7 2/4] driver core: add deferring probe reason to devices_deferred property To: Andrzej Hajda X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jernej Skrabec , "Rafael J. Wysocki" , Greg Kroah-Hartman , Bartlomiej Zolnierkiewicz , Linux Kernel Mailing List , "open list:DRM DRIVERS" , Russell King - ARM Linux , Neil Armstrong , Jonas Karlman , Mark Brown , Laurent Pinchart , Daniel Vetter , linux-arm Mailing List , Marek Szyprowski Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jun 29, 2020 at 2:22 PM Andrzej Hajda wrote: > > /sys/kernel/debug/devices_deferred property contains list of deferred devices. > This list does not contain reason why the driver deferred probe, the patch > improves it. > The natural place to set the reason is dev_err_probe function introduced recently, > ie. if dev_err_probe will be called with -EPROBE_DEFER instead of printk the message > will be attached to deferred device and printed when user read devices_deferred to a deferred reads > property. ... > @@ -3984,10 +3986,12 @@ int dev_err_probe(const struct device *dev, int err, const char *fmt, ...) > vaf.fmt = fmt; > vaf.va = &args; > > - if (err != -EPROBE_DEFER) > + if (err != -EPROBE_DEFER) { Why not positive conditional? (Okay, I'm fine with either in this case) > dev_err(dev, "error %d: %pV", err, &vaf); > - else > + } else { > + device_set_deferred_probe_reson(dev, &vaf); > dev_dbg(dev, "error %d: %pV", err, &vaf); > + } To reduce churn, you may move {} addition to the first patch. ... > list_for_each_entry(curr, &deferred_probe_pending_list, deferred_probe) > - seq_printf(s, "%s\n", dev_name(curr->device)); > + seq_printf(s, "%s\t%s", dev_name(curr->device), > + curr->device->p->deferred_probe_reason ?: "\n"); Hmm... "\t" will be dangling in the latter case. -- With Best Regards, Andy Shevchenko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel