From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 611B5C3A5A8 for ; Wed, 4 Sep 2019 16:28:06 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 302A621881 for ; Wed, 4 Sep 2019 16:28:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="APzFa3a4"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="u96W3i3h" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 302A621881 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=svJ7j3aanMoObjoZGsIkqBnTOcKBQdlEvJLAYjWMcwU=; b=APzFa3a49FbJWO 8nXUHRRPU94e5mcY5MF45GVn86aJsrTzS5xBW4Da4Cx1z7xsu/OCyQYMctOeJAqLh9bp67iK/LM2h RG0xkmS7MgQWKAWdKu9TvOjvrqGPI6NIwF11gxZxpvYfeP+4wIaDIIr/ki18+i1nOswCrp8tCX3th Z1ECyHPELqcuBuadJFCKqbU0PCPUdysHIQAnew+CxgUW8h/Zy59jlxM4YWmzPyKOc+h275lfORPiz v1Nk6KyW7qAXfuqLg/C2UD5gKGpLv0T3O1t9W7UEc2Yj4NqSt9kO+51cJeHlJQ4lERiFPmpWKwTS/ Qaq/4DIQJlSU+Kb5akfQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1i5Y8X-0000KX-TV; Wed, 04 Sep 2019 16:28:01 +0000 Received: from mail-pf1-x444.google.com ([2607:f8b0:4864:20::444]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1i5Y8H-00009b-9x for linux-arm-kernel@lists.infradead.org; Wed, 04 Sep 2019 16:27:46 +0000 Received: by mail-pf1-x444.google.com with SMTP id q5so5711570pfg.13 for ; Wed, 04 Sep 2019 09:27:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=h04RkzjT3hXLTqVi3hxMYt7+XgkxZzlEb0BXvzdW1Iw=; b=u96W3i3h8EyeOAeUHfKxUJeZZrPcR78dwH/TA9Q0gcEBy2fX0/RospEgR+NpW6qmL8 x7Cw14anhZMC/3swXtc5wbpMZ+zCJqv4YzAVxVQuTkU+2IspzSnhZM3Gv5klXmNda5mw wVF9asAXOiNpj3HEIMkNLKBdRy6DO8xyWZEufSISyBoqV0U9AFhOxjXiRaF3BcQWN0kq zWWkmevlB+++8fGIjUZFmXsFgLzRrXmjtPLiUiaPDrwTQ3LzcfaJ7vq2GqaVRy5rrt5u b4hUoaq7bsGZDSpHsgo2hT8e70WUzAVYai9e+pS1NGd+erk4+IDj3tcPJyGAyEfYLupO Z28g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=h04RkzjT3hXLTqVi3hxMYt7+XgkxZzlEb0BXvzdW1Iw=; b=EhtyHK1Sd4hPs9RFMhx2V8HQnwgsjsmSrNDE6JbWmmbYbU9ORzLk866vo/09kdbaKv RXi/JzpGI23T+np00Kgj3Ege/RYReKBgkQCf1tlldYqui/0msmIeLhP2DJCcZWIjIuBO J2LXYR+KpqYn3Y+8iH4LMJWmE4oRVajPFcTi6gJI0op7A46b9Krd6dKAXDoFgY782nx2 EvkvOnfWG13XgQp5Rmrjnd/BLGKGQu4PYYSpK0atpmoOdOaEzZqk9aAMCcAcLzSsUKA1 c2OrCKENF5aS+0BbzUCqdtHi00dRCeAWxTJdE4BMmVvLW2ggNXvaHLR5liX+AaPsdRea rDIQ== X-Gm-Message-State: APjAAAXscyNPnP3YrVjMeHdf9fhCUoNHmpTZ2Zs+K9jMUCHAMqG8gKYy C0smA1PPfqZbg/tFDQQUvsGeuPSwDulaYb1wk4Q= X-Google-Smtp-Source: APXvYqzS8bxdeH8zm+j+hxb1ouuCS1ZUvEOMUS0WH79z6S5Qndoz6KZ4UIiuE9srzqOavs3O1cbyfUGHH5iUYCJJZFI= X-Received: by 2002:aa7:93a8:: with SMTP id x8mr14577315pff.151.1567614464501; Wed, 04 Sep 2019 09:27:44 -0700 (PDT) MIME-Version: 1.0 References: <20190904061245.30770-1-rashmica.g@gmail.com> In-Reply-To: <20190904061245.30770-1-rashmica.g@gmail.com> From: Andy Shevchenko Date: Wed, 4 Sep 2019 19:27:33 +0300 Message-ID: Subject: Re: [PATCH 1/4] gpio/aspeed: Fix incorrect number of banks To: Rashmica Gupta X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190904_092745_368365_495E3E7E X-CRM114-Status: UNSURE ( 8.87 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-aspeed@lists.ozlabs.org, Bartosz Golaszewski , Andrew Jeffery , Linus Walleij , Linux Kernel Mailing List , "open list:GPIO SUBSYSTEM" , Joel Stanley , linux-arm Mailing List Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Sep 4, 2019 at 9:14 AM Rashmica Gupta wrote: > > Fixes: 361b79119a4b7 ('gpio: Add Aspeed driver') > > Signed-off-by: Rashmica Gupta > /* Allocate a cache of the output registers */ > - banks = gpio->config->nr_gpios >> 5; > + banks = (gpio->config->nr_gpios >> 5) + 1; Shouldn't be rather DIV_ROUND_UP(nr_gpios, sizeof(u32)) ? > gpio->dcache = devm_kcalloc(&pdev->dev, > banks, sizeof(u32), GFP_KERNEL); -- With Best Regards, Andy Shevchenko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel