From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3F653C433DB for ; Fri, 5 Mar 2021 16:22:16 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B5DD86508B for ; Fri, 5 Mar 2021 16:22:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B5DD86508B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=nOZv0CndeuzRSkj8MnX9bQG9w2l3+nwniKu5/TjR8G4=; b=ZOWG2nPaeogQZjfdmZXvUEp+r rjwJQ71Fwr92BSuon5rR2ZU4uvxMnK/Guin21D7YKEwfLVmYbrKkaimXK8yXwNW13CW52CnfnAHXi A5fBuCTeEoKwq/inaeUcFOFOYS05x6GbK0wfaxCSjQ/1edC103+LHu8GB7cvgUR+l17033SVYEMcP 3DCEp0mQy5+O0f8GD2axb+f7Cj3V7jgQS1GQ1UnmsLc7gs/14Mq7rdI4mgzgi11RZPul/JIX6NA5g S+2JTTkBlz1AT92/uM0mvTjIKaCnXOJNn+Dwx7VRs79vYzB7+j1qPCb79fuNQRafxUp4AwAfrnAaS Z88LllGVQ==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lIDBq-00FbrO-La; Fri, 05 Mar 2021 16:20:35 +0000 Received: from mail-pg1-x52d.google.com ([2607:f8b0:4864:20::52d]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lIDBj-00FbpW-N1 for linux-arm-kernel@lists.infradead.org; Fri, 05 Mar 2021 16:20:30 +0000 Received: by mail-pg1-x52d.google.com with SMTP id t25so1710781pga.2 for ; Fri, 05 Mar 2021 08:20:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=boCa64fG4W3WCm+9ChyeoaRgwehVFUby8zC/hTUMZzg=; b=rsT6Tlua+ii43EVOburqG9qBUuJHjuPkPNCv0Ptl6LW18HtoODhBB1hk5pPRB2zh6l +rtRTJVVj+PhOJj3M4fprqkafaXE2Zzp9wGW2W7LQXMidfMnn+7gzWk4G4nKh/e7hHBb ImPc6LGoVP0rXhawxuvLVGmb7YSt5r+8Arwfye9RDD8mPtW7M9eXHoq5izrvWdn+IvHB 8xGa8fjbfJ/EtbBVZ6n2vD5KXQ/h5uG1rYLJlecAZVD/dAKH1KGNhYf1WkOYiJoqA/oY EaCsl5ukGD/oO6Zt4rMZXindIRABsS03aLkXO/rwmi2pJd6ijjFBB8u83VMsSO/Mo4Mt AO1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=boCa64fG4W3WCm+9ChyeoaRgwehVFUby8zC/hTUMZzg=; b=Yn2fab4t/HJiYn7FPNuYHqD3Z6WR+5LA10H3J6yhATgbWdJrpHz1ZpkwqxsmFEVFzS 370EefzyrVl814PgLIsSmGAeeppuO9+E8xeXDL9/tGJIANeK/LeQpp5zK9xku3sQulEZ X07TBW6rDpXGhm34ecd9xyBQQpaWviWkdY91afcZFBr9/eo4LsNrjdpcVb+qqwF3ldaE rvRqLW74aVERpUdVLsxCxltILQ7USpycAV/8HIgKbrR4AzdmkCLrPbGSEOEVa1FUmCSo SiWJkbxdO8j5W4DzjJ1lUxrbQKtxkNiQolKmZIuOD7l0RT/Z+WbyOvQIvCAN+s63ASK2 ywtQ== X-Gm-Message-State: AOAM533V9V9rCZqIs4i9pkV/qHDwwK/5JFFz1C8s442ImVsDGqfgbsxJ L+E8Ux+YMz7JnrPUHK5/C2hHuEWB4f+daeZp62g= X-Google-Smtp-Source: ABdhPJzpHuRfbzgse9xN4Nrv93TTVGJQnTIeImSnTO4+//St56aPX2qy3MqZ0uLWkV9xTeaHtiU1CTzttx7xYN3fKrY= X-Received: by 2002:a05:6a00:854:b029:1b7:6233:c5f with SMTP id q20-20020a056a000854b02901b762330c5fmr9709475pfk.73.1614961226373; Fri, 05 Mar 2021 08:20:26 -0800 (PST) MIME-Version: 1.0 References: <20210304213902.83903-1-marcan@marcan.st> <20210304213902.83903-22-marcan@marcan.st> <535ff48e-160e-4ba4-23ac-54e478a2f3ee@marcan.st> In-Reply-To: <535ff48e-160e-4ba4-23ac-54e478a2f3ee@marcan.st> From: Andy Shevchenko Date: Fri, 5 Mar 2021 18:20:10 +0200 Message-ID: Subject: Re: [RFT PATCH v3 21/27] tty: serial: samsung_tty: IRQ rework To: Hector Martin Cc: linux-arm Mailing List , Marc Zyngier , Rob Herring , Arnd Bergmann , Olof Johansson , Krzysztof Kozlowski , Mark Kettenis , Tony Lindgren , Mohamed Mediouni , Stan Skowronek , Alexander Graf , Will Deacon , Linus Walleij , Mark Rutland , Greg Kroah-Hartman , Jonathan Corbet , Catalin Marinas , Christoph Hellwig , "David S. Miller" , devicetree , "open list:SERIAL DRIVERS" , Linux Documentation List , Linux Samsung SOC , Linux-Arch , Linux Kernel Mailing List X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210305_162028_715226_E3CCEDDD X-CRM114-Status: GOOD ( 13.95 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Mar 5, 2021 at 6:16 PM Hector Martin wrote: > > On 06/03/2021 00.17, Andy Shevchenko wrote: > > Add a separate change that removes flags from the spin lock in the IRQ handler. > > This commit should have no functional changes; Exactly my point why I'm suggesting to have _separate_ change! > I am just splitting an > existing function into two, where one takes the lock and the other does > the work. Do you mean using a different locking function? I'm not > entirely sure what you're suggesting. Yes, as a prerequisite spin_lock_irqsave -> spin_lock(). -- With Best Regards, Andy Shevchenko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel