From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8BC8CC433B4 for ; Mon, 17 May 2021 07:13:04 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 10533611CC for ; Mon, 17 May 2021 07:13:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 10533611CC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=798zQEGXzEMUxwKw/+LCJPuY+PtHa+GS0Ch1NHxjurc=; b=nJf1wOVSAbu4qogKF7a6t+Tzt CYIq7NPLgfzsgHz1f2NK5mlCWTFGy8P6Nw1eoNJhEuP+aKLz8cwub1d3atGQcxYfkDoQvHKtakKyv MgCmqcfimTYM3FcBkEuyeSb3fxAEml5E3Digt96dQWDgle7pm/qKeNy3JhCmeQddrpyvpvwOoajCq tmTSImKpmhwphHrdER0qENmJKWa0NdnqXdA3UeGX+fQpII7gIelIUedJu5eIA2Ga2cpuza+KOf6b6 3dySHxuOyPd3goaqsLgB2KdENuGsjXuhzwJqsQAIpRo9DzUlsA6zFO5GifClS9JqgPyLOwHrndhMf 7DdmSQEJg==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1liXMu-00Dzj6-Jt; Mon, 17 May 2021 07:08:48 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1liXLp-00DzdW-CX for linux-arm-kernel@desiato.infradead.org; Mon, 17 May 2021 07:08:16 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Type:Cc:To:Subject:Message-ID :Date:From:In-Reply-To:References:MIME-Version:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=OHsOhMkfdmLyNcJTSRWD0EukxlrM/gH9Vk6KCAfzBQI=; b=iWO4cbzi9MBns5rsJt7Pis1yeO axv7ArRf6croi2SMhGW5shavWiomjvWZCbvJZNtezRgLJEiZy36NOO94LNvNYTv/HR2+5DgevbfmL LiqRN6aW1LJMvPhuCkRBTUhSTqUGeFXkjGkt5A2n22wz/8R3dXko3Z5rEWsUu7Gyzfqkvmfpnek3t e35LimoSob+t6/3t8W/AKbqfEmNGwT54vPuu12NdMFElixXsQhhtZTOf2ytK6zV/iHkL4yKwYHEzy yK/5ty0EzwQ0VUT6eQlt8P7lk++Tl5P6H9dyroKeFfMqnFyWdIzGRGGrrEC1SUIcXC5opZQbYsWX3 EbSaKThg==; Received: from mail-pj1-x102f.google.com ([2607:f8b0:4864:20::102f]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1liXLm-00DXCJ-OR for linux-arm-kernel@lists.infradead.org; Mon, 17 May 2021 07:07:40 +0000 Received: by mail-pj1-x102f.google.com with SMTP id o17-20020a17090a9f91b029015cef5b3c50so5020223pjp.4 for ; Mon, 17 May 2021 00:07:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=OHsOhMkfdmLyNcJTSRWD0EukxlrM/gH9Vk6KCAfzBQI=; b=IyUhI2uu0zOZtjLN7fDarrmuuvNJPDXVOSid9BrbEfWTYF6oYJo8I9F7KqHUIpgYvy 5muluH0L4+lo6AxpJ27QzBgctHIOh+fF46bbve7WjDl4exx+y/hJYOdGlj7yUHxReG11 M1BIEB0+GHjTNcF01SJJX5Lb/CepTNq91BkoKuxd9oudtS9sWGVIzWNbTMpMZLr8Hrup ub8c9fOgYoejDODbHDKkaJE+gDDHLxw8ebLAx/b8Dis3HEkE6KTdIxW4pGZ22h0WEA3J /HYK4o6V7gMAfpBgTt82LEzGO0URobsXx/HHRGkocCH6hQMS23qxLtor7T/fihl2F8GS W4Zw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=OHsOhMkfdmLyNcJTSRWD0EukxlrM/gH9Vk6KCAfzBQI=; b=DwHhmlhgGNerqu1w0mIV+bp5v4xWuyeyWqfOxnA7mYuqOPBjcQ618DMD1SCe/Qaiy1 sCXIhk+rAuqecqHLFySNotPz2keI69oNjPlXTO3G6OHUyD0HeAAhcO0OA5jg8sw7WMme VUKOPYCe7ZStLKi5v7G96O8qTSA1dExqhjSbSYuqqjdtLu+hRHRUgad2qekvSjWHmEWx 3slqK0egvG8kmpDoAMdLjXZu/Dq/FrX9gVpe3KeIVLh2jPwnyS60q4s/ToVI4I1XrWKc pauL5wOMdTD/VUGWfXKUfU7JNqEnETHtti0QsGpecJl96STxNNTcJJHbP9TtlqZ9UGAe Hnmw== X-Gm-Message-State: AOAM531TKYlpvDrSTLxBWlMKZmEx8zxqUf3bno3p7/ewkBFN68XnTVub MhRBav0kxoWLgBL3aTtQ/rih5PQ7Rf6IqlmDlCE= X-Google-Smtp-Source: ABdhPJxHPEJJFbEnsYM8mbhVJM0hD1ow9LoGY9OOIw1MhX82g4QacUB+hF685k8IhVw3bjAsplJezNGl8RaWF5OcAEQ= X-Received: by 2002:a17:902:b20a:b029:ef:463:365a with SMTP id t10-20020a170902b20ab02900ef0463365amr53310022plr.17.1621235256269; Mon, 17 May 2021 00:07:36 -0700 (PDT) MIME-Version: 1.0 References: <20210513085227.54392-1-colin.king@canonical.com> <20210514053754.GZ1955@kadam> In-Reply-To: <20210514053754.GZ1955@kadam> From: Andy Shevchenko Date: Mon, 17 May 2021 10:07:20 +0300 Message-ID: Subject: Re: [PATCH][next] gpio: xilinx: Fix potential integer overflow on shift of a u32 int To: Dan Carpenter Cc: Colin King , Shubhrajyoti Datta , Srinivas Neeli , Michal Simek , Linus Walleij , Bartosz Golaszewski , Andy Shevchenko , "open list:GPIO SUBSYSTEM" , linux-arm Mailing List , kernel-janitors , Linux Kernel Mailing List X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210517_000738_814322_8F15E3B5 X-CRM114-Status: GOOD ( 16.56 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, May 14, 2021 at 12:26 PM Dan Carpenter wrote: > On Thu, May 13, 2021 at 09:52:27AM +0100, Colin King wrote: ... > > const unsigned long offset = (bit % BITS_PER_LONG) & BIT(5); > > > > map[index] &= ~(0xFFFFFFFFul << offset); > > - map[index] |= v << offset; > > + map[index] |= (unsigned long)v << offset; > > Doing a shift by BIT(5) is super weird. Not the first place in the kernel with such a trick. > It looks like a double shift > bug and should probably trigger a static checker warning. It's like > when people do BIT(BIT(5)). > > It would be more readable to write it as: > > int shift = (bit % BITS_PER_LONG) ? 32 : 0; Usually this code is in a kinda fast path. Have you checked if the compiler generates the same or better code when you are using ternary? -- With Best Regards, Andy Shevchenko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel