From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E24EC3A5A8 for ; Wed, 4 Sep 2019 16:30:28 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 51AD821881 for ; Wed, 4 Sep 2019 16:30:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="TP9wX2tG"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Z7MJE3qJ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 51AD821881 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=FuwuRv21ZOIge0B8AIFZ9RNkqrnnI0qHGIe2eBz05+E=; b=TP9wX2tGYF/Hgd slCjetxUkDiIhWdhOlemNphXz9sPLJMOHuV0slPCtDz6SDQbQZS7kOdSCT/jMt/WTiyPjR1zJY4Iw jqkfeqEGP1gfJhKVqH76yqPoRR9nUGy10yQSDDyL+EPx2r/DaYUREfq9izaCTlIvowp9yUoP22GHm JNmbjiFIbErMgee2c53WuINYIjOSNrtLiBs1at51bwAb6ZQGo/wMFd5kq9Gppob00JWB4CRBJcKIw XrJ29se7RFEbCLILgaihlImyZH0/qJIvsCGDpkqLpFOxM6q5ZXYxSaAScXUdSN9tElGZjr02vIf0n omLb8t/pd5aCyLchlg/A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1i5YAq-0001zv-HJ; Wed, 04 Sep 2019 16:30:24 +0000 Received: from mail-pf1-x441.google.com ([2607:f8b0:4864:20::441]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1i5YAn-0001zZ-7A for linux-arm-kernel@lists.infradead.org; Wed, 04 Sep 2019 16:30:22 +0000 Received: by mail-pf1-x441.google.com with SMTP id h195so7023586pfe.5 for ; Wed, 04 Sep 2019 09:30:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=0Bk5FCrmIebdNTJxqeSp5asp911jjtdI8aFxkaoSkUA=; b=Z7MJE3qJHR8e1zg4M/OzjRMI8uXwVNEOcJS7BGFiaDV6mFALldUUSXDzH7MDyjvIPC N3ORyV1v0tHe0bs85LwIt8W3EDERZ9+ixgYiqYntooIRtWwd0cs7l/fnCUltEybL5LnU AxSYEpWniZ9Vc9HG6/XZyqZTO3u9wlVyUmwU9p7BU8s7K7YCcQ2O8/SGOBjo4uPyS6zx nsN0/ojOMkS3Jj2Vk7LwCMkBQY3EvHhBSKnV2G+lZMK7koE2fAZwP+wc19x3joGmOyTQ d/eDjlbD1Ea+xJ4ZG3I1n6BpTMlO0Ow++2Hu03dK+pWgvMIOwmtd/bC/EWjXYZh9p51n BSiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=0Bk5FCrmIebdNTJxqeSp5asp911jjtdI8aFxkaoSkUA=; b=se9uKpoWUQoFjKuvearEXeTbVjNxht8xT3u3FGzoO3C/72rQfMvF18OqEZdeEKaxgq QKeQDbjSSjwbEj0EFaP/3qFJKdI69lX7xs9Ofg/D1a0lCutdGXr0NhmXZU2pRVu7+VK0 UJoQHbYqOHF3BEwLsyvIwNO6+5lZtyt7W47DqB78nCYLGyS0et9GqLAmIQOHVi5NZrIQ 2BZ5w9pb8k23BInWfUMjaW8SNoMcw1HiMYAaDsGPyPUgMNkHPdR1mf6Pceb9RVM0YrYp gEqVupwuAO3wvrQRFMASJzXZaN+TPI0bzxxLdJ1XjypZtyinlAcmNF3a0XG+nKXQeuwR DivQ== X-Gm-Message-State: APjAAAUpwWWxtNfgdP1rDQzw0kfcEkinla2HpUdXYkLCoi1/Zu/7BC1r AlyIOMXDvIq8o6cy6Qugo461Xv22iyoxsHOrpXXBTEAP X-Google-Smtp-Source: APXvYqwfTMyky+gr506dU7vA5RQA2gAYCn+ZMYC+IVVNtVkdvfPY6ix3mRDrBzSvrtUGH0BfnF3ha8tgX/jGZ72bAxY= X-Received: by 2002:a17:90a:19c4:: with SMTP id 4mr5998093pjj.20.1567614620706; Wed, 04 Sep 2019 09:30:20 -0700 (PDT) MIME-Version: 1.0 References: <20190904061245.30770-1-rashmica.g@gmail.com> <20190904061245.30770-3-rashmica.g@gmail.com> In-Reply-To: <20190904061245.30770-3-rashmica.g@gmail.com> From: Andy Shevchenko Date: Wed, 4 Sep 2019 19:30:09 +0300 Message-ID: Subject: Re: [PATCH 3/4] gpio: Add in ast2600 details to Aspeed driver To: Rashmica Gupta X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190904_093021_265619_D5BF6586 X-CRM114-Status: GOOD ( 11.32 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-aspeed@lists.ozlabs.org, Bartosz Golaszewski , Andrew Jeffery , Linus Walleij , Linux Kernel Mailing List , "open list:GPIO SUBSYSTEM" , Joel Stanley , linux-arm Mailing List Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Sep 4, 2019 at 9:14 AM Rashmica Gupta wrote: > > The ast2600 has two gpio controllers, one for 3.6V GPIOS and one for 1.8V GPIOS. > > Signed-off-by: Rashmica Gupta > - for (i = 0; i < ARRAY_SIZE(aspeed_gpio_banks); i++) { > + banks = (gpio->config->nr_gpios >> 5) + 1; Same comment as per the other patch. > + for (i = 0; i < banks; i++) { > +static const struct aspeed_bank_props ast2600_bank_props[] = { > + /* input output */ > + {5, 0xffffffff, 0x0000ffff}, /* U/V/W/X */ > + {6, 0xffff0000, 0x0fff0000}, /* Y/Z */ Perhaps GENMASK() for all values? > + { }, Comma is not needed here. > +}; > + > +static const struct aspeed_gpio_config ast2600_config = > + /* 208 3.6V GPIOs */ > + { .nr_gpios = 208, .props = ast2600_bank_props, }; Seems curly braces missed their places. > +static const struct aspeed_bank_props ast2600_1_8v_bank_props[] = { > + /* input output */ > + {1, 0x0000000f, 0x0000000f}, /* E */ GENMASK()? > + { }, No comma. > +}; > +static const struct aspeed_gpio_config ast2600_1_8v_config = > + /* 36 1.8V GPIOs */ > + { .nr_gpios = 36, .props = ast2600_1_8v_bank_props, }; Location of the curly braces? -- With Best Regards, Andy Shevchenko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel