From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17948C4363D for ; Wed, 7 Oct 2020 14:55:39 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 88464208C7 for ; Wed, 7 Oct 2020 14:55:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="C3uYdGzL"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="OuOjVEZr" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 88464208C7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=vl8ycIeHX2MB3VvLBQau8DU+fuOUXc1ZtxVPXC4uALo=; b=C3uYdGzLKfpyGgm5YJxat9uhA dVfm5bKThlSzQgZndHt8xengHU1Mxfxc3T4pp7vHwEqrnFsw79woeq+weB/+pT2WKWp8asRGrWRXg fjeDXY/YkHXgvqTOVQjs0s2GZnwcnSdXipx123Z/CsRTq6fXBZp1HGyepHAH2byH4cXkD40bAJtSu fI5menR1wlzPlX38famCydZN+lU+BKMkoYWnP7lxEav25Ctb2Nu9HnboJdz6t8FQpxPqYdKBDK0QF 8aDXkdQAyVep4PfItDzcjbpT1TH3MDdTcRjqZJivOKdDr2S6AcDICNcXpPFhqNRonH4hWydXRhU8K UsNC640JA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kQApP-0008T5-75; Wed, 07 Oct 2020 14:54:03 +0000 Received: from mail-pj1-x1044.google.com ([2607:f8b0:4864:20::1044]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kQApM-0008SQ-QU for linux-arm-kernel@lists.infradead.org; Wed, 07 Oct 2020 14:54:01 +0000 Received: by mail-pj1-x1044.google.com with SMTP id az3so1156563pjb.4 for ; Wed, 07 Oct 2020 07:54:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=OyV6KXUS1c7DltkhuFHvz8iH/qvXIDKFdF/6FuM3Dvg=; b=OuOjVEZrMX7i4qZyPfaYfkDmwT4UCUjiWjpK5i0cEo0a2i3+Z9CLqRNjB0So9tDlI1 UPO1GLlswNEiEsawr+zNU8fOe1Mza/Xw/3wFb74ZWe1wJvLs84q3AMNdSPSbLzjrN1kd N9423/l51m7+ASIR/M1B8R1j85SprUi0VLe6uHuSbbD6wVEMBVyno8mS5Al0yRrJT0kK daDAWfB+ZWbUbjZSFR0BtVxwg6SQXQR/S5Li6ZqgfHF/0EMkMZ+Hg2tKAv+EvY/guGZv GlYacxbTY0AWjijUbWDcIOSv2x3SlSOsu0huSSwD0f/2b8DW4mb8so9Qz+x5IjfJufkc XLNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=OyV6KXUS1c7DltkhuFHvz8iH/qvXIDKFdF/6FuM3Dvg=; b=f0YZEjN52fw5ZK/8Atu2g1ESQaNSPZ1Tj+e4HHdIlbZc9LJKseZJv5a//mVC/cUTKF fElFmIoegPnPDvo1VyDRdwJc8zu5AsxxGVRBYz7B4J5To9QWtSEHgAgD6/PkhLbPHR9F TUjXFFL7oloWSTI3HAJlI9o2jT87E0cJPAUNaTkE6MPBRnD9eE7qwE8Hzv5pf6/dxsnW RnLw2VlpTEzvvHiWuNWXWKahG86DL7A2FSaoOWTqAipV73K/uMP6zi/mBiLwxLTRi8ax RKZW1aEZaLvTrY3mC+wyLzTzmKcwIiPLPwkbRvBbIDhJIto78Zqk5aghU/bOAu9J1jNF PNPA== X-Gm-Message-State: AOAM5311bRBPzXiUJLonrMzsKoxr1rynqummkRo+5x9Akcvx3/YPD4qA 4CdmGcGAsIfYmCm24EBTIVUrr5lwf59NlEPk76Q= X-Google-Smtp-Source: ABdhPJyYIQrR0698WQb7xr65UOrpJZ49f68fUhyAjCgrnYz/LAGp892x0F2TCpJq42TdjUcdJGj0D/XxeGRvKN+i5fc= X-Received: by 2002:a17:902:ea8c:b029:d2:8abd:c8de with SMTP id x12-20020a170902ea8cb02900d28abdc8demr3306474plb.21.1602082438746; Wed, 07 Oct 2020 07:53:58 -0700 (PDT) MIME-Version: 1.0 References: <20201006155549.3595-1-muhammad.husaini.zulkifli@intel.com> <20201006155549.3595-2-muhammad.husaini.zulkifli@intel.com> <49c9fe27-ee82-f490-482b-365101d3b6cf@xilinx.com> In-Reply-To: From: Andy Shevchenko Date: Wed, 7 Oct 2020 17:54:48 +0300 Message-ID: Subject: Re: [PATCH v3 1/2] mmc: sdhci-of-arasan: Enable UHS-1 support for Keem Bay SOC To: "Zulkifli, Muhammad Husaini" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201007_105400_867777_600B1703 X-CRM114-Status: GOOD ( 17.68 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ulf Hansson , Arnd Bergmann , Linux Kernel Mailing List , linux-mmc , Michal Simek , "Raja Subramanian, Lakshmi Bai" , "Hunter, Adrian" , Sudeep Holla , "Wan Mohamad, Wan Ahmad Zainie" , linux-arm Mailing List Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Oct 7, 2020 at 4:28 PM Zulkifli, Muhammad Husaini wrote: > >From: Andy Shevchenko > >Sent: Wednesday, October 7, 2020 4:56 PM > >On Wed, Oct 7, 2020 at 11:38 AM Michal Simek > >wrote: > >> On 06. 10. 20 17:55, muhammad.husaini.zulkifli@intel.com wrote: ... > >> > + struct device *dev = &pdev->dev; > >> > >> nit: I got this but as I see 3 lines below maybe would be better to > >> use it everywhere but it can be done in separate patch. > > > >In that case I think it would be better to have that patch first. It make follow up > >code cleaner. > I want to get some clarification here. > Do I need a separate patch for this struct device *dev = &pdev->dev;? It should be a separate patch and better your series starts with it, so it won't interfere with new code. > Can I embedded together with UHS patch? Better to avoid merging orthogonal things together in one change. -- With Best Regards, Andy Shevchenko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel