From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Olivier Moysan <olivier.moysan@foss.st.com>
Cc: Alexandre Torgue <alexandre.torgue@foss.st.com>,
Fabrice Gasnier <fabrice.gasnier@foss.st.com>,
Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
nuno.sa@analog.com, Paul Cercueil <paul@crapouillou.net>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Wan Jiabing <wanjiabing@vivo.com>,
Yannick Brosseau <yannick.brosseau@gmail.com>,
linux-arm-kernel@lists.infradead.org, linux-iio@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com
Subject: Re: [PATCH 1/8] iio: adc: stm32-adc: fix channel sampling time init
Date: Wed, 28 Sep 2022 19:51:04 +0300 [thread overview]
Message-ID: <CAHp75Vf1rJRVK5Emuwk4863DTb9JjTswJefJM-1oX+2gQvLMRg@mail.gmail.com> (raw)
In-Reply-To: <20220928164114.48339-2-olivier.moysan@foss.st.com>
On Wed, Sep 28, 2022 at 7:42 PM Olivier Moysan
<olivier.moysan@foss.st.com> wrote:
>
> Fix channel init for ADC generic channel bindings.
> In generic channel initialization, stm32_adc_smpr_init() is called
> to initialize channel sampling time. The "st,min-sample-time-ns"
> property is an optional property. If it is not defined,
> stm32_adc_smpr_init() is currently skipped. However stm32_adc_smpr_init()
> must always be called, to force a minimum sampling time for
> the internal channels, as the minimum sampling time is known.
> Make stm32_adc_smpr_init() call unconditional.
What is the text width here? It's okay to use Up to ~72 (or slightly
more) as a limit and format accordingly.
> Fixes: 796e5d0b1e9b ("iio: adc: stm32-adc: use generic binding for sample-time")
>
> Signed-off-by: Olivier Moysan <olivier.moysan@foss.st.com>
Tag blocks mustn't have the blank lines.
--
With Best Regards,
Andy Shevchenko
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-09-28 16:52 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-28 16:41 [PATCH 0/8] iio: stm32-adc: add support of adc for stm32mp13 Olivier Moysan
2022-09-28 16:41 ` [PATCH 1/8] iio: adc: stm32-adc: fix channel sampling time init Olivier Moysan
2022-09-28 16:51 ` Andy Shevchenko [this message]
2022-10-02 13:33 ` Jonathan Cameron
2022-09-28 16:41 ` [PATCH 2/8] dt-bindings: iio: adc: stm32-adc: add stm32mp13 compatibles Olivier Moysan
2022-09-28 16:41 ` [PATCH 3/8] iio: adc: stm32-adc: add stm32mp13 support Olivier Moysan
2022-09-28 17:07 ` Andy Shevchenko
2022-10-02 13:42 ` Jonathan Cameron
2022-09-28 16:41 ` [PATCH 4/8] iio: adc: stm32: manage min sampling time on all internal channels Olivier Moysan
2022-09-28 16:41 ` [PATCH 5/8] ARM: dts: stm32: add adc support to stm32mp13 Olivier Moysan
2022-09-28 16:41 ` [PATCH 6/8] ARM: dts: stm32: add adc pins muxing on stm32mp135f-dk Olivier Moysan
2022-09-28 16:41 ` [PATCH 7/8] ARM: dts: stm32: add dummy vdd_adc regulator " Olivier Moysan
2022-09-28 16:41 ` [PATCH 8/8] ARM: dts: stm32: add adc support " Olivier Moysan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHp75Vf1rJRVK5Emuwk4863DTb9JjTswJefJM-1oX+2gQvLMRg@mail.gmail.com \
--to=andy.shevchenko@gmail.com \
--cc=alexandre.torgue@foss.st.com \
--cc=bigeasy@linutronix.de \
--cc=fabrice.gasnier@foss.st.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=nuno.sa@analog.com \
--cc=olivier.moysan@foss.st.com \
--cc=paul@crapouillou.net \
--cc=wanjiabing@vivo.com \
--cc=yannick.brosseau@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).