From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.7 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB5C0C433E0 for ; Fri, 5 Mar 2021 15:12:40 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5BB2D6508D for ; Fri, 5 Mar 2021 15:12:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5BB2D6508D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=U5Tg4FHSR41bVmCSdE8F85DLQPpMkvescil2BTL3e3A=; b=ktHaCr6CGORtXFXjsmRQ+M0KW cxsT8l1SF4BowUDQj4L/LquxbmNRd0TJLjVma3t+y6yarxFwAdW/q7PWBwNVvmJYjuYH9itow/ox9 X/PZouxh1oLvrvedv8+q+cohrcE4PiNaKSs6xZaGrYa/+CZfMbgn1jBnrbciPEq21KaIvEwUlHEwb 59G870H+ZtcJiX+SAIGdEFGMtw2n6lbHDrrNYB+4kcvtouOkDTQvuIeL7PdNdgs2VL8dkN62tbQ6g BaI9s8cK1Q5OZbH+eadcbE7Mg9JRn8/6B4eQivuDQZ2JZ+dnnQioUvWrqs05srhKEXW6FPfPBj6CB xJU+voavg==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lIC5w-00FOjC-08; Fri, 05 Mar 2021 15:10:27 +0000 Received: from mail-pf1-x42e.google.com ([2607:f8b0:4864:20::42e]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lIC5K-00FOdy-S6 for linux-arm-kernel@lists.infradead.org; Fri, 05 Mar 2021 15:09:56 +0000 Received: by mail-pf1-x42e.google.com with SMTP id l7so2370216pfd.3 for ; Fri, 05 Mar 2021 07:09:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=GuLO/+4m3J3HNZ6Nqmidrx/MzLvW8cjxmYnlEV0BLSs=; b=bGLEzA9wG5flnyheuqIHYHjgopFpkciFW7I9BLIJEpEj5jUttovqa3OVTRArTF2JlV B5TxtCMh3eDxI3QNDotufjRHCgQBFaxzbZL97RhfNYkVbopRKmfIwWTI5tnUWhbwjeej 7JR7GSo7lCKKMl20WVu7LnRRKmq5Gxfqb67i6x1JCUDO7HJbG0hvKn4p3GLDJ47q8lJh plEuncX5p7GJx7tPik/s1NV+4PQtTz9Rnc/cvqxjNnpACiuEbPhsPkNnf0VdIKEREYx4 ZZER9nSN5ruDkzung8fmyvZqP7Pw/ELUolXlIVLlE5YlaWRE7qizRmzVj5jcYt2yYXEU s5DA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=GuLO/+4m3J3HNZ6Nqmidrx/MzLvW8cjxmYnlEV0BLSs=; b=bM9sT8yF13OTsrO+h4Bd84MTToM6dx5+qOAov/CUdBarxkiNUlLkChAlrNBvjkqsgd gtYKQJ7cIEcWxZX7mQhTOrzap5BmGV0IiUq9J6KTqL71OgIEaShDUC2F4nAGtzsUlezt 2H7WPVe80pk49Ty2FKMiotrW3CGQ/6TZ+lIqMmJybXxrEDpmylW52+0p/88Nk4vTXkwR 1YNkJ2YtHn6hbcMg42aeTcoyvlVG5GZEGglbdTIAi53fq8fe9kvvc5IYPCLYz8WARhGE CABENXzEEFuj+iM4UD39eBSnKcIoZtxr+lNbSNLpOmrIkoLL00JBmnQ5wVXTINIxXC9C mW1A== X-Gm-Message-State: AOAM533rzEQj/MRi2WEmoTDWCJUwcD+wceFeuSYNjUJo5nCt8Muv51aX 2q9tPn2BTJwggFo2LiJ3fikW9Xu8ejxJ9nhF/70= X-Google-Smtp-Source: ABdhPJySuiVQahfMZKNqzRL9pGTI02zcrDNpr1zvr+iLwhqslvWh769rqoPHBLjJOe9LpOWTi5Y8qTC7TP4RxZffevQ= X-Received: by 2002:a05:6a00:854:b029:1b7:6233:c5f with SMTP id q20-20020a056a000854b02901b762330c5fmr9424227pfk.73.1614956985483; Fri, 05 Mar 2021 07:09:45 -0800 (PST) MIME-Version: 1.0 References: <20210304213902.83903-1-marcan@marcan.st> <20210304213902.83903-11-marcan@marcan.st> In-Reply-To: From: Andy Shevchenko Date: Fri, 5 Mar 2021 17:09:29 +0200 Message-ID: Subject: Re: [RFT PATCH v3 10/27] docs: driver-api: device-io: Document ioremap() variants & access funcs To: Linus Walleij Cc: Hector Martin , Linux ARM , Marc Zyngier , Rob Herring , Arnd Bergmann , Olof Johansson , Krzysztof Kozlowski , Mark Kettenis , Tony Lindgren , Mohamed Mediouni , Stan Skowronek , Alexander Graf , Will Deacon , Mark Rutland , Greg Kroah-Hartman , Jonathan Corbet , Catalin Marinas , Christoph Hellwig , "David S. Miller" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "open list:SERIAL DRIVERS" , Linux Doc Mailing List , linux-samsung-soc , Linux-Arch , "linux-kernel@vger.kernel.org" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210305_150954_675120_F1D0DA15 X-CRM114-Status: GOOD ( 14.30 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Mar 5, 2021 at 12:25 PM Linus Walleij wrote: > On Thu, Mar 4, 2021 at 10:40 PM Hector Martin wrote: > > > This documents the newly introduced ioremap_np() along with all the > > other common ioremap() variants, and some higher-level abstractions > > available. > > > > Signed-off-by: Hector Martin > > I like this, I just want one change: > > Put the common ioremap() on top in all paragraphs, so the norm > comes before the exceptions. > > I.e. it is weird to mention ioremap_np() before mentioning ioremap(). +1 here. That is what I have stumbled upon reading carefully. -- With Best Regards, Andy Shevchenko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel