From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F784C47257 for ; Tue, 5 May 2020 14:15:28 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E90C9206FA for ; Tue, 5 May 2020 14:15:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="fwcXGcz4"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="nfmE75xA" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E90C9206FA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=M2z5ifwTdXKszTJprL5BJJTby2J7YsRvzOy2W7eTSt4=; b=fwcXGcz4hXorsj l+CaR6/mC6hqXIJxZoMhsP5n5dCo+XY0hh6/jefLRC3Gv0hc2roIG8qDTelgQaG6gsJYbURLY8QyY bYe7q6aP08XG+9k4t++/tuERqBiXm1W8BGZa0u8eTthwwLNhpSJeWdVZkvWrY2npGkhCX0ma6LenH erOTfBfehbqn4Elfqyp9fiDwy+ktsAY0N6lEfeO/5omc1z+6t32ldDUHMZMsckuBt0B0xiW5hFPts x2pqR7LYrlAPusqeYX6aRgbCLMz3wNyug47fOVkCU4Y+xmD1brYtKG40LaQ53H7YIVr8xu3h67bzi VC+uBojWVH+lywpPKSfA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jVyM2-0007mu-EI; Tue, 05 May 2020 14:15:26 +0000 Received: from mail-pg1-x543.google.com ([2607:f8b0:4864:20::543]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jVyLz-0007kr-3H for linux-arm-kernel@lists.infradead.org; Tue, 05 May 2020 14:15:24 +0000 Received: by mail-pg1-x543.google.com with SMTP id b8so1064008pgi.11 for ; Tue, 05 May 2020 07:15:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=0nX/PJie6N8ENA2Zvbm0yQ+G3ZDyBTfdd9KJ7MPuSj4=; b=nfmE75xAk2mRtYELliGHUe/ax/6qkgrPatqmkxJZ/4QQY+o+lMk11CjpG4sAQ3FVBV WzncbHPCgbdKwNdc+0McksELLJMYnMAiR59i9RiNpkJ1wTWQvRjMj/LOf+Xb5oeK3q9X 8VD8zvXA45j3xTucUWd8a6+SrLV7AXDs8dsNgTmPYadNJvCSJY3+9yk+3FG9cqznsAn1 Ayjs9sTijBSlXb0wCaoDlmLuPkX19TLs6CSO8ttbuzlrxO+xpFQbVBsTgFRVP0zVj4wd QyMxU4d3tVal6fMMXpNV6WOxd3TZfCk2bsV8QT8ybu6iLP/OmMTw0MsgxUT8NrAH2Rv+ 1Ceg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=0nX/PJie6N8ENA2Zvbm0yQ+G3ZDyBTfdd9KJ7MPuSj4=; b=DPLGCAISp/bfUQ2wJoBnPE4bCY/IgE1AQxU9nMhAFdcCjWjFFWQiX3QHjIiCQTcrqo ZHdN4dW52uH+ffpBGvBrh9PeMT9eCij9HyuodIDWricUbFmbqBFEZ2zqQu03i0qU4a8c 7zZFTvR390IfVVD2R2IaDocLpX1UG/8bkjojUkMHhlPbw8rgOaAvMepl6Ziq5PsmrIuu AleofyQqDKwevlhYpoSA0DVo7U2nfOYm7jhxILIbUeW2sWeBk84syfsU4apr+F26LcAV S8rZFMId/+gDA70cY/wcbT8lPwUHhgWysjwI+wJo16XCJWvO8CDAQA0ayLhlinxavHkk CLHA== X-Gm-Message-State: AGi0PuahdODKmaBXW67dEAYDpHcOAyiDvsKLAqBozmrshGzqj43ILxhr DLReKHbWeYwjA87d6r2XsnKSj6Uxr0LB7Tq98EU= X-Google-Smtp-Source: APiQypLc7JWdA097hNwo8eG2GAZy8/3FtlTIfHPPFCBF9V0wjqm7rU8EeIuNboUNOrlwwMtxJqnfA7pV8Mn60TSZrt8= X-Received: by 2002:a62:5ec7:: with SMTP id s190mr3257831pfb.130.1588688122575; Tue, 05 May 2020 07:15:22 -0700 (PDT) MIME-Version: 1.0 References: <20200505132905.10276-1-calvin.johnson@oss.nxp.com> <20200505132905.10276-5-calvin.johnson@oss.nxp.com> In-Reply-To: <20200505132905.10276-5-calvin.johnson@oss.nxp.com> From: Andy Shevchenko Date: Tue, 5 May 2020 17:15:16 +0300 Message-ID: Subject: Re: [net-next PATCH v3 4/5] net: phy: Introduce fwnode_get_phy_id() To: Calvin Johnson X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200505_071523_679795_025C6044 X-CRM114-Status: GOOD ( 12.56 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew Lunn , Heikki Krogerus , "Rafael J . Wysocki" , Cristi Sovaiala , Ioana Ciornei , Florian Fainelli , "Rajesh V . Bikkina" , Pankaj Bansal , Russell King - ARM Linux admin , Diana Madalina Craciun , ACPI Devel Maling List , Florin Laurentiu Chiculita , Madalin Bucur , Makarand Pawagi , Varun Sethi , Marcin Wojtas , linux-arm Mailing List , Laurentiu Tudor , Greg Kroah-Hartman , Linux Kernel Mailing List , Jeremy Linton , linux.cj@gmail.com, netdev , "David S. Miller" , Heiner Kallweit Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, May 5, 2020 at 4:29 PM Calvin Johnson wrote: > > Extract phy_id from compatible string. This will be used by > fwnode_mdiobus_register_phy() to create phy device using the > phy_id. > +int fwnode_get_phy_id(struct fwnode_handle *fwnode, u32 *phy_id) > +{ > + const char *cp; > + unsigned int upper, lower; > + int ret; > + > + ret = fwnode_property_read_string(fwnode, "compatible", &cp); > + if (!ret) { if (ret) return ret; will help a lot with readability of this. > + if (sscanf(cp, "ethernet-phy-id%4x.%4x", > + &upper, &lower) == 2) { > + *phy_id = ((upper & 0xFFFF) << 16) | (lower & 0xFFFF); How upper can be bigger than 0xfff? Same for lower. > + return 0; > + } > + } > + return -EINVAL; > +} -- With Best Regards, Andy Shevchenko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel