From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CCCA3C43467 for ; Thu, 8 Oct 2020 11:13:08 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4BD3320714 for ; Thu, 8 Oct 2020 11:13:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="11hCgDhh"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="i9dBIZeQ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4BD3320714 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=mbK405wkhyw3NAK2msaqW59/tgWk8WILYz1VSS0e7LY=; b=11hCgDhh9OfiobzkaaOctmO+D T+HtBSlruy4QHWE5KtdeTe2+zssd5Nw5QAOurXeutfYA2NcOmGT2unQQVU8ee9K7zO+fYr+seoC6q ryQmDnsE5foGlGKZ+prrR/C9QiWJhLsjkJouwzokN7W7m8I5PwoOuTiw1zmd/2volSpvJKhLP3k56 nRoG4A9/LmqG9UmL5vWdy1m4Z3DiPvDInCPVL9LWgVhJ6DlLWOxDTpLkPnt0F/hcIE8jp6QpuC11b dcS12k6Pp8lMAroEDvsMuV8tREXNYvez8wagEz8xLuJsMse8HUZRno50kEidSBd6W2Ii/2Mwj7yCh 97+kzl3Zw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kQTpo-0008He-RH; Thu, 08 Oct 2020 11:11:44 +0000 Received: from mail-pg1-x543.google.com ([2607:f8b0:4864:20::543]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kQTpm-0008Gl-Fy for linux-arm-kernel@lists.infradead.org; Thu, 08 Oct 2020 11:11:43 +0000 Received: by mail-pg1-x543.google.com with SMTP id g29so4018075pgl.2 for ; Thu, 08 Oct 2020 04:11:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=TNQsuuPlQCO96OIfCTfqNv2kF5InQ49REdeIqmc413s=; b=i9dBIZeQHwJjZ3PbuyRRP/YORFumtZ7Uhto+wuf99+FdCd2vVq4gF9MTdFlbniasTZ Ocx+7z/0wd88XpxDoZcFTVMTxZAobauR8L+s4xP8ITsY+Julup33HBh2aPuYv+TZGDHb Tfd/+gIrHskVEm5Yv/kxsg4LzPlSgnjhxvWPx2K149MpN46LiOu3FuxvQwMMPcMpuXmZ rW2F6500aIbk6A+JOogQgF0vRPZosmG9yWJ2HGjL+og2Npz+PdKNVNoAlQQY78XJ4rO7 /O8jS97/VadIOH1TkOavHUm0VeD1mySDH9PANmFW6Yf6v60n8jnW2An/62uittjVTH3N jpEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=TNQsuuPlQCO96OIfCTfqNv2kF5InQ49REdeIqmc413s=; b=Ji8/rmAbBCKubLqwlpwV4bNVlpVBuc5wdjz1+t6e/HpY3SYPvFRrcXo4emsYGCBxeO tY/3fj4M+qxKMKWI/Y+6sEJD1VB26SV4P6Vs+MTQiVO0o9jHC3ocjnvgqJtGhGVVN27X MtERwV7gD8hX9sK/cAUvJnD3bdm/CaEA2W1vVn2TmTOD4Eu4srker5wpJqooa7/JJ/BI LlMnSgrD29V/oQjY4zafv6ZWXdKtkuYt6/nfNzVFi1cS6kb+4UhAr6GJwNfvHukFbq9g 5ti2ZVR3oVC03tqAjFmvB899SvvGLgchgN6FE/JFFAF6aVEDeT2Amby3JqTwNV2w7lhc eKrg== X-Gm-Message-State: AOAM530z/epHTjO6x3JAR4WJck5WohXNVCy/BcZzAbsc88AJEZxv0X75 QgnwMsPSPJtsrXX1kYhrHaKGugVbIpJCQvLsYCmA23TEMc+Zwg== X-Google-Smtp-Source: ABdhPJx14bisq4nEXCBiAV2U9hGxJ+4wH2W2fk80Cdp6lh+SEgA0gPxfUKpdwiiQtnaohFiHBvWtOsIfR+EL4uW0DUI= X-Received: by 2002:a65:47c2:: with SMTP id f2mr6925900pgs.4.1602155500218; Thu, 08 Oct 2020 04:11:40 -0700 (PDT) MIME-Version: 1.0 References: <20201008020936.19894-1-muhammad.husaini.zulkifli@intel.com> <20201008020936.19894-4-muhammad.husaini.zulkifli@intel.com> <9deff9d8-b8da-7cc2-19f3-e5baab010d92@xilinx.com> In-Reply-To: From: Andy Shevchenko Date: Thu, 8 Oct 2020 14:12:29 +0300 Message-ID: Subject: Re: [PATCH v4 3/4] mmc: sdhci-of-arasan: Add structure device pointer in probe To: "Zulkifli, Muhammad Husaini" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201008_071142_854758_116C2692 X-CRM114-Status: GOOD ( 16.41 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "ulf.hansson@linaro.org" , "Shevchenko, Andriy" , "arnd@arndb.de" , "linux-kernel@vger.kernel.org" , "linux-mmc@vger.kernel.org" , Michal Simek , "Hunter, Adrian" , "Raja Subramanian, Lakshmi Bai" , "Wan Mohamad, Wan Ahmad Zainie" , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Oct 8, 2020 at 1:36 PM Zulkifli, Muhammad Husaini wrote: > >From: Michal Simek > >Sent: Thursday, October 8, 2020 3:35 PM > >On 08. 10. 20 4:09, muhammad.husaini.zulkifli@intel.com wrote: > >> From: Muhammad Husaini Zulkifli ... > >> @@ -1521,6 +1521,7 @@ static int sdhci_arasan_probe(struct > >platform_device *pdev) > >> struct sdhci_pltfm_host *pltfm_host; > >> struct sdhci_arasan_data *sdhci_arasan; > >> struct device_node *np = pdev->dev.of_node; > >> + struct device *dev = &pdev->dev; > >> const struct sdhci_arasan_of_data *data; > >> > >> match = of_match_node(sdhci_arasan_of_match, pdev->dev.of_node); > >> > > > >This is not what we discussed. You create new variable and you should just use it > >in that function. > > > >s/pdev->dev\./dev->/g > > For widely used in future, we plan to put it here and not specific to Keembay function only. > Any comment on this @Andy Shevchenko? I'm not sure what comment from me is needed. I'm on the same page with Michal, i.e. replace current users of &pdev->dev with a new temporary variable. -- With Best Regards, Andy Shevchenko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel