From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5AE6EC63798 for ; Fri, 20 Nov 2020 19:31:05 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BDEF722254 for ; Fri, 20 Nov 2020 19:31:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="iq6+Goqw"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="evS+J+XB" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BDEF722254 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=QFb2GvrpkKr/n56CcLz2af0PcTvFF2K+1+yMGVSXJ9A=; b=iq6+GoqwGxYxGPwRshDL3yKMz I6Wcx1V2IQiH3DjgWhG9txPwiMpzRIaFIZq2fSLsj7ucVxE+F1o3jFKBmCekf0H1OGTI9g21qG0Vu f+GKvP+WgrOwgjJ/GS9T6UEq5xYl6l/wraIkoF2Jys0NFk2IE0jjCsJUmwIvY2B93TbUFzc2Wv1Ck PZ/Z+Md6Qj9g/Ul045Xbye7T2EIxAb+eiLfvUb/fjNc1RVfjKXNaPuC92sKB9w8RCA6TN+5AHAoI5 HhpcgB1CMml9Duk+3b6O41ezhlRXZkqvuuEBI0lBfJuomvRK0iytm0xfrlZzbDgyt6Q/zOEYBAQLi Bwafm2PNw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kgC6I-0004ec-VA; Fri, 20 Nov 2020 19:29:42 +0000 Received: from mail-lf1-x143.google.com ([2a00:1450:4864:20::143]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kgC6G-0004d6-1f for linux-arm-kernel@lists.infradead.org; Fri, 20 Nov 2020 19:29:40 +0000 Received: by mail-lf1-x143.google.com with SMTP id u18so15020098lfd.9 for ; Fri, 20 Nov 2020 11:29:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=1ENdAioGv2Q8eY87iogzPJTHqRbYcuXrTklYSoVbeVw=; b=evS+J+XBR5p/6mcLYAKQLiKRO2uqyRSublTlr95YtwT17h9QD8IvA2RHEV+qDY+gIZ JOZBmzb7B7518iz/u245hunU4bVVPYU2EE9wSZDPYdInZHbY8p5p40hn7bZzQDZfm4// n5X+f4WcTeSEEoGlIB0zuOXHVvaQg7qDQJgy14VXrPgvui6zzon7LL83fPU//gQp4yG2 iPA5aGTHX3nCxdpYx09TimLS4F4h3nuVBssI6uKoTXbCiKAOrRVG65uxwfgJfp/uycvK EZAVvgYrNMTTZvv1dghGsybJKMZCbQw4Mg3xH43wpknJw2p+Sbzd1kc3aagGuEkrTaLl vpYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=1ENdAioGv2Q8eY87iogzPJTHqRbYcuXrTklYSoVbeVw=; b=X2NdwngarXOe7EWVMXi8gLAuDXBMMR870EFHTImIEkIQ6rKTVTSRFilOWevhDHpodO VqkYUqz1QNl6oc9Iantjc9K2NSmNl2f6FFtGODAYg5UO7flSpHLzL+O9+mfffpU51YYs 83O7UlrQknyrumeM92KpqiuQOk67Vws/xEd3tzUul0Tj3yXHb3pzZFlyX15h3n/aqoqa XYemW/kLl2SZcNmEKuiP+B4nXvNX1rgScJiMXCzOd1OqVILMozm+MWqoYYG8zQpXwyqf XPagcHO9K9iDUXPyA6gWsPPQm7BaysrWItqyVmf5GTProB8Olrc6KFT6yRt6fcIWG7Bd 93HA== X-Gm-Message-State: AOAM533AG34SHmm58a6ou+tk+W5B8Ja4/ir3hbEVjhWHZpm8bY8daB3l cz/LGgK3okIQSyZQg8Y3NZxH3t6xG6xM+i8H73k= X-Google-Smtp-Source: ABdhPJzyhQ/51Q7dV9avp9L46zcpKh9dqFp/SqpRWdON+VWI4lWIjRseexpDE3IvVri66oqD2dWVFl/3LQRB7sJFgfQ= X-Received: by 2002:a05:6512:21c:: with SMTP id a28mr8985486lfo.486.1605900578367; Fri, 20 Nov 2020 11:29:38 -0800 (PST) MIME-Version: 1.0 References: <20201120073909.357536-1-carnil@debian.org> <20201120133400.GA405401@eldamar.lan> <20201120155317.GA502412@eldamar.lan> <20201120183008.GA518373@eldamar.lan> In-Reply-To: <20201120183008.GA518373@eldamar.lan> From: Andrey Zhizhikin Date: Fri, 20 Nov 2020 20:29:26 +0100 Message-ID: Subject: Re: [PATCH] Revert "perf cs-etm: Move definition of 'traceid_list' global variable from header file" To: Salvatore Bonaccorso X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201120_142940_163855_63961A30 X-CRM114-Status: GOOD ( 36.85 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Suzuki Poulouse , Alexander Shishkin , Greg Kroah-Hartman , stable@vger.kernel.org, Tor Jeremiassen , Arnaldo Carvalho de Melo , Peter Zijlstra , Guenter Roeck , Leo Yan , Namhyung Kim , Jiri Olsa , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hello Salvatore, On Fri, Nov 20, 2020 at 7:30 PM Salvatore Bonaccorso wrote: > > Hi Andrey, > > On Fri, Nov 20, 2020 at 05:31:59PM +0100, Andrey Zhizhikin wrote: > > Hello Salvatore, > > > > On Fri, Nov 20, 2020 at 4:53 PM Salvatore Bonaccorso wrote: > > > > > > Hi Andrey, > > > > > > On Fri, Nov 20, 2020 at 03:29:39PM +0100, Andrey Zhizhikin wrote: > > > > Hello Salvatore, > > > > > > > > On Fri, Nov 20, 2020 at 2:34 PM Salvatore Bonaccorso wrote: > > > > > > > > > > Hi Andrey, > > > > > > > > > > On Fri, Nov 20, 2020 at 10:54:22AM +0100, Andrey Zhizhikin wrote: > > > > > > On Fri, Nov 20, 2020 at 8:39 AM Salvatore Bonaccorso wrote: > > > > > > > > > > > > > > This reverts commit 168200b6d6ea0cb5765943ec5da5b8149701f36a upstream. > > > > > > > (but only from 4.19.y) > > > > > > > > > > > > This revert would fail the build of 4.19.y with gcc10, I believe the > > > > > > original commit was introduced to address exactly this case. If this > > > > > > is intended behavior that 4.19.y is not compiled with newer gcc > > > > > > versions - then this revert is OK. > > > > > > > > > > TTBOMK, this would not regress the build for newer gcc (specifically > > > > > gcc10) as 4.19.158 is failing perf tool builds there as well (without > > > > > the above commit reverted). Just as an example v4.19.y does not have > > > > > cff20b3151cc ("perf tests bp_account: Make global variable static") > > > > > which is there in v5.6-rc6 to fix build failures with 10.0.1. > > > > > > > > > > But it did regress builds with older gcc's as for instance used in > > > > > Debian buster (gcc 8.3.0) since 4.19.152. > > > > > > > > > > Do I possibly miss something? If there is a solution to make it build > > > > > with newer GCCs and *not* regress previously working GCC versions then > > > > > this is surely the best outcome though. > > > > > > > > I guess (and from what I understand in Leo's reply), porting of > > > > 95c6fe970a01 ("perf cs-etm: Change tuple from traceID-CPU# to > > > > traceID-metadata") should solve the issue for both older and newer gcc > > > > versions. > > > > > > > > The breakage is now in > > > > [tools/perf/util/cs-etm-decoder/cs-etm-decoder.c] file (which uses > > > > traceid_list inside). This is solved with the above commit, which > > > > concealed traceid_list internally inside [tools/perf/util/cs-etm.c] > > > > file and exposed to [tools/perf/util/cs-etm-decoder/cs-etm-decoder.c] > > > > via cs_etm__get_cpu() call. > > > > > > > > Can you try out to port that commit to see if that would solve your > > > > regression? > > > > > > So something like the following will compile as well with the older > > > gcc version. > > > > > > I realize: I mainline the order of the commits was: > > > > > > 95c6fe970a01 ("perf cs-etm: Change tuple from traceID-CPU# to traceID-metadata") > > > 168200b6d6ea ("perf cs-etm: Move definition of 'traceid_list' global variable from header f > > > ile") > > > > > > But to v4.19.y only 168200b6d6ea was backported, and while that was > > > done I now realize the comment was also changed including the change > > > fom 95c6fe970a01. > > > > > > Thus the proposed backported patch would drop the change in > > > tools/perf/util/cs-etm.c to the comment as this was already done. > > > Thecnically currently the comment would be wrong, because it reads: > > > > > > /* RB tree for quick conversion between traceID and metadata pointers */ > > > > > > but backport of 95c6fe970a01 is not included. > > > > > > Would the right thing to do thus be: > > > > > > - Revert b801d568c7d8 "perf cs-etm: Move definition of 'traceid_list' global variable from header file" > > > - Backport 95c6fe970a01 ("perf cs-etm: Change tuple from traceID-CPU# to traceID-metadata") > > > - Backport 168200b6d6ea ("perf cs-etm: Move definition of 'traceid_list' global variable from header file") > > > > Yes, I believe this would be the correct course of action here; this > > should cover the regression you've encountered and should ensure that > > perf builds on both the "old" and "new" gcc versions. > > Although perf tools in v4.19.y won't compile with recent GCCs. > > Greg did already queued up the first part of it, so the revert. I > think we can pick the later two commits again up after the v4.19.159 > release? Sounds reasonable to me. > > Regards, > Salvatore -- Regards, Andrey. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel