From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 691D9C5519F for ; Fri, 20 Nov 2020 14:30:31 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C374D2224C for ; Fri, 20 Nov 2020 14:30:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="PvWdiDYG"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="GZldtKai" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C374D2224C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=gcA4jRAxj9MD0QE4FxOLtSPm/LWRbF8YOwCHtGfL+h0=; b=PvWdiDYGwuvwhTloXfIWqiK5g tRbQ+rK5IPKwKe+Eo/kjGryHPb4Vt6o6gmOLNkunx2rKiYZIXBPzQOrkZaoEPz8e1BXEo4uWmdExd 0RpxMyJzeELdigGO0Pa/cLQRb8bxmh6F7I25o4fQ5wlBj796QVRf8siCBRp8j0qmwB3e3M5S8lYnB TPFQM8OwGXfY/fHnnKrHSUwNFdV0h8oXJk20uaq5JOHFSwp4XhA/OSvqB6n5vP6wU0YpHb3XfPgaK AIOI0N48G11ptxMQqC2KymtaWvb8gXnmxomaA03Ii/jRLUkOTtghNwrlz6B/roMliiAqC2nZ2WirE 8DMJJGrOA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kg7QC-0001I4-Jy; Fri, 20 Nov 2020 14:29:56 +0000 Received: from mail-lj1-x241.google.com ([2a00:1450:4864:20::241]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kg7QA-0001HT-7Y for linux-arm-kernel@lists.infradead.org; Fri, 20 Nov 2020 14:29:55 +0000 Received: by mail-lj1-x241.google.com with SMTP id o24so10232574ljj.6 for ; Fri, 20 Nov 2020 06:29:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=vDPBgO3uo8+/dosAedlCw+h4RcP8gEHZLzLWs9uGsho=; b=GZldtKaiB6YXXPqkfPYLavH3CBsSoyQ15KZQrz8/Uu1ATyB0SGKdjQjiyY91rlKfc/ uqkbKThLWLf7SrPZ3jSkEIibfao/BBLdW/5SUgWdjFBhJEteidJ+vJA6JfXQRv0GXOW/ yRY1YpznbIhMyTEeFMdqs+Fk8T0CKOAmjodr8FI5YmMUF4et2sIGieTZ+uLzEcHAg4lE Wncs+IDU9GPiBUQp17KluPU3SIWY3CVzCOs0YBFZF26mFQiag9EUa4pTwoEA6ngSJc4T 96QXRCKmwuNcGjs67Bjiew74xePxkA1vhcdfz40gCOlES7Li3dQ3Llcz+MZpNi2NBJMR FlcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=vDPBgO3uo8+/dosAedlCw+h4RcP8gEHZLzLWs9uGsho=; b=ZEhf5l3spIPvRoYHE1hvkAYZguSOpEC3iAEH7FeYHQDdi9f5HNBkrD6493UVWL1vsT YRd5CdG91N1UT6vO/+3ses4jgLhJiJylvCCJnrW5UjTWggALczSVxWwNVrWqN9EMGXH7 +cV4PewZy4rU2B9YX7lnr9CuUwOT1/1nYCpL3YcG7AcFM6Tbq0kEn/Ddx6Z3yaIqOdAY +WVzmlP9sMxjuvZh9dv+bjqpp3MEpy7JGcEcL1WGlKOfvK0nMwrQ4iJ5WhFQrui+SsGF W+7XADCxwhpSDGLgLfzfSnDRRlGWSWeqeZKo4rAp2v20PTodczbKYV+lgEUQg6wCTD6C Q8Pg== X-Gm-Message-State: AOAM530v1+s0D4jt+XV09z83zha6wf4Se+jqXi/kBiOUWv6M6bVAz5Fd sxdhrqcqth/JNsImrUNKG/BMp9ZYqM5448RZiC0= X-Google-Smtp-Source: ABdhPJxgE26On7V77ILRgIjkavE+qP9nC9aScvDtQWqWj9qPSXmu0AsDCVZLXj+hmEmQ9OzsEoKfyu2ToLOUJuHYPe4= X-Received: by 2002:a2e:a416:: with SMTP id p22mr8748493ljn.221.1605882591420; Fri, 20 Nov 2020 06:29:51 -0800 (PST) MIME-Version: 1.0 References: <20201120073909.357536-1-carnil@debian.org> <20201120133400.GA405401@eldamar.lan> In-Reply-To: <20201120133400.GA405401@eldamar.lan> From: Andrey Zhizhikin Date: Fri, 20 Nov 2020 15:29:39 +0100 Message-ID: Subject: Re: [PATCH] Revert "perf cs-etm: Move definition of 'traceid_list' global variable from header file" To: Salvatore Bonaccorso X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201120_092954_351743_D3295D1A X-CRM114-Status: GOOD ( 21.53 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Suzuki Poulouse , Alexander Shishkin , Greg Kroah-Hartman , stable@vger.kernel.org, Tor Jeremiassen , Arnaldo Carvalho de Melo , Peter Zijlstra , Guenter Roeck , Leo Yan , Namhyung Kim , Jiri Olsa , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hello Salvatore, On Fri, Nov 20, 2020 at 2:34 PM Salvatore Bonaccorso wrote: > > Hi Andrey, > > On Fri, Nov 20, 2020 at 10:54:22AM +0100, Andrey Zhizhikin wrote: > > On Fri, Nov 20, 2020 at 8:39 AM Salvatore Bonaccorso wrote: > > > > > > This reverts commit 168200b6d6ea0cb5765943ec5da5b8149701f36a upstream. > > > (but only from 4.19.y) > > > > This revert would fail the build of 4.19.y with gcc10, I believe the > > original commit was introduced to address exactly this case. If this > > is intended behavior that 4.19.y is not compiled with newer gcc > > versions - then this revert is OK. > > TTBOMK, this would not regress the build for newer gcc (specifically > gcc10) as 4.19.158 is failing perf tool builds there as well (without > the above commit reverted). Just as an example v4.19.y does not have > cff20b3151cc ("perf tests bp_account: Make global variable static") > which is there in v5.6-rc6 to fix build failures with 10.0.1. > > But it did regress builds with older gcc's as for instance used in > Debian buster (gcc 8.3.0) since 4.19.152. > > Do I possibly miss something? If there is a solution to make it build > with newer GCCs and *not* regress previously working GCC versions then > this is surely the best outcome though. I guess (and from what I understand in Leo's reply), porting of 95c6fe970a01 ("perf cs-etm: Change tuple from traceID-CPU# to traceID-metadata") should solve the issue for both older and newer gcc versions. The breakage is now in [tools/perf/util/cs-etm-decoder/cs-etm-decoder.c] file (which uses traceid_list inside). This is solved with the above commit, which concealed traceid_list internally inside [tools/perf/util/cs-etm.c] file and exposed to [tools/perf/util/cs-etm-decoder/cs-etm-decoder.c] via cs_etm__get_cpu() call. Can you try out to port that commit to see if that would solve your regression? > > Regards, > Salvatore -- Regards, Andrey. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel