From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C2196C54EE9 for ; Thu, 8 Sep 2022 21:46:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=DJLrTm98w6h/SXlEN4qnEo/lVJJe4nk8RNp8vzfJ9Qc=; b=ngL+gapN8I/suA vFO2hihMwEkmLOqh/hcT4/prTm+jFNPujWtbCpe4Qo9mqel6qbLdJizfB8yE5DQ+0JExS2nVDXUS+ ObIO6xMsm2QmJ/VW+GpctZX8I8+BjpqiWIGkkfOLQaEDIzXQd2WfBm1cgzwcfs57ZJdH6ph/oQHuU YX97mFuYYSV8eAffOkwhkuvB4A1Rmc4p6hVnPvK3lJCT5C34Vri0FGvR4vPBnhlg34nzCleNevGpF vDjWTnGvYMhB4PsPPc6hmRF2ZvT1PmQlDayjcxLmnjNuZ3tDrCUPjF+RUtxsTQFk3j+aZ76ZO8Wzi aZPu7vcu99P/5GHYnAqw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oWPKY-0093G9-QX; Thu, 08 Sep 2022 21:45:02 +0000 Received: from mail-pj1-x1029.google.com ([2607:f8b0:4864:20::1029]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oWPKW-0093E7-Ca for linux-arm-kernel@lists.infradead.org; Thu, 08 Sep 2022 21:45:01 +0000 Received: by mail-pj1-x1029.google.com with SMTP id o4so19055086pjp.4 for ; Thu, 08 Sep 2022 14:44:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gateworks-com.20210112.gappssmtp.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=7cEaCTFyaruFBQRCttlZEmia+ULTPMhy557A0I+PZVU=; b=r7Hw9u+WhhXId/awZajCPDbApW+bjJwxEAaaYBciy88dwMgIIwcHCuAygQAf3SuDq/ NnH6+zZnZ17RE07KVPkHaDMfb3Ji/uHyhD4f97mFKWrwgPjUaEGuEFVshX5IJIX0ItZk B5ocCUuYrty1K/1JOC/Cs7GfcSRvdeT9+AgFbeui68vO24zuLov/NUaBdMEyBOHAfyM3 X5f+hGy9EMzxLu15leKfLH080sZiSayByBnC8FLN69A+SLa976IGpPtIdsUpHjxLeA6+ LKBplBOAdlpeHWORgcyXgpuB9nP77GPFan9NAnKWB4lSUyX+79kfr7CeDBTbEPwyfvCz oYaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=7cEaCTFyaruFBQRCttlZEmia+ULTPMhy557A0I+PZVU=; b=xvdYQQg4QfJC2TJqpAmrH3oeqEcOGoyjnGM4UulmTLZ7N1/quIUVBSAHJnRCbLuvL2 6WnZUuzassZh/gqEgsmgLbC7y4GGOZhcwURCLkR+H0sPewyDue0+yXmTHNa/6dvqOTT4 WSbKkjxyCgu+7XNOStUZVSa8EVjlnmtTWbQNgtZ0JvBrRwO9PNNs1U+lpW2JPNi4/3hb wA0+4XoWQRnFfOtYDWX3FIS9esR/qBxOXmBnkoX6Dn0/La1sR/gL1G5JCbdJw+dS0mS5 mL1GKhM4cHC5qanfytjVFV/rX1WFn1EgxDNd6++InYItWMP5Azsrzbf8ClMJpv6BJLCK A1bw== X-Gm-Message-State: ACgBeo3WS6Vq6cRpVmgB1u84Nk9rckuDo/Yu63pbmIKreZwRUbgES/Id sLw3Cs5OHUIhzIKsmWaIuAX/ubHx4zdI8U1s9jgGeQ== X-Google-Smtp-Source: AA6agR6TzsZ+ZEK//4aI0INXPyodXEgiwr1yjZI6T5OxSxvQy4B9svETdk4ngzWXX1yG2zD3zF8Tn+thxoTxI4Lbjnw= X-Received: by 2002:a17:903:41c6:b0:174:3acf:8294 with SMTP id u6-20020a17090341c600b001743acf8294mr10633273ple.118.1662673498193; Thu, 08 Sep 2022 14:44:58 -0700 (PDT) MIME-Version: 1.0 References: <20220902230500.2624739-1-tharvey@gateworks.com> <20220908211916.GA3348959-robh@kernel.org> In-Reply-To: <20220908211916.GA3348959-robh@kernel.org> From: Tim Harvey Date: Thu, 8 Sep 2022 14:44:46 -0700 Message-ID: Subject: Re: [PATCH 1/2] dt-bindings: arm: Add i.MX8M Mini Gateworks GW7904 board To: Rob Herring Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Krzysztof Kozlowski , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220908_144500_456467_5767DE38 X-CRM114-Status: GOOD ( 18.16 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Sep 8, 2022 at 2:19 PM Rob Herring wrote: > > On Fri, Sep 02, 2022 at 04:04:59PM -0700, Tim Harvey wrote: > > Add DT compatible string for i.MX8M Mini based Gateworks GW7904 board. > > > > Signed-off-by: Tim Harvey > > Cc: Rob Herring > > Cc: Krzysztof Kozlowski > > Cc: Shawn Guo > > Cc: Sascha Hauer > > Cc: Pengutronix Kernel Team > > Cc: Fabio Estevam > > Cc: NXP Linux Team > > --- > > Documentation/devicetree/bindings/arm/fsl.yaml | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml > > index 7431579ab0e8..ce89fac1898e 100644 > > --- a/Documentation/devicetree/bindings/arm/fsl.yaml > > +++ b/Documentation/devicetree/bindings/arm/fsl.yaml > > @@ -831,6 +831,7 @@ properties: > > - gw,imx8mm-gw7901 # i.MX8MM Gateworks Board > > - gw,imx8mm-gw7902 # i.MX8MM Gateworks Board > > - gw,imx8mm-gw7903 # i.MX8MM Gateworks Board > > + - gateworks,imx8mm-gw7904 # i.MX8MM Gateworks Board > > A useful comment would be ones that distuiguish these boards. It's > obvious from the compatible it's a i.MX8MM board from Gateworks. But isn't it clear that you need to go to the device-tree itself to understand the details? As far as basic features go sometimes there is very little difference in these board models. It would be a struggle to list all the board details (which I do in the dts commit) in a way that doesn't take up too much space in fsl.yaml. Best Regards, Tim _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel