From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2FF3BECAAA1 for ; Fri, 9 Sep 2022 15:27:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=fajvQOtLCh4iyuMYyQzqeRm/SrFa2HdoMEilyTrCHNg=; b=m68oKqURoXRXfM Q1e6c4469mgAYGtXLinV2skBzDobxwkAFhkIOqhjmBUApppL1c7CFhvlz6Vm3t3+g+X53HpOntdtV yTC/AHRBG3nVlgMp+jBfhDiNga4yIcrktQzWC2scpI5vQxgodNoCjNqC8YsnLKB+hEGtPodpuB0Ny Wo3cbAf7sHo9nUyZ/A3okDhv2HybblxBKqsiEgFms7kNuWqvWHeXuzKdaaEVc21Ll4SlfrFTlsvbo 00MgfEXRwVwaPt3uAXPeGPMJs0k0Y0zNVA0+Hw04OgziyNd0rEcCq17VDzAdusLNQyqA7lpUqoAYo 2BjULsy+QeflqvQNY22g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oWftl-00HQAe-JP; Fri, 09 Sep 2022 15:26:29 +0000 Received: from mail-pj1-x1029.google.com ([2607:f8b0:4864:20::1029]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oWft6-00HPkG-RL for linux-arm-kernel@lists.infradead.org; Fri, 09 Sep 2022 15:25:51 +0000 Received: by mail-pj1-x1029.google.com with SMTP id z9-20020a17090a468900b001ffff693b27so1920498pjf.2 for ; Fri, 09 Sep 2022 08:25:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gateworks-com.20210112.gappssmtp.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=KQ7mx//Yg3b2on5K+GcpEYxceEeGkrI8LOMH1KIOtyM=; b=apSZrIUd0edt1e799SLrlrQR3GXfeVcUUKtqogNKmO7yvEgyM+r5QdzvwENRWZsvi4 wYUC4Llu/OW541iIwi2uuN+0LvpCKCnIhDLiy6LD7cXmeko44lBKFLIJb8g4o+1kv88j nIgBmeaeoiVlluHT3HvfbgN3Jvq1Kwr30az76zrtzPPlIanPcBoHZ8Yo4hLq2CIYXuUF ci9NkrxM6NVa26MZxzaG9luuGMzvyRho8O3DSuIPcsG2RhjNsfSQvettqeZ1qzVQIxO7 8y0Oeoxh+F8E3Krunu/YzI+bMe8eyYVA498tjMRJ1WbOKZuo/KVMNLIYVq9CEyHuACp5 0hUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=KQ7mx//Yg3b2on5K+GcpEYxceEeGkrI8LOMH1KIOtyM=; b=lGddwh/97cMurLT3Zr3cF8TNwuGqkBeHhhS9F1S6CIludDm1PRjVjQ60c4OyNwwjoT jJIlSGouBX9gRHwed4F6Ns2ap33p9u2LBJHD7QqVWvUQ+gh8R027+Kw0Bz80mC52jqY+ 31oVfE3YU6Q0zXCyjVg/wpv4cYfkDENWc2wKf3S3HWI1CVrSCXYqKk8e6WuO4rWROA/F LpEKXB2ESOGQJqY+AK9Ye7La7sg7xkbOAGQmNqGBVMCTeZMDvx4bT1LNw9gjODJ9Qokr oBuk2DPLjnRqfUictkX49ExSSuyBFcZasU43jrqctm4RHRXE6VTQcdL+hKkDZNO0IQg4 1mqw== X-Gm-Message-State: ACgBeo0qK6x89Qsg13pLDmUPJp6uJLytF029d9JgYDpQI7lNvv2zt2p1 eGJikmK4vlJUVh5VZbos1bmTWqJchlFoGXc5q+DHMQ== X-Google-Smtp-Source: AA6agR70u57I14PlxIWQrF1g1H8PEpE9+18WBH6uHadtu50fnLZueSFTpB0VIM5c6Xnie3UVTtcGT/NvGN/j7P2b5Sg= X-Received: by 2002:a17:903:41c6:b0:174:3acf:8294 with SMTP id u6-20020a17090341c600b001743acf8294mr14185533ple.118.1662737147158; Fri, 09 Sep 2022 08:25:47 -0700 (PDT) MIME-Version: 1.0 References: <20220902230500.2624739-1-tharvey@gateworks.com> <20220908211916.GA3348959-robh@kernel.org> In-Reply-To: From: Tim Harvey Date: Fri, 9 Sep 2022 08:25:35 -0700 Message-ID: Subject: Re: [PATCH 1/2] dt-bindings: arm: Add i.MX8M Mini Gateworks GW7904 board To: Krzysztof Kozlowski Cc: Rob Herring , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Krzysztof Kozlowski , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220909_082549_145733_EA65B1D3 X-CRM114-Status: GOOD ( 26.31 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Sep 9, 2022 at 1:03 AM Krzysztof Kozlowski wrote: > > On 08/09/2022 23:44, Tim Harvey wrote: > > On Thu, Sep 8, 2022 at 2:19 PM Rob Herring wrote: > >> > >> On Fri, Sep 02, 2022 at 04:04:59PM -0700, Tim Harvey wrote: > >>> Add DT compatible string for i.MX8M Mini based Gateworks GW7904 board. > >>> > >>> Signed-off-by: Tim Harvey > >>> Cc: Rob Herring > >>> Cc: Krzysztof Kozlowski > >>> Cc: Shawn Guo > >>> Cc: Sascha Hauer > >>> Cc: Pengutronix Kernel Team > >>> Cc: Fabio Estevam > >>> Cc: NXP Linux Team > >>> --- > >>> Documentation/devicetree/bindings/arm/fsl.yaml | 1 + > >>> 1 file changed, 1 insertion(+) > >>> > >>> diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml > >>> index 7431579ab0e8..ce89fac1898e 100644 > >>> --- a/Documentation/devicetree/bindings/arm/fsl.yaml > >>> +++ b/Documentation/devicetree/bindings/arm/fsl.yaml > >>> @@ -831,6 +831,7 @@ properties: > >>> - gw,imx8mm-gw7901 # i.MX8MM Gateworks Board > >>> - gw,imx8mm-gw7902 # i.MX8MM Gateworks Board > >>> - gw,imx8mm-gw7903 # i.MX8MM Gateworks Board > >>> + - gateworks,imx8mm-gw7904 # i.MX8MM Gateworks Board > >> > >> A useful comment would be ones that distuiguish these boards. It's > >> obvious from the compatible it's a i.MX8MM board from Gateworks. > > > > But isn't it clear that you need to go to the device-tree itself to > > understand the details? > > > > As far as basic features go sometimes there is very little difference > > in these board models. It would be a struggle to list all the board > > details (which I do in the dts commit) in a way that doesn't take up > > too much space in fsl.yaml. > > > > But then the comment you added is useless. So either add useful comment > or no comment. :) > > > Best regards, > Krzysztof Krzysztof, so are you saying that no comment is fine here as well? It seems to me that most of the comments in that file look just like mine which I agree are about just as descriptive as the compatible string. For discussion purposes here is for example the commit log for the GW7904 dts: The GW7904 is based on the i.MX 8M Mini SoC featuring: - LPDDR4 DRAM - eMMC FLASH - microSD connector with UHS support - LIS2DE12 3-axis accelerometer - Gateworks System Controller - IMX8M FEC - 2x RS232 off-board connectors - PMIC - 10x bi-color LED's - 1x miniPCIe socket with PCIe and USB2.0 - 802.3at Class 4 PoE - 10-30VDC input via barrel-jack And the comit log for the very similar GW7903 dts: The GW7903 is based on the i.MX 8M Mini SoC featuring: - LPDDR4 DRAM - eMMC FLASH - microSD connector with UHS support - LIS2DE12 3-axis accelerometer - Gateworks System Controller - IMX8M FEC - software selectable RS232/RS485/RS422 serial transceiver - PMIC - 2x off-board bi-directional opto-isolated digital I/O - 1x M.2 A-E Key Socket and 1x MiniPCIe socket with USB2.0 and PCIe (resistor loading to route PCIe/USB2 between M.2 and MiniPCIe socket) Best Regards, Tim _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel