From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34B28C433B4 for ; Mon, 10 May 2021 16:22:18 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id ACFA8610F7 for ; Mon, 10 May 2021 16:22:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org ACFA8610F7 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=gateworks.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=6N4JnNSlwoRQrOzdlnQlLzNwFtTlaD9Ph2zwai7sSq8=; b=IMLL+AY0dC4iwe8MV9NK1K2N+ wmLr9gU6zExd/wYRElaLi22ZESmxomt/5It1nHwBmZMNpF4yzN3+xB3u8hxlzdlVNbo7LBRMV9opc t9IF4OkD+uShUfMSG7YvSjYKObPNhC/zpswO8kBsoKaSaTNCZt2Bph2Ewf/zrX7uJOnfnidbS3AIi PabYlwrbXUDGC+c8DF7yNxsbhWIkBzX5WyibZV5gkf6ALNtlcIAijCZmS12x++xytMMwmfizjPaWP 8Z5cWRCuG5N1ZxTaM0nafuh6M12kIaqKLK/G3f9UlMDdkjlSA5g86j5om9KS+CwSa6VZ93XfWO/Hl zYCVOn8jw==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lg8e2-00EwJZ-1a; Mon, 10 May 2021 16:20:34 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lg8dy-00EwIZ-Ix for linux-arm-kernel@desiato.infradead.org; Mon, 10 May 2021 16:20:30 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Type:Cc:To:Subject:Message-ID :Date:From:In-Reply-To:References:MIME-Version:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=0fWnbepkZzpOXZd5Aej2WwUh93xVx+Nhqui+NqMG42w=; b=3w2oGZIxIxzAz3dqkcNnx8KC2n bCtpB9+QDvXq/JW9KuA+fYXnHANeFEL60BMXDZmlDS8ruqKbHOKLztAgz+zIrFbl0KbUiLRYYQyVs pPFqmUgjjtOaU1rH67weIdeV+VykFPpJaMcxcvhinxUH+BkHHiEZ3aR8D0GJZOgpj7KnYvv3BQWbF wMQapW/DqW1coDM3dwa3HBcXAJ+c6ZC78wNEhPOMKuHfe9ODYaiAL7GQSeOJBeOSiKOxwVNXQOerF tdNxySVVwJW5dCdB/qWZKarb4lMl+H/KD4/QxNOqtNz+B4IPP5V5S/+4hef1DMf87sQkYEoqyXViY h11th8FA==; Received: from mail-pl1-x636.google.com ([2607:f8b0:4864:20::636]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lg8dv-008uij-MI for linux-arm-kernel@lists.infradead.org; Mon, 10 May 2021 16:20:29 +0000 Received: by mail-pl1-x636.google.com with SMTP id s20so9373028plr.13 for ; Mon, 10 May 2021 09:20:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gateworks-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=0fWnbepkZzpOXZd5Aej2WwUh93xVx+Nhqui+NqMG42w=; b=eJUsSClChBveOTjxjQQ+bmWoecQYo3UAy1n/6GJMl++HeGQLcRlhEyapA7XW4zlZdQ YcsqGGsw4lOSRL5K0tBy+ZOjY6aWUCsv0iw92e9cdh0phgkSpdLoZrEsREIIlmd3KDzf 2tY6aRxMKHQuS/YZL//pd5Yv2E+N09/DaIb7ZM5BngZDdxGQnJOTF75kHn8S0wfrs72J Y85sJ/cSWK+HNJUsrpydfTgc/bTTDFFnEK86hwnKi3P10Zj3GkIxq0RFclaq2orhjr8O BI/BLnaeXl1XcgJwHC5QB35X55iE8cdnkbfuFDbPvpny53P6kpfhSCGJigsq0Y6yKJVG Pv4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=0fWnbepkZzpOXZd5Aej2WwUh93xVx+Nhqui+NqMG42w=; b=NHfOQmpShV6LF+NJ5EmCKkoU8L2g8QE8Q95YpYDslB9AW9tEMYUTHR3ObXSXMtybK7 r6CImqUpPByw7fRR4ZCptyF+Embfk4JmSXDC571qljmY0QxLJOBzmVHzNu1TlDFuDXJs wV+QBlSptbNUhuoN62Yr6NO+toG1y4mYF6iqt9DOe59jaS3zOn7XnWkakleYGIuYpVcT XeXdisP52RT/wIrfOl8PSb8hKtxo7LLlie9pGvoyjG+YJF/TSExNDoP3MLJ+zKuYzgcF omg/zK0W3GhA8NN32lgtxd0z5tJbpjaCbEukQoE0OhvnA1tL+Zm7uTr4AbZdbnCuwYH0 KD5Q== X-Gm-Message-State: AOAM533IUs4I842QeNTlFke//dzVjpmFgcyjTfv4DcQZy9pLPRMuzEju doTkbWaI6D8Zwr0M8aMfIqeWc4JRoptle4Kr2EjKpw== X-Google-Smtp-Source: ABdhPJxUc61uV0PzwOO5GQyXabJ7EkGoObQ6Q+wiAfx+OxvyUE0V+UlwJ9niWyall6JkUFyEFsvYwXMSThRrfKTSX40= X-Received: by 2002:a17:902:d2d2:b029:ee:fb71:c05e with SMTP id n18-20020a170902d2d2b02900eefb71c05emr25806031plc.13.1620663625728; Mon, 10 May 2021 09:20:25 -0700 (PDT) MIME-Version: 1.0 References: <20201005134250.527153-1-marex@denx.de> <20201005134250.527153-3-marex@denx.de> In-Reply-To: From: Tim Harvey Date: Mon, 10 May 2021 09:20:14 -0700 Message-ID: Subject: Re: [PATCH 3/3] [RFC] drm/exynos: Add basic i.MX8MM support code To: Adam Ford Cc: Marek Vasut , linux-samsung-soc , =?UTF-8?Q?Guido_G=C3=BCnther?= , Michael Tretter , dri-devel , Jaehoon Chung , NXP Linux Team , Marek Szyprowski , Shawn Guo , arm-soc X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210510_092027_887096_E3DA2C0A X-CRM114-Status: GOOD ( 30.21 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, May 10, 2021 at 7:12 AM Adam Ford wrote: > > On Mon, Oct 5, 2020 at 8:48 AM Marek Vasut wrote: > > > > This adds basic i.MX8MM glue code for the Samsung DSIM PHY. > > There are still a couple of items which need to be sorted out > > in drivers/gpu/drm/bridge/samsung-dsim.c before this can even > > be merged, specifically: > > > > - The dsi->out_bridge is not populated until samsung_dsim_host_attach() > > is called, however samsung_dsim_host_attach() is not called until the > > next bridge attaches and calls mipi_dsi_attach(), and that only happens > > after the DSIM calls drm_bridge_attach() on that next bridge. > > > > - The samsung_dsim_bridge_mode_fixup() is needed for iMX8MM LCDIF to set > > the correct sync flags. This likely needs to be done in the glue code. > > Since you asked for an RFC, I > I applied Michael's series and this series to 5.12 since we are so > close on having the blk-clk and the power domain stuff working. I > also tried your patch for the ti-sn65dsi83 and the adv7511 on the > Beacon imx8mm development kit. > > In both the HDMI bridge and LVDS bridge, I am able to get the modetest > and drmdevice to return data that looks valid. The resolution and > refresh look correct, but I am not able to can an actual image to > generate out to either the LVDS or the HDMI. I am able to get the > image to appear using the NXP kernel with the ADV7511 HDMI bridge, so > that leads me to believe there might be something wrong with either > LCDIF or the Samsung DSIM layer code. I am guess it's the Samsung > DSIM stuff since the LCDIF has been around for a while. > > I am not particularly well versed in the video world, but if you have > something you'd like me to try, i am willing to try it. > Adam, Try the patches Frieder had to make for his display from his git here: https://github.com/fschrempf/linux/commits/v5.10-mx8mm-graphics. I found I needed these for the display I have: drm/exynos: Fix DE polarity for usage with LCDIF encoder drm/exynos: Fix PLL PMS offset for P value bitfield Best regards, Tim _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel