From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 591F9C4338F for ; Sat, 24 Jul 2021 18:21:14 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2A92E60E92 for ; Sat, 24 Jul 2021 18:21:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 2A92E60E92 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=gateworks.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=bN7SCN3xSnJogktGGYXC2QNN+CdnCfrsmTaTZ40HEvQ=; b=IzeuwsuXQgXYe+ HInyEqDMbIYMh54IEgErGXWZv1bdXJbMkpSugmRvBgULwbVtHo4QOVvvuz1eEPS5/RHCHEfWigoK9 krz7Qe2ZhRUCEQKv1ODouPcTJrx+hehijQ8dL+UDox9gtmIIEws0s/63XKPYUyzJ97JUOGuiE4CaQ /07S/XJ5TSmFMxajG+BXAYy2LRGEVBXXevQTZh1leBdS2GCNh8xrAoQqzgfwBmGFDfYGxaGB+NIGM htv2ydq3U2sKSKu1wAmHzbs0x9ESPPxrciNGqkYeKj4snXCkVbNNycLSRNRmlvRjI+rGnLSkZ4y8O IrSpKC7PuAt+cG+oDfzw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m7MFQ-007dCQ-25; Sat, 24 Jul 2021 18:19:40 +0000 Received: from mail-pl1-x632.google.com ([2607:f8b0:4864:20::632]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m7MFM-007dC0-0s for linux-arm-kernel@lists.infradead.org; Sat, 24 Jul 2021 18:19:37 +0000 Received: by mail-pl1-x632.google.com with SMTP id e5so4921803pld.6 for ; Sat, 24 Jul 2021 11:19:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gateworks-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=408uhdvajAOrgk79juAKDI2FDzjmrADhiWfdmKM+KPI=; b=hK7VFty7Tc4YPcJvy+uZR/slVfij+TwIuNFMc0dnh3UaHilkhUIWYEaX5JDDNPfZ2o ObHnfXK8U3OxAA+9yIHh4gfSFJfQbMgE0aOQFWy886cTIl5tll1n/3eD6okIq8qMlptE zelGxVzQFmky17e1xGlWU3B+RURwrdtY6+undHd3sLZ3sD6Y5nUhcPTv4xQsPziiEVsk CXCSJw8SQbcCsVb9SdL/1h9UHaBbmrPEQGJH91Ag/lD3zxXuqPt63njVzD0eUSmvwZRz 1aQo2FYp/KH2G8vpoPAQR7gglx0tYZtCXet1UYSavFle387ODPp4K71Tfl2NWNARyvkm 767Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=408uhdvajAOrgk79juAKDI2FDzjmrADhiWfdmKM+KPI=; b=SeVD15Z6/9vHuk1ze+NaaYKtw/anfK15pIEq3oia6z4ffRL8RykpKDZWmGP7sigjVi 8SxYuG9BKelR94ePT1EE/xvRoLJlS7snCPZ7TeRuqbXivIYdAFMGo4ai0FrOkXUF+jVn 55mfGsxQ+Ep8P1vb2LYOOhFyPMrugRqoOWxQXji5anNW0F5WJmdbn7Z7y2dscL0qS/Jx MTmDFj4gXz4glRGHakuwPZqpsApOV8y21FSHrRtzxKU+DvbybNSeGQHvZaugzVe8gTWn WUkB+UpNKjHSajgHGCswoTPiWxPz9HirQA9+llv6ksN23DEiTCYSVBbIgLIJueopvZxb uVHg== X-Gm-Message-State: AOAM533wvMkyHVYYIsX9kcLTZb/2hOED00F6eSQflS9/XOcJU/cEqE6k gLAeeXyazq26Zs57LYlAvCvlKSBXJkIUCiN0jC6imw== X-Google-Smtp-Source: ABdhPJypEhLUTyn9hcujdchfL1vVeJ8hK+oQRto1ad9VADd7QIJrxmMQcS5Dvh+kMH1BsWG0VtQ7gSJg+U5Q8KTPjlw= X-Received: by 2002:a62:be18:0:b029:2aa:db3a:4c1d with SMTP id l24-20020a62be180000b02902aadb3a4c1dmr10249726pff.58.1627150774927; Sat, 24 Jul 2021 11:19:34 -0700 (PDT) MIME-Version: 1.0 References: <20210601174917.1979-1-tharvey@gateworks.com> <20210601174917.1979-2-tharvey@gateworks.com> In-Reply-To: <20210601174917.1979-2-tharvey@gateworks.com> From: Tim Harvey Date: Sat, 24 Jul 2021 11:19:21 -0700 Message-ID: Subject: Re: [PATCH 2/4] arm64: dts: imx8mm-venice-gw700x: fix mp5416 pmic config To: Rob Herring , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team Cc: Device Tree Mailing List , Linux ARM Mailing List X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210724_111936_153524_C6E276DF X-CRM114-Status: GOOD ( 16.63 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jun 1, 2021 at 10:49 AM Tim Harvey wrote: > > Fix various MP5416 PMIC configurations: > - Update regulator names per dt-bindings > - ensure values fit among valid register values > - add required regulator-max-microamp property > - add regulator-always-on prop > > Signed-off-by: Tim Harvey > --- > .../dts/freescale/imx8mm-venice-gw700x.dtsi | 56 ++++++++++++------- > 1 file changed, 37 insertions(+), 19 deletions(-) > > diff --git a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw700x.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw700x.dtsi > index 512b76cd7c3b..f4eb827baed7 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw700x.dtsi > +++ b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw700x.dtsi > @@ -283,65 +283,83 @@ > reg = <0x69>; > > regulators { > + /* vdd_0p95: DRAM/GPU/VPU */ > buck1 { > - regulator-name = "vdd_0p95"; > - regulator-min-microvolt = <805000>; > + regulator-name = "buck1"; > + regulator-min-microvolt = <800000>; > regulator-max-microvolt = <1000000>; > - regulator-max-microamp = <2500000>; > + regulator-min-microamp = <3800000>; > + regulator-max-microamp = <6800000>; > regulator-boot-on; > + regulator-always-on; > }; > > + /* vdd_soc */ > buck2 { > - regulator-name = "vdd_soc"; > - regulator-min-microvolt = <805000>; > + regulator-name = "buck2"; > + regulator-min-microvolt = <800000>; > regulator-max-microvolt = <900000>; > - regulator-max-microamp = <1000000>; > + regulator-min-microamp = <2200000>; > + regulator-max-microamp = <5200000>; > regulator-boot-on; > + regulator-always-on; > }; > > + /* vdd_arm */ > buck3_reg: buck3 { > - regulator-name = "vdd_arm"; > - regulator-min-microvolt = <805000>; > + regulator-name = "buck3"; > + regulator-min-microvolt = <800000>; > regulator-max-microvolt = <1000000>; > - regulator-max-microamp = <2200000>; > - regulator-boot-on; > + regulator-min-microamp = <3800000>; > + regulator-max-microamp = <6800000>; > + regulator-always-on; > }; > > + /* vdd_1p8 */ > buck4 { > - regulator-name = "vdd_1p8"; > + regulator-name = "buck4"; > regulator-min-microvolt = <1800000>; > regulator-max-microvolt = <1800000>; > - regulator-max-microamp = <500000>; > + regulator-min-microamp = <2200000>; > + regulator-max-microamp = <5200000>; > regulator-boot-on; > + regulator-always-on; > }; > > + /* nvcc_snvs_1p8 */ > ldo1 { > - regulator-name = "nvcc_snvs_1p8"; > + regulator-name = "ldo1"; > regulator-min-microvolt = <1800000>; > regulator-max-microvolt = <1800000>; > - regulator-max-microamp = <300000>; > regulator-boot-on; > + regulator-always-on; > }; > > + /* vdd_snvs_0p8 */ > ldo2 { > - regulator-name = "vdd_snvs_0p8"; > + regulator-name = "ldo2"; > regulator-min-microvolt = <800000>; > regulator-max-microvolt = <800000>; > regulator-boot-on; > + regulator-always-on; > }; > > + /* vdd_0p9 */ > ldo3 { > - regulator-name = "vdd_0p95"; > - regulator-min-microvolt = <800000>; > - regulator-max-microvolt = <800000>; > + regulator-name = "ldo3"; > + regulator-min-microvolt = <900000>; > + regulator-max-microvolt = <900000>; > regulator-boot-on; > + regulator-always-on; > }; > > + /* vdd_1p8 */ > ldo4 { > - regulator-name = "vdd_1p8"; > + regulator-name = "ldo4"; > regulator-min-microvolt = <1800000>; > regulator-max-microvolt = <1800000>; > regulator-boot-on; > + regulator-always-on; > }; > }; > }; > -- > 2.17.1 > Shawn, Is there anything you want changed here? Best regards, Tim _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel