From mboxrd@z Thu Jan 1 00:00:00 1970 From: myungjoo.ham@samsung.com (MyungJoo Ham) Date: Mon, 11 Jul 2016 11:19:16 +0900 Subject: [PATCH -next] PM / devfreq: exynos-ppmu: remove unneeded of_node_put() In-Reply-To: <1467985444-9242-1-git-send-email-weiyj_lk@163.com> References: <1467985444-9242-1-git-send-email-weiyj_lk@163.com> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Fri, Jul 8, 2016 at 10:44 PM, wrote: > From: Wei Yongjun > > for_each_child_of_node() performs an of_node_put() on each iteration, so > putting an of_node_put() before a continue results in a double put. > > Generated by: scripts/coccinelle/iterators/device_node_continue.cocci > > Signed-off-by: Wei Yongjun Thank you! Signed-off-by: MyungJoo Ham > --- > drivers/devfreq/event/exynos-ppmu.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/devfreq/event/exynos-ppmu.c b/drivers/devfreq/event/exynos-ppmu.c > index 845bf25..f55cf0e 100644 > --- a/drivers/devfreq/event/exynos-ppmu.c > +++ b/drivers/devfreq/event/exynos-ppmu.c > @@ -406,8 +406,6 @@ static int of_get_devfreq_events(struct device_node *np, > of_property_read_string(node, "event-name", &desc[j].name); > > j++; > - > - of_node_put(node); > } > info->desc = desc; > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in > the body of a message to majordomo at vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- MyungJoo Ham, Ph.D. Frontier CS Lab, S/W Center, Samsung Electronics