From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 12588C433F5 for ; Tue, 11 Oct 2022 11:12:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=vs3+cWuWbopAr9RPRcoOB8+ET3z/21eRDnyr6cqudzA=; b=WdO7ybKcB0paJv 6zjgtruuh6m4WPXhC4nWPBKZ6KwnbiVXVOK4uBLX3PPfZL66UDD9iKIXaDQUYxOLXjbYdMXNVtIDg 4AXSrqpUA58RGW1iG8FeQFbXSLX3aGeWcY4SxHzm/rXxOpH4RG3GGVRnKNra9Gcfl3SWZnr59yRKb Kd+vOorYn2sfN2+ykQacHH6r4EpqHNkeMgA0tnjj0p13/FCZoSJ0cFCcYN57ET20pNQ/rtwrgDO3V UkIbTiRf1RVI48LL/09J70e1P0mFmnIzAIJu5BQlws8F6SsYYBF26nWZehkBdsSi13k61C1izxTOo 2BLcYbH5NAfEOT16cohA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oiDAF-0045Yo-8u; Tue, 11 Oct 2022 11:11:11 +0000 Received: from mail-pj1-x102c.google.com ([2607:f8b0:4864:20::102c]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oiDAC-0045Xg-H7 for linux-arm-kernel@lists.infradead.org; Tue, 11 Oct 2022 11:11:10 +0000 Received: by mail-pj1-x102c.google.com with SMTP id 70so12170505pjo.4 for ; Tue, 11 Oct 2022 04:11:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=xyNu7ihVwa1kCmrsin+0WcnVl1ur8OzhltqOfbUTT10=; b=UZwIeeRg3uQhc+cpCzs6z0nQw2QZwvYVcjh3Tev6Nh1AaxET6iyPGP8LvCk7pGfNNO CWqx4NbFYdHi9MUlsJRCQzG47fLY3YozQb9exZzE5yn8D1Wq2HZSCyRL7nHPBv1r52w1 KkCuYotEuqz/mv/klQcC8SUuxpd51/SjhC6Fi8XwDfmemRt+sDiQ48X+nnDTHoXRQw6f P0rBoCWkOT9k5qjy6h8dKhHD7NI2milNdGmYpnTOSju/+qlLaE51yISSZJeZhs+xML1u rjZWufVDRRbWpwRM/RxUzMPhDOkwdlkApaMv2pcm6VhtVpoyNBwiKy++7bIrIyWOvc8c CLZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=xyNu7ihVwa1kCmrsin+0WcnVl1ur8OzhltqOfbUTT10=; b=QU/prc5JiddKU6d8Nt19a8wMb/J3O8nDDvqlxSf0joqfsdLHAkZsBE28C/XclXU6dX 6LNOd+BlwPbUEwDfXtQPJzw1V/1ZRObE38Z+V5c8t40JNUnypu3zGbtnmdi0uRg5lbzD lvBQyMJ/fxQucDx3eWJwG7qlCKhSRgSlaIIGTZrKsRcpD1O8PwADlEPa+h2tj02ryAql yjCpo+XbHADmTcAuAG4uN/pFpB3RJlQJgh3CFkLKFnwXRgFUSTAMpTdo1O5JlpRUPoFD 3ADKkpe+lC2aj58DBLmy8ocZDrQnil7Lxj5lySkl+5FBCH5N2Rt1/mChXJTkg4/dvnbU IkdA== X-Gm-Message-State: ACrzQf1xW9L74m9qxxmvimlBT/2QQ/xEm2gn86K1CIHHQWKCsd04U7Z2 d6psGUVwgxXr8be+FujrrsxiBLOpToXsOLv6O5Fq8g== X-Google-Smtp-Source: AMsMyM7X9jF5KQTbREd1W8ZkKnNsDJAq+kh9AegZu7oAqTnFNWKJTzxtA4V3YI69PYMg7pEsV3hi+SDJhsdAHk7UZyc= X-Received: by 2002:a17:90b:4b4b:b0:20a:926f:3c2e with SMTP id mi11-20020a17090b4b4b00b0020a926f3c2emr25763482pjb.87.1665486664825; Tue, 11 Oct 2022 04:11:04 -0700 (PDT) MIME-Version: 1.0 References: <20220809223401.24599-1-mike.leach@linaro.org> <20220809223401.24599-4-mike.leach@linaro.org> <65e70db9-9f85-7285-0602-f2d29887550a@arm.com> <55170f1f-99f7-6e25-55d3-5d7247737afc@arm.com> In-Reply-To: <55170f1f-99f7-6e25-55d3-5d7247737afc@arm.com> From: Mike Leach Date: Tue, 11 Oct 2022 12:10:53 +0100 Message-ID: Subject: Re: [PATCH v3 03/13] coresight: stm: Update STM driver to use Trace ID API To: Suzuki K Poulose Cc: coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, mathieu.poirier@linaro.org, peterz@infradead.org, mingo@redhat.com, acme@kernel.org, linux-perf-users@vger.kernel.org, leo.yan@linaro.org, quic_jinlmao@quicinc.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221011_041108_602730_D8815F2D X-CRM114-Status: GOOD ( 29.97 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi suzuki, On Fri, 7 Oct 2022 at 18:53, Suzuki K Poulose wrote: > > On 06/10/2022 14:54, Mike Leach wrote: > > Hi Suzuki, > > > > On Mon, 3 Oct 2022 at 10:04, Suzuki K Poulose wrote: > >> > >> On 09/08/2022 23:33, Mike Leach wrote: > >>> Updates the STM driver to use the trace ID allocation API. > >>> This uses the _system_id calls to allocate an ID on device poll, > >>> and release on device remove. > >>> > >>> The sysfs access to the STMTRACEIDR register has been changed from RW > >>> to RO. Having this value as writable is not appropriate for the new > >>> Trace ID scheme - and had potential to cause errors in the previous > >>> scheme if values clashed with other sources. > >>> > >>> Signed-off-by: Mike Leach > >>> Reviewed-by: Suzuki K Poulose > > >>> @@ -854,7 +830,7 @@ static void stm_init_generic_data(struct stm_drvdata *drvdata, > >>> > >>> static int stm_probe(struct amba_device *adev, const struct amba_id *id) > >>> { > >>> - int ret; > >>> + int ret, trace_id; > >>> void __iomem *base; > >>> struct device *dev = &adev->dev; > >>> struct coresight_platform_data *pdata = NULL; > >>> @@ -938,12 +914,22 @@ static int stm_probe(struct amba_device *adev, const struct amba_id *id) > >>> goto stm_unregister; > >>> } > >>> > >>> + trace_id = coresight_trace_id_get_system_id(); > >>> + if (trace_id < 0) { > >> > >> The above API returns "INVALID_ID" and not a negative error status. > >> I think it is better to fix the API to return: > >> > >> ret < 0 - If there is any error > >> - Otherwise a positive integer > >> And the users should be kept unaware of which ID is valid or invalid. > >> > > > > coresight_trace_id_get_system_id() returns the ID if one can be > > allocated or -EINVAL if not. > > > > Not sure what you are looking at here. > > Sorry, indeed I was mistaken there. It is the get_cpu_id() which > returns the INVALID_ID on failure. Please could we make that > consistent with this scheme ? i.e, < 0 on error. > That also returns -EINVAL, as both call the same underlying allocator. However happy to add on the comments for the exported functions Regards Mike > Also, please could we add a comment above the exported functions > on their entry/exit criteria ? It is not clearly evident, unless > we follow the code and figure out. > > Cheers > Suzuki > -- Mike Leach Principal Engineer, ARM Ltd. Manchester Design Centre. UK _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel