From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9BD32C43463 for ; Fri, 18 Sep 2020 15:37:09 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 29D4B20848 for ; Fri, 18 Sep 2020 15:37:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Ae3tI4yL"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="NhrlGHs+" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 29D4B20848 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=KKr310niOyfYY+SJRf1TKjsQg+HZsq5BRYjsXe4qFNw=; b=Ae3tI4yL6tJpsRXUb4qR+TVnK N8+JZjwmDI+cdIlR0hff62Ntyj7X1vOhCVmIXBLnEPMIGrMCVQduWTPRakECYr5r35rs/bHDlmTQ2 o/eRekNh3IFKrPIaydeBTDOcArOQqfD5k6wBLOM3uIL1Vy6olSGzTG7kRGdKsKnE4Og61GIYAP/zr fwyRSd59njTMFzfR5P9w5G6aApZAUTaqJflkpxxZhXuBQIifd35IIs3YAIlS8W5JiPwq1DmAhF1cM R/McOEV/TO6Huovx5xN47EyL97sKLEtwxfFm9YoZdqrKBgOj9cTusrn+CtD+WWytGx4S4jELLJPQt xbcJLFL9Q==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kJIPi-0005Pk-BO; Fri, 18 Sep 2020 15:35:06 +0000 Received: from mail-ej1-x644.google.com ([2a00:1450:4864:20::644]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kJIPH-0005Fz-TO for linux-arm-kernel@lists.infradead.org; Fri, 18 Sep 2020 15:34:45 +0000 Received: by mail-ej1-x644.google.com with SMTP id z22so8677405ejl.7 for ; Fri, 18 Sep 2020 08:34:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=cAK2VHTn+Sy8csvPkETRoA1F1ZD2qnWkF1kwva6tStE=; b=NhrlGHs+c9xVq3XDjF6ZAoW4rDNx2Wyo3qQwz5RxPy2CnL8RT/NA97FvBdk+stOIoN o2AYt+yLZ6Pv1JHIkhShkvcD+GJ58arbAUFsZWVSk8BsbiQfSDkNkrqZHdpefCTWlyHK fs0Jynh0FRdKZGPlb2J2q/MyfpmJR9B8mawdcC7IY6tHSkazJ4m7QhiwEyn4ZnffREJy nErECrhtF4N5F2uBVAjD41T0Ewv7+8trr5ajgzwN9cUrqey2iJuKHyGZ4mgdx6K9Kt1C pI+BMTcpS834VY8zRbUuj0wAfJT6MGlnornQD3hvYWRmWIklxz2W1JKmpR7tvNsPOk3n T/XQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=cAK2VHTn+Sy8csvPkETRoA1F1ZD2qnWkF1kwva6tStE=; b=UKMpMegYBA3vPOKBjWT2yrhq9NBsuz43mR6e5SVc2PKVugybycgGBZuFM3o0WOuIMt 2dBVBCrYqDAj+FC1VJXpeOxU2jAqfS4u1gbYOivqz18ryF5baObYoENxgDP+lGvrx9xl 3VYd5TAFNbDu4y/cKEUKGrlfMXiOi3uqpieHXvEkN46f3o7qCXCGUDr6X05PcomZ/57g MzHjKRs6rWIDFztx9eUQrHeTztjj1Fe8he8FRxeMV0OcFiqT7NakzGAqKykSiQXn6//E WML4evNzKZeXcoprqfI9D3jf6JJVjVKno0O/6M/NMjQ8CdXjQzfyKQdlBm3vgXK6ick2 UQSw== X-Gm-Message-State: AOAM530+EuCebj9rvSWUM6d9vprnTlrHWm3swcTItijvSY3hJQwP+qTX wM2+EyEi25ZIfVRy16rKo2QTHN+MB3ntV2hifRS+cA== X-Google-Smtp-Source: ABdhPJxx2URQ14I+Cj8LcH5aRG+/YM0CA2MZWhEWmNPQyc9OJhcQ0cRk6Xblf0l9DxaT9pLnZpLeQ4SoUeLGOwObM7A= X-Received: by 2002:a17:907:110f:: with SMTP id qu15mr38218008ejb.359.1600443278809; Fri, 18 Sep 2020 08:34:38 -0700 (PDT) MIME-Version: 1.0 References: <20200911084119.1080694-1-suzuki.poulose@arm.com> <20200911084119.1080694-7-suzuki.poulose@arm.com> In-Reply-To: <20200911084119.1080694-7-suzuki.poulose@arm.com> From: Mike Leach Date: Fri, 18 Sep 2020 16:34:28 +0100 Message-ID: Subject: Re: [PATCH 06/19] coresight: etm4x: Always read the registers on the host CPU To: Suzuki K Poulose X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200918_113440_012463_67ADF96E X-CRM114-Status: GOOD ( 14.78 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Coresight ML , Anshuman.Khandual@arm.com, Mathieu Poirier , linux-arm-kernel , Leo Yan Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Reviewed-by: Mike Leach On Fri, 11 Sep 2020 at 09:41, Suzuki K Poulose wrote: > > As we are about to add support for sysreg access to ETM4.4+ components, > make sure that we read the registers only on the host CPU. > > Cc: Mike Leach > Reviewed-by: Mathieu Poirier > Signed-off-by: Suzuki K Poulose > --- > .../coresight/coresight-etm4x-sysfs.c | 23 ++++++++----------- > 1 file changed, 10 insertions(+), 13 deletions(-) > > diff --git a/drivers/hwtracing/coresight/coresight-etm4x-sysfs.c b/drivers/hwtracing/coresight/coresight-etm4x-sysfs.c > index a588cd6de01c..57fc8dad2e92 100644 > --- a/drivers/hwtracing/coresight/coresight-etm4x-sysfs.c > +++ b/drivers/hwtracing/coresight/coresight-etm4x-sysfs.c > @@ -2341,23 +2341,20 @@ static u32 etmv4_cross_read(const struct device *dev, u32 offset) > return reg.data; > } > > -#define coresight_etm4x_reg(name, offset) \ > - coresight_simple_reg32(struct etmv4_drvdata, name, offset) > - > #define coresight_etm4x_cross_read(name, offset) \ > coresight_simple_func(struct etmv4_drvdata, etmv4_cross_read, \ > name, offset) > > -coresight_etm4x_reg(trcpdcr, TRCPDCR); > -coresight_etm4x_reg(trcpdsr, TRCPDSR); > -coresight_etm4x_reg(trclsr, TRCLSR); > -coresight_etm4x_reg(trcauthstatus, TRCAUTHSTATUS); > -coresight_etm4x_reg(trcdevid, TRCDEVID); > -coresight_etm4x_reg(trcdevtype, TRCDEVTYPE); > -coresight_etm4x_reg(trcpidr0, TRCPIDR0); > -coresight_etm4x_reg(trcpidr1, TRCPIDR1); > -coresight_etm4x_reg(trcpidr2, TRCPIDR2); > -coresight_etm4x_reg(trcpidr3, TRCPIDR3); > +coresight_etm4x_cross_read(trcpdcr, TRCPDCR); > +coresight_etm4x_cross_read(trcpdsr, TRCPDSR); > +coresight_etm4x_cross_read(trclsr, TRCLSR); > +coresight_etm4x_cross_read(trcauthstatus, TRCAUTHSTATUS); > +coresight_etm4x_cross_read(trcdevid, TRCDEVID); > +coresight_etm4x_cross_read(trcdevtype, TRCDEVTYPE); > +coresight_etm4x_cross_read(trcpidr0, TRCPIDR0); > +coresight_etm4x_cross_read(trcpidr1, TRCPIDR1); > +coresight_etm4x_cross_read(trcpidr2, TRCPIDR2); > +coresight_etm4x_cross_read(trcpidr3, TRCPIDR3); > coresight_etm4x_cross_read(trcoslsr, TRCOSLSR); > coresight_etm4x_cross_read(trcconfig, TRCCONFIGR); > coresight_etm4x_cross_read(trctraceid, TRCTRACEIDR); > -- > 2.24.1 > -- Mike Leach Principal Engineer, ARM Ltd. Manchester Design Centre. UK _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel