From: Mike Leach <mike.leach@linaro.org>
To: Tingwei Zhang <tingwei@codeaurora.org>
Cc: tsoni@codeaurora.org,
Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org>,
Kim Phillips <kim.phillips@arm.com>,
Mathieu Poirier <mathieu.poirier@linaro.org>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Coresight ML <coresight@lists.linaro.org>,
Randy Dunlap <rdunlap@infradead.org>,
Mian Yousaf Kaukab <ykaukab@suse.de>,
Russell King <linux@armlinux.org.uk>,
Mao Jinlong <jinlmao@codeaurora.org>,
Leo Yan <leo.yan@linaro.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v6 08/25] coresight: etm: perf: Fix warning caused by etm_setup_aux failure
Date: Mon, 3 Aug 2020 18:11:12 +0100 [thread overview]
Message-ID: <CAJ9a7VhdGfcdfk3J1Vt9MSSn8Q1wb+x-nukudkh4LYCbMecO9w@mail.gmail.com> (raw)
In-Reply-To: <20200731064012.8076-9-tingwei@codeaurora.org>
On Fri, 31 Jul 2020 at 07:41, Tingwei Zhang <tingwei@codeaurora.org> wrote:
>
> When coresight_build_path() fails on all the cpus, etm_setup_aux
> calls etm_free_aux() to free allocated event_data.
> WARN_ON(cpumask_empty(mask) will be triggered since cpu mask is empty.
> Check event_data->snk_config is not NULL first to avoid this
> warning.
>
> Signed-off-by: Tingwei Zhang <tingwei@codeaurora.org>
> ---
> drivers/hwtracing/coresight/coresight-etm-perf.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/hwtracing/coresight/coresight-etm-perf.c b/drivers/hwtracing/coresight/coresight-etm-perf.c
> index dcb0592418ae..3728c44e5763 100644
> --- a/drivers/hwtracing/coresight/coresight-etm-perf.c
> +++ b/drivers/hwtracing/coresight/coresight-etm-perf.c
> @@ -126,10 +126,10 @@ static void free_sink_buffer(struct etm_event_data *event_data)
> cpumask_t *mask = &event_data->mask;
> struct coresight_device *sink;
>
> - if (WARN_ON(cpumask_empty(mask)))
> + if (!event_data->snk_config)
> return;
>
> - if (!event_data->snk_config)
> + if (WARN_ON(cpumask_empty(mask)))
> return;
>
> cpu = cpumask_first(mask);
> --
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project
>
Reviewed by: Mike Leach <mike.leach@linaro.org>
--
Mike Leach
Principal Engineer, ARM Ltd.
Manchester Design Centre. UK
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-08-03 17:13 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-31 6:39 [PATCH v6 00/25] coresight: allow to build coresight as modules Tingwei Zhang
2020-07-31 6:39 ` [PATCH v6 01/25] coresight: cpu_debug: add module name in Kconfig Tingwei Zhang
2020-08-03 16:21 ` Mike Leach
2020-07-31 6:39 ` [PATCH v6 02/25] coresight: cpu_debug: define MODULE_DEVICE_TABLE Tingwei Zhang
2020-07-31 6:39 ` [PATCH v6 03/25] coresight: use IS_ENABLED for CONFIGs that may be modules Tingwei Zhang
2020-07-31 6:39 ` [PATCH v6 04/25] coresight: add coresight prefix to barrier_pkt Tingwei Zhang
2020-07-31 6:39 ` [PATCH v6 05/25] coresight: export global symbols Tingwei Zhang
2020-08-03 17:10 ` Mike Leach
2020-07-31 6:39 ` [PATCH v6 06/25] coresight: add try_get_module() in coresight_grab_device() Tingwei Zhang
2020-08-03 17:10 ` Mike Leach
2020-07-31 6:39 ` [PATCH v6 07/25] coresight: stm: allow to build coresight-stm as a module Tingwei Zhang
2020-08-03 17:10 ` Mike Leach
2020-07-31 6:39 ` [PATCH v6 08/25] coresight: etm: perf: Fix warning caused by etm_setup_aux failure Tingwei Zhang
2020-08-03 17:11 ` Mike Leach [this message]
2020-07-31 6:39 ` [PATCH v6 09/25] coresight: etm3x: allow etm3x to be built as a module Tingwei Zhang
2020-08-03 17:11 ` Mike Leach
2020-07-31 6:39 ` [PATCH v6 10/25] coresight: etm4x: allow etm4x " Tingwei Zhang
2020-08-03 17:11 ` Mike Leach
2020-07-31 6:39 ` [PATCH v6 11/25] coresight: etb: allow etb " Tingwei Zhang
2020-08-03 17:11 ` Mike Leach
2020-07-31 6:39 ` [PATCH v6 12/25] coresight: tpiu: allow tpiu " Tingwei Zhang
2020-08-03 17:11 ` Mike Leach
2020-07-31 6:40 ` [PATCH v6 13/25] coresight: tmc: allow tmc " Tingwei Zhang
2020-08-03 17:11 ` Mike Leach
2020-07-31 6:40 ` [PATCH v6 14/25] coresight: funnel: remove multiple init calls from funnel driver Tingwei Zhang
2020-08-03 17:11 ` Mike Leach
2020-07-31 6:40 ` [PATCH v6 15/25] coresight: replicator: remove multiple init calls Tingwei Zhang
2020-08-03 17:11 ` Mike Leach
2020-07-31 6:40 ` [PATCH v6 16/25] coresight: allow funnel and replicator drivers to be built as modules Tingwei Zhang
2020-08-03 17:11 ` Mike Leach
2020-07-31 6:40 ` [PATCH v6 17/25] coresight: cti: add function to register cti associate ops Tingwei Zhang
2020-08-03 17:11 ` Mike Leach
2020-07-31 6:40 ` [PATCH v6 18/25] coresight: cti: Fix remove sysfs link error Tingwei Zhang
2020-07-31 6:40 ` [PATCH v6 19/25] coresight: cti: Fix bug clearing sysfs links on callback Tingwei Zhang
2020-07-31 6:40 ` [PATCH v6 20/25] coresight: cti: don't disable ect device if it's not enabled Tingwei Zhang
2020-08-03 17:13 ` Mike Leach
2020-08-04 0:21 ` Tingwei Zhang
2020-08-04 14:36 ` Mike Leach
2020-07-31 6:40 ` [PATCH v6 21/25] coresight: cti: increase reference count when enabling cti Tingwei Zhang
2020-08-03 17:13 ` Mike Leach
2020-07-31 6:40 ` [PATCH v6 22/25] coresight: cti: allow cti to be built as a module Tingwei Zhang
2020-08-03 17:11 ` Mike Leach
2020-07-31 6:40 ` [PATCH v6 23/25] coresight: tmc-etr: add function to register catu ops Tingwei Zhang
2020-08-03 17:12 ` Mike Leach
2020-07-31 6:40 ` [PATCH v6 24/25] coresight: catu: allow catu drivers to be built as modules Tingwei Zhang
2020-08-03 17:12 ` Mike Leach
2020-08-04 0:37 ` Tingwei Zhang
2020-07-31 6:40 ` [PATCH v6 25/25] coresight: allow the coresight core driver to be built as a module Tingwei Zhang
2020-08-03 17:12 ` Mike Leach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJ9a7VhdGfcdfk3J1Vt9MSSn8Q1wb+x-nukudkh4LYCbMecO9w@mail.gmail.com \
--to=mike.leach@linaro.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=coresight@lists.linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=jinlmao@codeaurora.org \
--cc=kim.phillips@arm.com \
--cc=leo.yan@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux@armlinux.org.uk \
--cc=mathieu.poirier@linaro.org \
--cc=rdunlap@infradead.org \
--cc=saiprakash.ranjan@codeaurora.org \
--cc=suzuki.poulose@arm.com \
--cc=tingwei@codeaurora.org \
--cc=tsoni@codeaurora.org \
--cc=ykaukab@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).