From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 627A2C43463 for ; Fri, 18 Sep 2020 15:43:12 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6919B208DB for ; Fri, 18 Sep 2020 15:43:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="KJmPNMhx"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="k1by4YA7" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6919B208DB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=kqb9hsjNP4QmCuOecfCtTZ5UtAj/fO7ByNHEL+McRkA=; b=KJmPNMhxBmFUW/CCDviDRk+bm 0z10beNpT0GoQbIt59wMXjLQH2F6aloTlqIA9t1ZdUDC//HwRonspCSPLapT4WHWa0AG+z7cAFXSq sQxkDbl/c9rIub/B7VmDhHRhk9wstFKnWyqHr8n9c7+HvIgTM7UR//ZUVq8d87Bz/2TbfLidsGST5 Cfqg+H1Oc5xZrN/S1nOv4LRAh5fwxiikaB6SXtthWfuW0LDLahgP0X3GTpyKjlH1qcRyJu64D9uF2 U2uRPiB7kN+otQlKgOXPi1yZJWBYWV6wpg99Is3d0BmvzKdibr0rhbjfzFnh648b66YrYeDZRsrOb +u6raSSxw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kJIVB-0007dj-Qj; Fri, 18 Sep 2020 15:40:46 +0000 Received: from mail-ed1-x541.google.com ([2a00:1450:4864:20::541]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kJIQk-0005oD-40 for linux-arm-kernel@lists.infradead.org; Fri, 18 Sep 2020 15:36:13 +0000 Received: by mail-ed1-x541.google.com with SMTP id w1so6540869edr.3 for ; Fri, 18 Sep 2020 08:36:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=WveLPwxte8BNoxoMIlXLIgv/Aiiq1ZIY8kNPvPeIDoE=; b=k1by4YA7dTBFe8ff3zdpPES5vmi76Q13ceAuL5wGpkdRC7yHm1/HwVo5r1/G0h556H fJACyD/EKYHPZO0Ic/VVrlgtk5StadM5g4X/eGJHSTX9G3CYZC9IWhTxcnY0Xauu9WEn cEJtyMnFUJGMB/R1o9CkM3VHbfVH2BSzZh70M8ZJsdt9HDie+zYv5QmYeRefIVKTWsLm BsGDTaG0qJoCNaqyAyzNSyahT8lZpn2bWSK9I6YaiR2mwoueFNdHl1At0PH2+ILODcZL tW5cvaoRc9bCqfbLP/pFEY5cTY4FGwAYAyLfKG/LDI5d7mkUwx+W0/RJZMuE+ZNrADHm yNHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=WveLPwxte8BNoxoMIlXLIgv/Aiiq1ZIY8kNPvPeIDoE=; b=TBk5gsbCFwIbVf2munW2vyDIzLvMEAhAfvJXYiflInRxPUeLLm7d8dfSTtfWuTtqfu JV0ocNxxGwcjy1nTDiV0MPgtj175CpY/UF2jb7i13W6yie5rC6CFJSvw4E/NBqJH+Axn j1GKUYfSUtvS1CVPRjaKVz/VcKuRilS5JPU9LtsgEqSeyDlddmpWiH6xq5iMiE3cIfOW 3AXTHO4UMeyLAZo4M9WC1V50OAk0fl6/4PxDewtz2kJMqBGWhr8aj88ZoQSLedVjhoyC XWhlnA54zqIIm2UTSTYZna44D6eKu477cw5Mh/VD4J7Vd2ChgD6I0LivxEQViLzACRzW KJdQ== X-Gm-Message-State: AOAM531FKBhRgoUdVdBf5gLcVv9bz5iSsNCEouw/dpsxX4dzAazxSLAR tUlew5Yw+NJSaDmuPwMny/hgVLVrNAbAwwtIuKxTU3OQ3ug= X-Google-Smtp-Source: ABdhPJzZuAxRQfefmN/3K7ZkWHJ9XCjJmxI8la6kJ+kuLqddcjt57Pvxb9Ni+59rXoZeMqL3jjADNrFwaSEi2bf+hWU= X-Received: by 2002:aa7:d403:: with SMTP id z3mr38253584edq.310.1600443367977; Fri, 18 Sep 2020 08:36:07 -0700 (PDT) MIME-Version: 1.0 References: <20200911084119.1080694-1-suzuki.poulose@arm.com> <20200911084119.1080694-20-suzuki.poulose@arm.com> In-Reply-To: <20200911084119.1080694-20-suzuki.poulose@arm.com> From: Mike Leach Date: Fri, 18 Sep 2020 16:35:57 +0100 Message-ID: Subject: Re: [PATCH 19/19] dts: bindings: coresight: ETMv4.4 system register access only units To: Suzuki K Poulose X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200918_113610_279571_D48575C1 X-CRM114-Status: GOOD ( 15.50 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Mathieu Poirier , Anshuman.Khandual@arm.com, Coresight ML , Leo Yan , Rob Herring , linux-arm-kernel Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 11 Sep 2020 at 09:41, Suzuki K Poulose wrote: > > Document the bindings for ETMv4.4 and later with only system register > access. > > Cc: devicetree@vger.kernel.org > Cc: Mathieu Poirier > Cc: Mike Leach > Reviewed-by: Rob Herring > Signed-off-by: Suzuki K Poulose > --- > Documentation/devicetree/bindings/arm/coresight.txt | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/arm/coresight.txt b/Documentation/devicetree/bindings/arm/coresight.txt > index d711676b4a51..cfe47bdda728 100644 > --- a/Documentation/devicetree/bindings/arm/coresight.txt > +++ b/Documentation/devicetree/bindings/arm/coresight.txt > @@ -34,9 +34,13 @@ its hardware characteristcs. > Program Flow Trace Macrocell: > "arm,coresight-etm3x", "arm,primecell"; > > - - Embedded Trace Macrocell (version 4.x): > + - Embedded Trace Macrocell (version 4.x), with memory mapped access. > "arm,coresight-etm4x", "arm,primecell"; > > + - Embedded Trace Macrocell (version 4.4 and later) with system > + register access only. > + "arm,coresight-etm-v4.4"; Any version of ETM can implement register access - including those pre ETM 4.4. Perhaps the new name should simply reflect sys reg access rather than a version. Given that the two compatibility strings should be mutually exclusive for a given device, should the bindings doc (or at least the etm4x component part) be re-written into the .yaml format so that this can be enforced? Regards Mike > + > - Coresight programmable Replicator : > "arm,coresight-dynamic-replicator", "arm,primecell"; > > -- > 2.24.1 > -- Mike Leach Principal Engineer, ARM Ltd. Manchester Design Centre. UK _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel