From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29257C433DB for ; Sat, 6 Mar 2021 11:23:41 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A5CD464EDB for ; Sat, 6 Mar 2021 11:23:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A5CD464EDB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=hiXRq0EdZ6oIEUkc2gqWG27qjgM7a+UQbUKEtj0SG/M=; b=Nd+1f+6coDT1FEUrfDUvwfEvw JLSMc9dlwbHisUkwnkxwLmRz57K5wuaaxbZlUSiyBoqUmVCHvg3lgdzEU/oXaCRIQjmUV2pqTygbO e9NFiR8DA7hpDGaWTY9G/1oG+/GdmvfjJVgvsL3tYTX2cSgFJV0Ew2FGTUhfGZ+8X1Nx9qKP01nxY gf3ZYt0Y5jegEBiExsm7d1J4ruFWB1D2eQPNlcUpQVtoCLLmF0cGasXIKNB2AinttA+uOKrXqwNGk B6fTQOBTlqGBufO0ZVm0SrpwiYi4vFyDjAwFIHw+qt505LpLdtiLZJWor0CqRHRMOerwntJhc5HdD fC8JLe3cg==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lIV0K-002rrU-6g; Sat, 06 Mar 2021 11:21:52 +0000 Received: from mail-oo1-xc35.google.com ([2607:f8b0:4864:20::c35]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lIV08-002rpo-DG for linux-arm-kernel@lists.infradead.org; Sat, 06 Mar 2021 11:21:42 +0000 Received: by mail-oo1-xc35.google.com with SMTP id l5so1069238ooj.7 for ; Sat, 06 Mar 2021 03:21:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=wNNodHdM1DfUBgw6jc8F0SEIH4kQrwrL9lC1u6BgmVc=; b=ngU6IUjv9gYu1AUZg2ACSDLtJf4naqHCtoFmwouQNZr1jStuvKesHbhuyWOD6oO+Ys cfZhLKQGl/GTBqDRT4U98kpCnzp2viEAlHtbi5wTxq+xMKs19Gg5iQh86Z4OEkw+Hkwz 7wVydaM8GyHG6duodOIdnB8HIDu7u52TwpFXT6lysC8Ui03cZlWXcLicSH3Kv4mpMDih tQNUJ8POC62tgeA1HN+t+By6a6KDfHnFyOF/kycAGJwTfzRTU67LoP0RgZJsXlTcSkBy cpGgNyfZD4LI5xHuiDznrqsLNdi4O3exFDQ8EoLc7C2yKZKHA+FvvsS9fUKoFaGr1jPC DXkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=wNNodHdM1DfUBgw6jc8F0SEIH4kQrwrL9lC1u6BgmVc=; b=m/whPjqEwZB7HdUvgdQ3//p4jH/AwvI0AfsXqdHsSBSCPpCxXYUoBSUAHXCqE/QUV2 XGGPKdVilV1u1QMLJ8k4qON1DDQpYUwlPeDVuHh/aGYYY0piXarZs+daT5dXtjiFOy3I 3Y/toT5bCFQgOhk/qytljq6aKDELpgxWGQO0UCxhImEBS14kD3yNGNI4OTEUXvPV8JAp +S6GnjaWotuE/5GZdlawLibUcQBqMi2sKPN9Svw2jad0OC9RFNaJZWtHarFWtnRHTW8K ZSbzR/Uh3F1HTy2lg0HnxIyHM2bpfTuao9ZR6UbEjwhKjmHGYealVMYdjf6WefvSKB7v 9qtw== X-Gm-Message-State: AOAM530W0fU/LBUD8N1o8onHCKLQSo037X9y9OeW6RV97ONc8i1sGSor xbMZLggDi13Qu7IZ9Nrv4jWTXXwld9dD9l2Q+FY= X-Google-Smtp-Source: ABdhPJzQbMIRGfVdioITylEcTlSFc76OYobXwWKhvIVcSHO9qaiCKLkviEy/CPRC1TqpZENSzz09++3A8FKlDlEztps= X-Received: by 2002:a4a:e093:: with SMTP id w19mr11219735oos.53.1615029698478; Sat, 06 Mar 2021 03:21:38 -0800 (PST) MIME-Version: 1.0 References: <20210203235403.308539-1-marex@denx.de> <20210303125614.GG15865@dragon> <3189923d-df38-6dab-6be7-b2439c234fe4@denx.de> <20210304075652.GN15865@dragon> <5ae1374f-fd10-523f-7b6f-fa7fb40eba20@denx.de> <20210305083931.GT15865@dragon> <678b6564-14c2-7085-8750-06bbc235ae8d@denx.de> <20210306110718.GX15865@dragon> In-Reply-To: <20210306110718.GX15865@dragon> From: Shawn Guo Date: Sat, 6 Mar 2021 19:21:28 +0800 Message-ID: Subject: Re: [PATCH] ARM: dts: imx6q-dhcom: Add PU,VDD1P1,VDD2P5 regulators To: Marek Vasut Cc: linux-arm-kernel@lists.infradead.org, Christoph Niedermaier , Fabio Estevam , Ludwig Zenz , NXP Linux Team , Greg Kroah-Hartman , Arnd Bergmann X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210306_112140_634098_0FC13CDF X-CRM114-Status: GOOD ( 30.56 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, Mar 6, 2021 at 7:10 PM Shawn Guo wrote: > > On Fri, Mar 05, 2021 at 12:19:25PM +0100, Marek Vasut wrote: > > On 3/5/21 9:39 AM, Shawn Guo wrote: > > > On Thu, Mar 04, 2021 at 01:07:32PM +0100, Marek Vasut wrote: > > > > On 3/4/21 8:56 AM, Shawn Guo wrote: > > > > > On Wed, Mar 03, 2021 at 03:04:07PM +0100, Marek Vasut wrote: > > > > > > On 3/3/21 1:56 PM, Shawn Guo wrote: > > > > > > > On Thu, Feb 04, 2021 at 12:54:03AM +0100, Marek Vasut wrote: > > > > > > > > Per schematic, both PU and SOC regulator are supplied from LTC3676 SW1 > > > > > > > > via VDDSOC_IN rail, add the PU input. Both VDD1P1, VDD2P5 are supplied > > > > > > > > from LTC3676 SW2 via VDDHIGH_IN rail, add both inputs. > > > > > > > > > > > > > > > > Fixes: 52c7a088badd ("ARM: dts: imx6q: Add support for the DHCOM iMX6 SoM and PDK2") > > > > > > > > > > > > > > It's more like an improvement or additions rather than fixes. I dropped > > > > > > > the tag and applied for -next. > > > > > > > > > > > > I would argue that describing SoC regulators correctly is a bugfix, since it > > > > > > can lead to stability issues of the SoC. > > > > > > > > > > Then resend the patch with details of the issue that it fixes. > > > > > > > > Can you please tell me what is missing in the original patch description > > > > that justifies dropping the Fixes: tag ? I would argue that fully describing > > > > CPU regulators in DT is a fix which should go through the stable tree and > > > > the original patch description is accurate. > > > > > > You claim that the patch fixes a stability issue, but commit log > > > mentions nothing about it. > > > > Correction, I claim it can lead to stability issues, so far none were > > observed to my knowledge. But I would argue a correct regulator setup in DT > > for a specific device is a bugfix and should go through stable tree. Please > > correct me if I'm wrong. > > All I'm asking is that you resend the patch with commit log stating why > this is a bugfix and should go through stable tree, because it's not > obvious at least to me. In case it's still not clear, the message you replied me multiple times here should really be put into the commit log. Shawn _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel