From: Guo Ren <guoren@kernel.org>
To: Palmer Dabbelt <palmer@dabbelt.com>,
Arnd Bergmann <arnd@arndb.de>, Christoph Hellwig <hch@lst.de>
Cc: linux-arch <linux-arch@vger.kernel.org>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
linux-riscv <linux-riscv@lists.infradead.org>,
linux-csky@vger.kernel.org,
linux-s390 <linux-s390@vger.kernel.org>,
sparclinux <sparclinux@vger.kernel.org>,
linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
"Parisc List" <linux-parisc@vger.kernel.org>,
"open list:BROADCOM NVRAM DRIVER" <linux-mips@vger.kernel.org>,
"Linux ARM" <linux-arm-kernel@lists.infradead.org>,
"the arch/x86 maintainers" <x86@kernel.org>,
"Heiko Stübner" <heiko@sntech.de>,
"Guo Ren" <guoren@linux.alibaba.com>,
"Guo Ren" <guoren@kernel.org>
Subject: Re: [PATCH V8 10/20] riscv: compat: Re-implement TASK_SIZE for COMPAT_32BIT
Date: Mon, 21 Mar 2022 08:22:08 +0800 [thread overview]
Message-ID: <CAJF2gTSqbS3cUNcxKGoMT2zE3ws+gH6a0EssVEutpypR5YoHCA@mail.gmail.com> (raw)
In-Reply-To: <20220316070317.1864279-11-guoren@kernel.org>
For this patch, we need to add below to fixup the rv32 call rv64 elf
segment fault.
diff --git a/arch/riscv/include/asm/processor.h
b/arch/riscv/include/asm/processor.h
index 0749924d9e55..21c8072dce17 100644
--- a/arch/riscv/include/asm/processor.h
+++ b/arch/riscv/include/asm/processor.h
@@ -19,7 +19,11 @@
#define TASK_UNMAPPED_BASE PAGE_ALIGN(TASK_SIZE / 3)
#define STACK_TOP TASK_SIZE
-#define STACK_TOP_MAX STACK_TOP
+#ifdef CONFIG_64BIT
+#define STACK_TOP_MAX TASK_SIZE_64
+#else
+#define STACK_TOP_MAX TASK_SIZE
+#endif
#define STACK_ALIGN 16
#ifndef __ASSEMBLY__
On Wed, Mar 16, 2022 at 3:04 PM <guoren@kernel.org> wrote:
>
> From: Guo Ren <guoren@linux.alibaba.com>
>
> Make TASK_SIZE from const to dynamic detect TIF_32BIT flag
> function. Refer to arm64 to implement DEFAULT_MAP_WINDOW_64 for
> efi-stub.
>
> Limit 32-bit compatible process in 0-2GB virtual address range
> (which is enough for real scenarios), because it could avoid
> address sign extend problem when 32-bit enter 64-bit and ease
> software design.
>
> The standard 32-bit TASK_SIZE is 0x9dc00000:FIXADDR_START, and
> compared to a compatible 32-bit, it increases 476MB for the
> application's virtual address.
>
> Signed-off-by: Guo Ren <guoren@linux.alibaba.com>
> Signed-off-by: Guo Ren <guoren@kernel.org>
> Reviewed-by: Arnd Bergmann <arnd@arndb.de>
> Tested-by: Heiko Stuebner <heiko@sntech.de>
> ---
> arch/riscv/include/asm/pgtable.h | 13 +++++++++++--
> 1 file changed, 11 insertions(+), 2 deletions(-)
>
> diff --git a/arch/riscv/include/asm/pgtable.h b/arch/riscv/include/asm/pgtable.h
> index e3549e50de95..afdc9ece2ba4 100644
> --- a/arch/riscv/include/asm/pgtable.h
> +++ b/arch/riscv/include/asm/pgtable.h
> @@ -705,8 +705,17 @@ static inline pmd_t pmdp_establish(struct vm_area_struct *vma,
> * 63–48 all equal to bit 47, or else a page-fault exception will occur."
> */
> #ifdef CONFIG_64BIT
> -#define TASK_SIZE (PGDIR_SIZE * PTRS_PER_PGD / 2)
> -#define TASK_SIZE_MIN (PGDIR_SIZE_L3 * PTRS_PER_PGD / 2)
> +#define TASK_SIZE_64 (PGDIR_SIZE * PTRS_PER_PGD / 2)
> +#define TASK_SIZE_MIN (PGDIR_SIZE_L3 * PTRS_PER_PGD / 2)
> +
> +#ifdef CONFIG_COMPAT
> +#define TASK_SIZE_32 (_AC(0x80000000, UL) - PAGE_SIZE)
> +#define TASK_SIZE (test_thread_flag(TIF_32BIT) ? \
> + TASK_SIZE_32 : TASK_SIZE_64)
> +#else
> +#define TASK_SIZE TASK_SIZE_64
> +#endif
> +
> #else
> #define TASK_SIZE FIXADDR_START
> #define TASK_SIZE_MIN TASK_SIZE
> --
> 2.25.1
>
--
Best Regards
Guo Ren
ML: https://lore.kernel.org/linux-csky/
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-03-21 0:23 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-16 7:02 [PATCH V8 00/20] riscv: compat: Add COMPAT Kbuild skeletal support guoren
2022-03-16 7:02 ` [PATCH V8 01/20] uapi: simplify __ARCH_FLOCK{,64}_PAD a little guoren
2022-03-16 7:02 ` [PATCH V8 02/20] uapi: always define F_GETLK64/F_SETLK64/F_SETLKW64 in fcntl.h guoren
2022-03-16 7:03 ` [PATCH V8 03/20] compat: consolidate the compat_flock{, 64} definition guoren
2022-03-16 7:03 ` [PATCH V8 04/20] kconfig: Add SYSVIPC_COMPAT for all architectures guoren
2022-03-16 7:03 ` [PATCH V8 05/20] fs: stat: compat: Add __ARCH_WANT_COMPAT_STAT guoren
2022-03-16 7:03 ` [PATCH V8 06/20] asm-generic: compat: Cleanup duplicate definitions guoren
2022-03-16 7:03 ` [PATCH V8 07/20] syscalls: compat: Fix the missing part for __SYSCALL_COMPAT guoren
2022-03-16 7:03 ` [PATCH V8 08/20] riscv: Fixup difference with defconfig guoren
2022-03-16 7:03 ` [PATCH V8 09/20] riscv: compat: Add basic compat data type implementation guoren
2022-03-16 7:03 ` [PATCH V8 10/20] riscv: compat: Re-implement TASK_SIZE for COMPAT_32BIT guoren
2022-03-21 0:22 ` Guo Ren [this message]
2022-03-16 7:03 ` [PATCH V8 11/20] riscv: compat: syscall: Add compat_sys_call_table implementation guoren
2022-03-16 7:03 ` [PATCH V8 12/20] riscv: compat: syscall: Add entry.S implementation guoren
2022-03-16 7:03 ` [PATCH V8 13/20] riscv: compat: process: Add UXL_32 support in start_thread guoren
2022-03-16 7:03 ` [PATCH V8 14/20] riscv: compat: Add elf.h implementation guoren
2022-03-16 7:03 ` [PATCH V8 15/20] riscv: compat: Add hw capability check for elf guoren
2022-03-16 7:03 ` [PATCH V8 16/20] riscv: compat: vdso: Add COMPAT_VDSO base code implementation guoren
2022-03-16 7:03 ` [PATCH V8 17/20] riscv: compat: vdso: Add setup additional pages implementation guoren
2022-03-16 7:03 ` [PATCH V8 18/20] riscv: compat: signal: Add rt_frame implementation guoren
2022-03-16 7:03 ` [PATCH V8 19/20] riscv: compat: ptrace: Add compat_arch_ptrace implement guoren
2022-03-16 7:03 ` [PATCH V8 20/20] riscv: compat: Add COMPAT Kbuild skeletal support guoren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJF2gTSqbS3cUNcxKGoMT2zE3ws+gH6a0EssVEutpypR5YoHCA@mail.gmail.com \
--to=guoren@kernel.org \
--cc=arnd@arndb.de \
--cc=guoren@linux.alibaba.com \
--cc=hch@lst.de \
--cc=heiko@sntech.de \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-csky@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-parisc@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-s390@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=palmer@dabbelt.com \
--cc=sparclinux@vger.kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).