From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 15B26C31E51 for ; Tue, 18 Jun 2019 09:27:16 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E36A2213F2 for ; Tue, 18 Jun 2019 09:27:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="NJEpi92C"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="ImqAUIso" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E36A2213F2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=c7UwqTIO7xs9GmI9ZQUno4yisO+mvXgDqUmYy3X7lAc=; b=NJEpi92CXd0hy/ J0whW3Ame1QKC4HSXdKCCKtbl8vMKBa7YoeQOy8bNhkuV+U3BONnonuIIY4CTPcQkqpIECpMsecyS xCFsA6CXzkzobGGEkWgRSauQ+Gk1KsCoXqtZwl1RY7AdFcXEhwgu0t6jkZdSa/cTmSTqDOyV31T6o ukn8zhjCWP+jcFvr+hEMJRcK+bHHKmyP08ZKi+oh5pPkPHT5DtvAAENRvpn/eZmtiC1u7AVpDUVLh fxrEGwHpmVM/zJ+SH7D5Fz4826zQUD1qCmrz48PTPfeqxY+ckOEaxwisK+szJ9Mc2Ln6t0EkRyIpL mRnG2Vjnv5h6rNWLuNTA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hdAOZ-0005lZ-K7; Tue, 18 Jun 2019 09:27:15 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hdAOW-0005kL-4S for linux-arm-kernel@lists.infradead.org; Tue, 18 Jun 2019 09:27:13 +0000 Received: from mail-lj1-f182.google.com (mail-lj1-f182.google.com [209.85.208.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6EE4C2147A for ; Tue, 18 Jun 2019 09:27:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1560850031; bh=3d0WB2FWSq617HwBgtInbOFcIijY2d0ifcR6Ea00qN8=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=ImqAUIsomz+S+K3RJ1At8naHxBQ5VKVZ7zN2BeD/fqyI+PN1PHJnllocUrPWLqL9R 4RJoVrM+vEJSIBAnQ89brETmsQokQSFSKDVLkqSdOszPh70zYhR+Ki5IN1H8jvO2tV LgI2Q6sdVSP+1oDmThdaHW4dcWzk0NYRSuQd/mvA= Received: by mail-lj1-f182.google.com with SMTP id s21so12353535lji.8 for ; Tue, 18 Jun 2019 02:27:11 -0700 (PDT) X-Gm-Message-State: APjAAAW8rmcwaGbQBMN0m+mcLJWONkaLhuji9FcOLECc2ICrID6YfpkX JLO+bBiH+MhGPyyxE6kIYuWGEFS0AXSwkzY8k/8= X-Google-Smtp-Source: APXvYqzv7Gbmd6Xf/1K1px/rY6lBV7NSaMJUwamp2eOU1O40f6wjgppWFyx9CidnmsTWpf06LGliW+GVZtXWpi54Tbo= X-Received: by 2002:a2e:8155:: with SMTP id t21mr10481642ljg.80.1560850029693; Tue, 18 Jun 2019 02:27:09 -0700 (PDT) MIME-Version: 1.0 References: <20190614203144.3850-2-joseph.kogut@gmail.com> <20190614235719.8134-1-joseph.kogut@gmail.com> In-Reply-To: <20190614235719.8134-1-joseph.kogut@gmail.com> From: Krzysztof Kozlowski Date: Tue, 18 Jun 2019 11:26:58 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 2/2] arm: dts: add ARM Mali GPU node for Odroid XU3 To: Joseph Kogut X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190618_022712_211098_2639D476 X-CRM114-Status: GOOD ( 14.38 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, "linux-samsung-soc@vger.kernel.org" , airlied@linux.ie, dri-devel@lists.freedesktop.org, robh+dt@kernel.org, kgene@kernel.org, daniel@ffwll.ch, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, 15 Jun 2019 at 01:57, Joseph Kogut wrote: > > Add device tree node for mali gpu on Odroid XU3 SoCs. > > Signed-off-by: Joseph Kogut > --- > > Changes v1 -> v2: > - Use interrupt name ordering from binding doc > - Specify a single clock for GPU node > - Add gpu opp table > - Fix warnings from IRQ_TYPE_NONE > > .../boot/dts/exynos5422-odroidxu3-common.dtsi | 26 +++++++++++++++++++ > 1 file changed, 26 insertions(+) > > diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi b/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi > index 93a48f2dda49..b8a4246e3b37 100644 > --- a/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi > +++ b/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi > @@ -48,6 +48,32 @@ > cooling-levels = <0 130 170 230>; > }; > > + gpu: gpu@11800000 { > + compatible = "samsung,exynos-mali", "arm,mali-t628"; > + reg = <0x11800000 0x5000>; > + interrupts = , > + , > + ; > + interrupt-names = "job", "mmu", "gpu"; > + clocks = <&clock CLK_G3D>; > + mali-supply = <&buck4_reg>; > + operating-points-v2 = <&gpu_opp_table>; > + }; > + > + gpu_opp_table: gpu-opp-table { One more thing - use "opp_table" as node name (generic class of node, matches style with other tables). Best regards, Krzysztof > + compatible = "operating-points-v2"; > + > + opp-177000000 { > + opp-hz = /bits/ 64 <117000000>; > + opp-microvolt = <812500>; > + }; > + > + opp-600000000 { > + opp-hz = /bits/ 64 <600000000>; > + opp-microvolt = <1150000>; > + }; > + }; > + > thermal-zones { > cpu0_thermal: cpu0-thermal { > thermal-sensors = <&tmu_cpu0 0>; > -- > 2.22.0 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel