From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11AB7C0650F for ; Thu, 8 Aug 2019 13:15:14 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D87DB2184E for ; Thu, 8 Aug 2019 13:15:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="U61yrbM+"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="r8LLjQSF" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D87DB2184E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=403ei/bXwax61dHvnqPewMgNVrnMMvNRxK76OXla5Xg=; b=U61yrbM+A1Ang0 1OR+1zB5C8RW7sp7DOF6aCEOdyEQusWtJmKTp2t94cp7b64qzq4gtUsKGz/pD+f1q6JUeADExePX9 htW09fy+l5Xn74NPlgvg7gIWDLYNaKjFJ3ib81v3Uw51E6QULY1pB4ATS+PATL2DaZFJLoM+d1yWv ZhkHf/tU9NUuNNEUHXuCbuC3i11pCeDbkRGLnLAKV4dFplmKWHUkviEdph3lHD2CxRtA5UHMLAkAy QoZ/iHce3ocZEAW+E86LQqIVXe8S5ht6VgleYOwFWTBHIkfrrkXXzmeQWuZu6TwcLxoh+4cyfC0CY 9N7VPoYCTQ4cL87ysO+A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hviG8-0004RS-S3; Thu, 08 Aug 2019 13:15:12 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hviG5-0004R1-7n for linux-arm-kernel@lists.infradead.org; Thu, 08 Aug 2019 13:15:10 +0000 Received: from mail-lj1-f171.google.com (mail-lj1-f171.google.com [209.85.208.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 31D5521883 for ; Thu, 8 Aug 2019 13:15:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1565270108; bh=5yPzM5yGGSNATY9kmjyrKwemZkcgY7dISuXee3TjHbA=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=r8LLjQSFOD5ZA2mugoq5PfbhvrYb2QgV1WP0LufxAR2YpULVjpPB2DqsCJ99YgWf3 ybC/lYyEiNBMdDlf4f24jeP2nXzUoU26pgn6E0S9/W+NjWNk0YpL1aSWS6bCRgtYxg 3y+rWBmCPDgsAGJrTYBT8OmYFX4iQf7MlbbLmBFE= Received: by mail-lj1-f171.google.com with SMTP id y17so64300158ljk.10 for ; Thu, 08 Aug 2019 06:15:08 -0700 (PDT) X-Gm-Message-State: APjAAAUFVw1pwNI3XDo7P3TQBub4hfu5jzqgSvCwlSPa31BNNnAhi1JO lOLFvrkfW8YElUvKzYrsaBtAeEvcvQLrTgP3Ask= X-Google-Smtp-Source: APXvYqzWTwcs6TPkPrDTz+qUFZmx5IMdHV6tLMEdfb5Dbo2QpS6RlvnpGcLKMZOf3TR4vCBEsNVuYYrMDmmz/hVY2Qw= X-Received: by 2002:a2e:3008:: with SMTP id w8mr8417296ljw.13.1565270106316; Thu, 08 Aug 2019 06:15:06 -0700 (PDT) MIME-Version: 1.0 References: <20190718143044.25066-1-s.nawrocki@samsung.com> <20190718143044.25066-4-s.nawrocki@samsung.com> <669c6b25-eb7e-ed3a-72a2-ee155a568363@arm.com> In-Reply-To: <669c6b25-eb7e-ed3a-72a2-ee155a568363@arm.com> From: Krzysztof Kozlowski Date: Thu, 8 Aug 2019 15:14:54 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 3/9] soc: samsung: Add Exynos Adaptive Supply Voltage driver To: Robin Murphy X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190808_061509_322026_5005EBA0 X-CRM114-Status: GOOD ( 18.60 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, "linux-samsung-soc@vger.kernel.org" , =?UTF-8?B?QmFydMWCb21pZWogxbtvxYJuaWVya2lld2ljeg==?= , pankaj.dubey@samsung.com, linux-pm@vger.kernel.org, "linux-kernel@vger.kernel.org" , robh+dt@kernel.org, kgene@kernel.org, Sylwester Nawrocki , vireshk@kernel.org, linux-arm-kernel@lists.infradead.org, Marek Szyprowski Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 8 Aug 2019 at 14:48, Robin Murphy wrote: > > On 08/08/2019 13:31, Krzysztof Kozlowski wrote: > > On Thu, 8 Aug 2019 at 14:07, Sylwester Nawrocki wrote: > >>>> +static unsigned int exynos5422_asv_parse_table(struct exynos_asv *asv, > >>>> + unsigned int pkg_id) > >>>> +{ > >>>> + return (pkg_id >> EXYNOS5422_TABLE_OFFSET) & EXYNOS5422_TABLE_MASK; > >>>> +} > >>>> + > >>>> +static bool exynos5422_asv_parse_bin2(struct exynos_asv *asv, > >>>> + unsigned int pkg_id) > >>>> +{ > >>>> + return (pkg_id >> EXYNOS5422_BIN2_OFFSET) & EXYNOS5422_BIN2_MASK; > >>> > >>> return !!() for converting to boolean. > >> > >> I'm not convinced it is needed, the return type of the function is bool > >> and value of the expression will be implicitly converted to that type. > >> Is there any compiler warning related to that? > > > > Yeah, but bool is int so there will be no implicit conversion... I > > guess it is a convention. In theory !! is the proper conversion to > > bool but if bool==int then it's essentially conversion to 1. I am not > > sure what's the benefit, maybe for some wrong code which would do > > comparisons on result like if (exynos5422_asv_parse_bin2() == TRUE)... > > Not so - since we use "-std=gnu89", we have C99-like _Bool, which our > bool is a typedef of. Conversions, either implicit or explicit, are > well-defined: > > "6.3.1.2 Boolean type > > When any scalar value is converted to _Bool, the result is 0 if the > value compares equal > to 0; otherwise, the result is 1." > > This is even called out in Documentation/process/coding-style.rst: > > "When using bool types the !! construction is not needed, which > eliminates a class of bugs." Good point, thanks! Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel