From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E8E0C3A5A2 for ; Tue, 3 Sep 2019 07:58:46 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4461D21881 for ; Tue, 3 Sep 2019 07:58:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="FjXzGXzf"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="am7+Xbi2" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4461D21881 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=uf53d7xBMTNX1jie7hI0y9pRTftawAMh7SW/YiHTJWg=; b=FjXzGXzfmJx92/ z/2hPu4tSRTQzc2FO0M8GxhRDR87bSmmTxBjSsHpySWyDK9tDzmxKqMHtsf/dxx4e/3A32GmHiUel WqtzwnHlmcxErIVgQ922t4otF16vBOnqIZYJlubhCSIAV95jvx14kgUv76X8Y5cojdH5LiUrXLckV NWPkrFuSVfOajXHP52E/vV94Bh5h0MSZ89/97PmfUHV05jI1BqRSwuDvYJ1RghXj++NAD+swu0vPq 8cheRf84CqUtdJzifc+mW3PD4eUBTfaXfOFvlFozfdu/eKFJtqV6N1XWUQXp9pj8vmqnsuJVBJthx LbI8y7lK7E5Mf5UUnzpA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1i53i4-0001Eq-HG; Tue, 03 Sep 2019 07:58:40 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1i53hz-0001EK-Ro for linux-arm-kernel@lists.infradead.org; Tue, 03 Sep 2019 07:58:38 +0000 Received: from mail-lf1-f52.google.com (mail-lf1-f52.google.com [209.85.167.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 145B523717 for ; Tue, 3 Sep 2019 07:58:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1567497515; bh=UXh12NkSwZ12hWkXETNI+YE3LiuTShuDOHt89Jbh128=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=am7+Xbi2YfzdQSUw6p4YYdjuXFciTPcfw96UlPxdv1inY3pLUnYIUWWTTdp7gOu6j mbOKZWr7h3x4jVZ7l5VuM603tR4gC52GePWzV1gNGQzP/qU2s4yOLmczxTPXfsHYeP bsIivXjLkyEM2heVUy+enefLtMFc34vgtmnSlwbY= Received: by mail-lf1-f52.google.com with SMTP id y4so5194386lfe.11 for ; Tue, 03 Sep 2019 00:58:34 -0700 (PDT) X-Gm-Message-State: APjAAAX71JKAa+0Ai5FZUVmbNZLRrKOKYnGuS8WTFrKinyM/DO0MHnED 5UouaoAh7jn/Kkn1qN7giv3x2CvNGk31IQb0ifE= X-Google-Smtp-Source: APXvYqzrJeKyNEvczFZsfe2tgLAYBl9BS475I7A9xOTHksgZrFCcJ43dEFvCe2Ya4ROGp9gR8nfJe7d+AYReOk1iVIQ= X-Received: by 2002:a19:c649:: with SMTP id w70mr20083717lff.33.1567497513112; Tue, 03 Sep 2019 00:58:33 -0700 (PDT) MIME-Version: 1.0 References: <20190823145356.6341-1-krzk@kernel.org> <20190823145356.6341-5-krzk@kernel.org> In-Reply-To: From: Krzysztof Kozlowski Date: Tue, 3 Sep 2019 09:58:21 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [RFC 5/9] dt-bindings: arm: samsung: Convert Exynos PMU bindings to json-schema To: Rob Herring X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190903_005835_942244_59DA13D8 X-CRM114-Status: GOOD ( 22.54 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Alessandro Zummo , Alexandre Belloni , Lars-Peter Clausen , Arnd Bergmann , devicetree@vger.kernel.org, "open list:IIO SUBSYSTEM AND DRIVERS" , Marek Szyprowski , "linux-kernel@vger.kernel.org" , Tomasz Figa , linux-samsung-soc , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , Peter Meerwald-Stadler , Hartmut Knaack , Olof Johansson , "open list:REAL TIME CLOCK \(RTC\) SUBSYSTEM" , notify@kernel.org, Jonathan Cameron , =?UTF-8?Q?Pawe=C5=82_Chmiel?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, 26 Aug 2019 at 13:54, Rob Herring wrote: > > On Fri, Aug 23, 2019 at 9:54 AM Krzysztof Kozlowski wrote: > > > > Convert Samsung Exynos Power Management Unit (PMU) bindings to DT schema > > format using json-schema. > > > > Signed-off-by: Krzysztof Kozlowski > > --- > > .../devicetree/bindings/arm/samsung/pmu.txt | 72 -------------- > > .../devicetree/bindings/arm/samsung/pmu.yaml | 93 +++++++++++++++++++ > > 2 files changed, 93 insertions(+), 72 deletions(-) > > delete mode 100644 Documentation/devicetree/bindings/arm/samsung/pmu.txt > > create mode 100644 Documentation/devicetree/bindings/arm/samsung/pmu.yaml > > > > diff --git a/Documentation/devicetree/bindings/arm/samsung/pmu.yaml b/Documentation/devicetree/bindings/arm/samsung/pmu.yaml > > new file mode 100644 > > index 000000000000..818c6f3488ef > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/arm/samsung/pmu.yaml > > @@ -0,0 +1,93 @@ > > +# SPDX-License-Identifier: GPL-2.0 > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/arm/samsung/pmu.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Samsung Exynos SoC series Power Management Unit (PMU) > > + > > +maintainers: > > + - Krzysztof Kozlowski > > + > > +properties: > > + compatible: > > + items: > > + - enum: > > + - samsung,exynos3250-pmu > > + - samsung,exynos4210-pmu > > + - samsung,exynos4412-pmu > > + - samsung,exynos5250-pmu > > + - samsung,exynos5260-pmu > > + - samsung,exynos5410-pmu > > + - samsung,exynos5420-pmu > > + - samsung,exynos5433-pmu > > + - samsung,exynos7-pmu > > + - const: syscon > > + > > + reg: > > + maxItems: 1 > > + > > + '#clock-cells': > > + const: 1 > > + > > + clock-names: > > + description: > > + list of clock names for particular CLKOUT mux inputs > > + # TODO: what is the maximum number of elements (mux inputs)? > > + minItems: 1 > > + maxItems: 32 > > + items: > > + - enum: > > This isn't correct as you are only defining possible names for the > first item. Drop the '-' (making items a schema instead of a list) and > then it applies to all. However, doing that will cause a meta-schema > error which I need to fix to allow. Or if there's a small set of > possibilities of number of inputs, you can list them under a 'oneOf' > list. Mhmm, I cannot test it or I have an error in the schema. if I understand correctly, this would be: clock-names: description: List of clock names for particular CLKOUT mux inputs minItems: 1 maxItems: 16 items: clkout0 clkout1 clkout2 clkout3 clkout4 clkout5 clkout6 clkout7 clkout8 clkout9 clkout10 clkout11 clkout12 clkout13 clkout14 clkout15 clkout16 Now it produces the error "ignoring, error in schema 'items'" but maybe it is expected with current meta-schema? Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel