From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7FC22C5ACAE for ; Thu, 12 Sep 2019 09:36:11 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 54C97208C2 for ; Thu, 12 Sep 2019 09:36:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="YMGHsIrJ"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="o1xGloPC" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 54C97208C2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=L4Nu6FqxBhC3e4IMNMlAFSQNwdfqHeefq+XqtR6f1HY=; b=YMGHsIrJpPHIN+ ygPmJ4tV1+o/A5q4uxxzmqs08uBXPZrzqDOvBzY9DhHNmFO4SlQGLihfbY3g7M+fYrfXsr2qu2Va5 jFGHBtYAVwMxGuYhTnOsfp+a/PPO29RnyCPvZl/G+xFaWli2t0x/qyP7f8mhGzPGElXAOE6Za4cvW 3ZZmJKQAzNoXxVcNkle4E3TZlA7j4kQ/i4PEG99rQ3CykSsPMFfQkKVcuT8bDDSmF572QIgQJCYCn MOGUso5hCK1D8qu8TNputnD8fJ0ECMWaIkApFDFaZxozOv1HzTTrDflv6il1xRfXJPCvnoolNWj7s OBpwXA79nTL/cHLbfpEg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.2 #3 (Red Hat Linux)) id 1i8LWM-0000pH-VJ; Thu, 12 Sep 2019 09:36:10 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.2 #3 (Red Hat Linux)) id 1i8LWJ-0000oW-Sa for linux-arm-kernel@lists.infradead.org; Thu, 12 Sep 2019 09:36:09 +0000 Received: from mail-lf1-f41.google.com (mail-lf1-f41.google.com [209.85.167.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id EE52B20856 for ; Thu, 12 Sep 2019 09:36:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1568280965; bh=o907g5ReEliliHp1jD4CGBcMPQ67MvCxuOBHbk2SLo8=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=o1xGloPCicmW15KwhTZntnYk9UgcnskLW5PH/c/xxbRhKaLacFzc8CvB2J+0DQrRc DmH0vr4s84gZGWW7v/kFNjEwG6hvRU2NYJ+PK/IKjPrj+w8caQZ0FzqV6Y9hU3WSXS YX4shUuhOadTXh3H+dc6BQoY5GIQkNJIEmZn7Wi8= Received: by mail-lf1-f41.google.com with SMTP id q11so3833886lfc.11 for ; Thu, 12 Sep 2019 02:36:04 -0700 (PDT) X-Gm-Message-State: APjAAAV4pzaVugJpUDh6ZzGqX1l/1G3CmHsmKxDQ4HNZR88PbI4QtU7h 1cveCAJWF9nPP/N1cAbqIDYDItg0LIkk7LQU27w= X-Google-Smtp-Source: APXvYqzNtU0oOWZlIguKWNCiRl9oM+J21geYpRmVzSkBE7O4GULM3ap8wAEl5NWM9fgFCw9iRpQV6IrRFR1+xbj1uWc= X-Received: by 2002:ac2:43b8:: with SMTP id t24mr8235535lfl.24.1568280963225; Thu, 12 Sep 2019 02:36:03 -0700 (PDT) MIME-Version: 1.0 References: <20190911183632.4317-1-krzk@kernel.org> In-Reply-To: From: Krzysztof Kozlowski Date: Thu, 12 Sep 2019 11:35:52 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [GIT PULL 1/2] arm64: dts: exynos: Pull for v5.4 To: Arnd Bergmann , Marek Szyprowski X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190912_023607_967828_5508738F X-CRM114-Status: GOOD ( 22.24 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: DTML , "moderated list:ARM/SAMSUNG EXYNOS ARM ARCHITECTURES" , "linux-kernel@vger.kernel.org" , SoC Team , arm-soc , Kukjin Kim , Olof Johansson , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 12 Sep 2019 at 08:32, Krzysztof Kozlowski wrote: > > On Wed, 11 Sep 2019 at 23:07, Arnd Bergmann wrote: > > > > On Wed, Sep 11, 2019 at 8:36 PM Krzysztof Kozlowski wrote: > > > > > > Hi, > > > > > > Unfortunately the patches were applied right after closing the linux-next. > > > > Hi Krzysztof, > > > > I took a look at these and am not convinced this is right: > > > > > 1. Fix boot of Exynos7 due to wrong address/size of memory node, > > > > The current state is clearly broken and a fix is needed, but > > I'm not sure this is the right fix. Why do you have 32-bit physical > > addressing on a 64-bit chip? I looked at commit ef72171b3621 > > that introduced it, and it seems it would be better to just > > revert back to 64-bit addresses. > > We discussed with Marek Szyprowski that either we can go back to > 64-bit addressing or stick to 32. There are not known boards with more > than 4 GB of RAM so from this point of view the choice was irrelevant. > At the end of discussion I mentioned to stick with other arm64 boards > (although not all), so revert to have 64 bit address... but Marek > chosen differently. Since you ask, let's go back with revert. > > > > > > 2. Move GPU under /soc node, > > > > No problem > > > > > 3. Minor cleanup of #address-cells. > > > > IIRC, an interrupt-controller is required to have a #address-cells > > property, even if that is normally zero. I don't remember the > > details, but the gic binding lists it as mandatory, and I think > > the PCI interrupt-map relies on it. I would just drop this patch. > > Indeed, binding requires both address and size cells. I'll drop it. Short update: no, address-cells are not required by bindings. They are optional. In case of lack of them, the parent address-cells will be used so effectively this patch was changing it from 0 to 1. Anyway this was not expressed in commit msg so I'll drop it. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel