From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A2CCC433DF for ; Mon, 19 Oct 2020 17:07:38 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2D426206E9 for ; Mon, 19 Oct 2020 17:07:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="AYRPZPyw"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="v7lhCyYx" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2D426206E9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=kv+ubzv9dye2y2A6VAoqw46jvxE0Qpp0XIVYtNqiJ1s=; b=AYRPZPyw7ledgOu14lic9qmZU fisAwK4OxYZgLP0Vwm0DzdfhuKPo4iN0gLxI9OOx76PeAE8S83hpDKhtIBTi+WWvHV6996+Wpb49V 9Erg48CHLxOhF32P7dRNf2DrED9ndYYwsOg6DIT4c+ZophmjcnogKLWjBykFqxOFM0Ta7EwxspMf1 /JisA4WlpStM3UkztC7cAj3At/njvc3bPXyBweoVmLOfGNKncN0mM2XCYAr3Z9VbPHz/hShpBCVWP lQqmrSvaPDk16HNSu9pdzYVj0ppBvXH+Dzlq1ipP4tegaXET43KI7IG7tdw0RO/jZoeZZRDLhuO1U w7V75wBwQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kUYc0-0007nW-Fx; Mon, 19 Oct 2020 17:06:20 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kUYby-0007mq-2p for linux-arm-kernel@lists.infradead.org; Mon, 19 Oct 2020 17:06:18 +0000 Received: from mail-ed1-f46.google.com (mail-ed1-f46.google.com [209.85.208.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id DA45A222EC for ; Mon, 19 Oct 2020 17:06:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603127177; bh=0O1fhJYNZelW5IlOs5LX842TXGsnkAfhUi+vSpLlLEU=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=v7lhCyYxO2IAejY4XtXtiwc4whRS6uQV1lYeCuroS/EEctzWODXNTnUTtNguaI+mz JbWhhXSNrFIo3ymIIop1a8UYKkIN80pu/AbUgoDfn0TrQEwAgJiZiMmZOVFv5uZV1e 3ecpgzkwkTa637cz4jGMWy+t9u9rBLM8U1xfHTkk= Received: by mail-ed1-f46.google.com with SMTP id t20so32613edr.11 for ; Mon, 19 Oct 2020 10:06:16 -0700 (PDT) X-Gm-Message-State: AOAM532GR/O4rtgO0EXld+EKWBjS9KXGUhGlA9Eyw4MgclnlQ4Bsoou3 sgj8jdXzNhvdWPB/BrXuoxvQanC5MzGT16wPAoM= X-Google-Smtp-Source: ABdhPJyxGPC/GKoJUw/Nkd9Pik+1J1JxIOUpJXCguSpUW1ESiyaEuX3B+znG3C6aqVitqC96v1zxV6VeCvuS9nQxPp8= X-Received: by 2002:aa7:cf17:: with SMTP id a23mr796273edy.298.1603127175197; Mon, 19 Oct 2020 10:06:15 -0700 (PDT) MIME-Version: 1.0 References: <20201008212706.870115-1-aford173@gmail.com> <20201008212706.870115-2-aford173@gmail.com> <20201012170016.GA5369@kozik-lap> In-Reply-To: From: Krzysztof Kozlowski Date: Mon, 19 Oct 2020 19:06:03 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 2/3] arm64: dts: imx8mm: Add node for SPDIF To: Fabio Estevam X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201019_130618_219756_578FE49E X-CRM114-Status: GOOD ( 22.53 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Will Deacon , Adam Ford , Sascha Hauer , Adam Ford-BE , linux-kernel , Rob Herring , NXP Linux Team , Pengutronix Kernel Team , Catalin Marinas , Shawn Guo , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, 19 Oct 2020 at 18:56, Fabio Estevam wrote: > > Hi Krzysztof, > > On Mon, Oct 12, 2020 at 2:00 PM Krzysztof Kozlowski wrote: > > > > + spdif1: spdif@30090000 { > > > + compatible = "fsl,imx8mm-spdif", "fsl,imx35-spdif"; > > > > This does not pass the dtschema validation, so only "fsl,imx35-spdif". > > Shouldn't the dt schema validation be changed then to accept this format? Depends. If a given compatible is in the schema, then the answer is: rather not. The DTS conform to schema, not the otherwise. When dtschema is sent this is the ABI to which the kernel should conform. User-space or other SW (e.g. U-Boot) could depend on it. Of course there are exceptions... If the compatible is not in the schema, then of course it could be added if there is a need. In this case, device is simply compatible with "fsl,imx35-spdif" so there is no real need to change the schema. Just use the existing compatible. Look at one funny example in iMX: drivers/pwm/pwm-imx27.c. Someone created multiple compatibles but does not use them at all, because the hardware looks exactly the same. Therefore driver implements only one compatible because entire HW is compatible with fsl,imx27-pwm. In such clear case, why adding many compatibles? It's just a churn. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel