From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0DD5C43461 for ; Wed, 16 Sep 2020 06:05:46 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 57BB920715 for ; Wed, 16 Sep 2020 06:05:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="SDEB8SeW"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="xu9fAoLM" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 57BB920715 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=I/BJ7OBazNRUvtskImWW9I12thJFrYq+/qieF10ZH6A=; b=SDEB8SeWnakLbhVxh7KRq4YU6 7Uhlr16dVocZhPxpF5rc3rMguto4MCiGvQnL+GoHSE0wm2xlpKFLfuI+Jo39QVN/8GCIuHB+qzh73 FWdw5lP4QWGcSpACLBPZsPtegwpCjJTj9g01PPRdvYx8rgY/Rv48kglwrYgrAmgDbi66tK2gLPoH1 VMrREJwhmEkFiXZRLZz3S+Zv0ZY2cI1XeSaWVFclr1JxU3HCo90tfk80Z9LgEnHB/u9EkV8KQMDhn riK0DJHeG98jCZjpEe7DOqCRGCPjJFcY59BMHNv76Fhs1c8BsCw3lSjZwvWQIvEREztplNDp9qXXx cOCLkV2oA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kIQY3-0003Mh-LN; Wed, 16 Sep 2020 06:04:07 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kIQY0-0003MC-JG for linux-arm-kernel@lists.infradead.org; Wed, 16 Sep 2020 06:04:05 +0000 Received: from mail-ed1-f45.google.com (mail-ed1-f45.google.com [209.85.208.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1DE642220A for ; Wed, 16 Sep 2020 06:04:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600236243; bh=MGLUFXU7bgEiOq2QwCLtokuXU6KQpofMXm9tQrG1+AA=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=xu9fAoLMxR+Sbne3nolGsptpoYBDPw5I5CfHKOMDdMWT0Fz/JyJVq6/ylx7FJzdOf x4/Kf10phhEzTQnup4DRMwW21ZWts2uITWbwa7Gj4pcZZB3kCEofefRTFqVTvzCZgB L02kMFOYEVDi3qDPM8ksi9I9Ys65VVf7t7YZO/r4= Received: by mail-ed1-f45.google.com with SMTP id a12so4985124eds.13 for ; Tue, 15 Sep 2020 23:04:03 -0700 (PDT) X-Gm-Message-State: AOAM533Tews6vn3zauDoX8KJM8y5gVh1QWmVBYCETZ34nS+vhhNT+Knf 07BlfzhILXbi/wI75PD5V5yYsKAFr7x/SQZ/cgY= X-Google-Smtp-Source: ABdhPJzf7bf8D+dhy3zqQalV6k7pR+DsnqPe6uDFJBoNyVs7vkIF4YE5WM1N/PIcrsuSHlEipJiegQiLr568kZELN94= X-Received: by 2002:a05:6402:ca7:: with SMTP id cn7mr25423402edb.143.1600236241549; Tue, 15 Sep 2020 23:04:01 -0700 (PDT) MIME-Version: 1.0 References: <1600054147-29997-1-git-send-email-Anson.Huang@nxp.com> <1600054147-29997-2-git-send-email-Anson.Huang@nxp.com> In-Reply-To: From: Krzysztof Kozlowski Date: Wed, 16 Sep 2020 08:03:49 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH V2 RESEND 2/4] arm64: defconfig: Build in CONFIG_GPIO_MXC by default To: Anson Huang X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200916_020404_783846_40C81DCD X-CRM114-Status: GOOD ( 19.66 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peng Fan , "geert+renesas@glider.be" , "catalin.marinas@arm.com" , "linus.walleij@linaro.org" , "bjorn.andersson@linaro.org" , "oleksandr.suvorov@toradex.com" , "michael@walle.cc" , "will@kernel.org" , "hverkuil-cisco@xs4all.nl" , "linux@armlinux.org.uk" , "bgolaszewski@baylibre.com" , "andreas@kemnade.info" , "joel@jms.id.au" , dl-linux-imx , "s.hauer@pengutronix.de" , "prabhakar.mahadev-lad.rj@bp.renesas.com" , "lkundrak@v3.sk" , "festevam@gmail.com" , "linux-arm-kernel@lists.infradead.org" , Aisheng Dong , "linux-gpio@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Leo Li , "vkoul@kernel.org" , "kernel@pengutronix.de" , "olof@lixom.net" , "shawnguo@kernel.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 16 Sep 2020 at 03:59, Anson Huang wrote: > > Hi, Krzysztof > > > Subject: Re: [PATCH V2 RESEND 2/4] arm64: defconfig: Build in > > CONFIG_GPIO_MXC by default > > > > On Mon, 14 Sep 2020 at 05:36, Anson Huang > > wrote: > > > > > > i.MX GPIO is NOT default enabled now, so select CONFIG_GPIO_MXC as > > > built-in manually. > > > > Maybe it should stay not enabled? Please explain in commit msg why it should > > be enabled. > > The CONFIG_GPIO_MXC is necessary for all the i.MX SoCs, as it provides the basic > function of GPIO pin operations and IRQ operations, it is enabled by default previously > with " def_bool y " in Kconfig, now it is changed to tristate, so it should be explicitly > enabled in defconfig to make sure it does NOT break any existing functions, that is > why I list " i.MX GPIO is NOT default enabled now, so select CONFIG_GPIO_MXC as > built-in manually " in commit msg, it aims to NOT change any previous behaviors. Sure, I was just saying that all this should be in commit msg. The commit should explain why it is there in the Linux kernel. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel