From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5923C433E7 for ; Wed, 14 Oct 2020 10:35:21 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 32FE620878 for ; Wed, 14 Oct 2020 10:35:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="xemnQ2RY"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="sBHnz1yy" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 32FE620878 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=j60KXWxo4YOp0fja5werTiopm7Z9akcRv0iMt7NV4YY=; b=xemnQ2RYHrJzFnGKnRLxEUOSA XzLADXQS7L5N+xAKWzq6aZppp6Qsx6WPHh7g3pW5QtHvObciQqHnSaPrGOHMINJIcPRQv3e8+hhAb /Jg2VDHb4WkNNg0dIIqalhcI/WiT9PLl1YTSSDlj9WbtsSkbR/8fodGo/5S/IpGR4BDKqSe2pIRAJ Q0XQJsJavZyeiKKpqM31D6G3pusvMtaJoX/ozMVTWS/L2A2tejNxnbKAp6SGBTbNJ3jId/0NBhNjg t1qxGSpa6iFyEqlx1DJuVs5PxJcisJQMfFL0r0wg25N+rr0hxiWPXfcb8yCZYE1n3hFW300Z5DlK4 IfT6LTX6Q==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kSe6J-0000wC-Ap; Wed, 14 Oct 2020 10:33:43 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kSe6G-0000vi-Pf; Wed, 14 Oct 2020 10:33:41 +0000 Received: from mail-ej1-f50.google.com (mail-ej1-f50.google.com [209.85.218.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 14AC42222C; Wed, 14 Oct 2020 10:33:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1602671619; bh=YTNSXcW0k5VpGDP+ALIpIyuW3iLRTmD54rqCQ1oyiyA=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=sBHnz1yyxbvpzxpccOns8mp5Of03gj29/RNRo3g82Ev+clfKBrk3KB5XrR8yt+GLl pmdEOB8h3WOAsY4KGNHM6cEFI07KwBf89dw+Gj6iqzCXZZziXMohhgdikBTZ5zGwnn ltFgloehCf+cN94VB8NVLy20CDewVMaT7n7srMMg= Received: by mail-ej1-f50.google.com with SMTP id t25so4040891ejd.13; Wed, 14 Oct 2020 03:33:38 -0700 (PDT) X-Gm-Message-State: AOAM532OBGie2VsXcPdUPt9zdP7CSxCXkBhneTxxndcmTci/Y2D2YPb9 8iarVzTTw0gIoRHILaA0leR8UhTJ4rJ5LDRfwf4= X-Google-Smtp-Source: ABdhPJxZBjfPkS/DAl69mvwOwG4fxUYT0dQEW6rrgGKRXDR2yPgf5o4BRFNdNiVveb84vPHaKXSGoZA2E31iHMoZKKE= X-Received: by 2002:a17:906:1a11:: with SMTP id i17mr4430823ejf.381.1602671617348; Wed, 14 Oct 2020 03:33:37 -0700 (PDT) MIME-Version: 1.0 References: <20201014101402.18271-1-Sergey.Semin@baikalelectronics.ru> <20201014101402.18271-21-Sergey.Semin@baikalelectronics.ru> In-Reply-To: <20201014101402.18271-21-Sergey.Semin@baikalelectronics.ru> From: Krzysztof Kozlowski Date: Wed, 14 Oct 2020 12:33:25 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 20/20] arch: dts: Fix DWC USB3 DT nodes name To: Serge Semin X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201014_063341_085695_33D03065 X-CRM114-Status: GOOD ( 19.59 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew Lunn , linux-usb@vger.kernel.org, Neil Armstrong , Tony Lindgren , Bjorn Andersson , Pavel Parkhomenko , "linux-samsung-soc@vger.kernel.org" , Kevin Hilman , Gregory Clement , Wei Xu , Chen-Yu Tsai , Kukjin Kim , Andy Gross , linux-arm-msm@vger.kernel.org, linux-snps-arc@lists.infradead.org, Sebastian Hesselbarth , devicetree@vger.kernel.org, Jason Cooper , Mathias Nyman , "linux-kernel@vger.kernel.org" , Lad Prabhakar , Maxime Ripard , Alexey Malahov , Rob Herring , Santosh Shilimkar , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Roger Quadros , Felipe Balbi , linux-mips@vger.kernel.org, Greg Kroah-Hartman , Yoshihiro Shimoda , linuxppc-dev@lists.ozlabs.org, Patrice Chotard , Serge Semin , Li Yang , Manu Gautam , =?UTF-8?Q?Beno=C3=AEt_Cousson?= , Shawn Guo Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 14 Oct 2020 at 12:23, Serge Semin wrote: > > In accordance with the DWC USB3 bindings the corresponding node name is > suppose to comply with Generic USB HCD DT schema, which requires the USB > nodes to have the name acceptable by the regexp: "^usb(@.*)?" . But a lot > of the DWC USB3-compatible nodes defined in the ARM/ARM64 DTS files have > name as "^dwc3@.*" or "^usb[1-3]@.*" or even "^dwusb@.*", which will cause > the dtbs_check procedure failure. Let's fix the nodes naming to be > compatible with the DWC USB3 DT schema to make dtbs_check happy. > > Note we don't change the DWC USB3-compatible nodes names of > arch/arm64/boot/dts/apm/{apm-storm.dtsi,apm-shadowcat.dtsi} since the > in-source comment says that the nodes name need to be preserved as > "^dwusb@.*" for some backward compatibility. > > Signed-off-by: Serge Semin > > --- > > Please, test the patch out to make sure it doesn't brake the dependent DTS > files. I did only a manual grepping of the possible nodes dependencies. 1. It is you who should compare the decompiled DTS, not us. For example: $ for i in dts-old/*/*dtb dts-old/*/*/*dtb; do echo $i; crosc64 scripts/dtc/dtx_diff ${i} dts-new/${i#dts-old/} ; done $ for i in dts-old/*/*dtb dts-old/*/*/*dtb; do echo $i; crosc64 fdtdump ${i} > ${i}.fdt ; crosc64 fdtdump dts-new/${i#dts-old/} > dts-new/${i#dts-old/}.fdt ; diff -ubB ${i}.fdt dts-new/${i#dts-old/}.fdt ; done 2. Split it per arm architectures (and proper subject prefix - not "arch") and subarchitectures so maintainers can pick it up. 3. The subject title could be more accurate - there is no fix here because there was no errors in the first place. Requirement of DWC node names comes recently, so it is more alignment with dtschema. Otherwise automatic-pickup-stable-bot might want to pick up... and it should not go to stable. Best regards, Krzysztof > arch/arm/boot/dts/armada-375.dtsi | 2 +- > arch/arm/boot/dts/exynos5250.dtsi | 2 +- > arch/arm/boot/dts/exynos54xx.dtsi | 4 ++-- > arch/arm/boot/dts/keystone-k2e.dtsi | 4 ++-- > arch/arm/boot/dts/keystone.dtsi | 2 +- > arch/arm/boot/dts/ls1021a.dtsi | 2 +- > arch/arm/boot/dts/omap5-l4.dtsi | 2 +- > arch/arm/boot/dts/stih407-family.dtsi | 2 +- > arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi | 2 +- > arch/arm64/boot/dts/exynos/exynos5433.dtsi | 4 ++-- > arch/arm64/boot/dts/exynos/exynos7.dtsi | 2 +- > arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi | 4 ++-- > arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi | 6 +++--- > arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi | 4 ++-- > arch/arm64/boot/dts/freescale/fsl-ls208xa.dtsi | 4 ++-- > arch/arm64/boot/dts/hisilicon/hi3660.dtsi | 2 +- > arch/arm64/boot/dts/qcom/apq8096-db820c.dtsi | 4 ++-- > arch/arm64/boot/dts/qcom/ipq8074.dtsi | 4 ++-- > arch/arm64/boot/dts/qcom/msm8996.dtsi | 4 ++-- > arch/arm64/boot/dts/qcom/msm8998.dtsi | 2 +- > arch/arm64/boot/dts/qcom/qcs404-evb.dtsi | 2 +- > arch/arm64/boot/dts/qcom/qcs404.dtsi | 4 ++-- > arch/arm64/boot/dts/qcom/sc7180.dtsi | 2 +- > arch/arm64/boot/dts/qcom/sdm845.dtsi | 4 ++-- > arch/arm64/boot/dts/qcom/sm8150.dtsi | 2 +- > 25 files changed, 38 insertions(+), 38 deletions(-) > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel