From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9ED44C43613 for ; Mon, 24 Jun 2019 07:42:27 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 714C42089F for ; Mon, 24 Jun 2019 07:42:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="V3sjjXUC"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="2qjE1E6+" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 714C42089F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=H1jHGgGOC5m9PrSJKgvYmlgf2YIly8wnl9gl7f5dljQ=; b=V3sjjXUCvcMtFy X2ACzT2EcwEno3UmyZ5Vouio34iAvklKCmq5SbD33kzRXz8SlwwUMilCfW4W5+2cpx0coNWxp+cXq vfnGrP9V/36LZF/+uCD1vRImPMJVfabZn3FoFMV6aCx1dXU2zJZ40Vj0RGxYNKx0aagxUYuqXNRxT q1FeX7Wt8q/ptQLsI8ovWd97syphre9/TgolvW8me0veKKaUWNrP/UWa15m2blSvnWxHW7vmv4QTY DmcRUS7ntOmrkZNwkqEOp9D2vB/a+lRrFHJW5XMT3Qg6if6mokLsHGL/3tnHts+p82dLVf2Ln1279 sqNcMBWtgiJ0lm6TMOKw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hfJcK-0002Xs-Qd; Mon, 24 Jun 2019 07:42:21 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hfJbi-0002AV-OY for linux-arm-kernel@lists.infradead.org; Mon, 24 Jun 2019 07:41:45 +0000 Received: from mail-lj1-f178.google.com (mail-lj1-f178.google.com [209.85.208.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C6B622089F for ; Mon, 24 Jun 2019 07:41:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1561362101; bh=L6gUqCG8drdlw0JNPTw4WV1Q9+mlMVk9+r+rpW2w7AE=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=2qjE1E6++y+RdD7bONTE2cclIYxf/d21bmpIOBDi5ItxCTulU6+cCP4QmSQYO6Q99 YIp4tfIVt/RGRZdcKgp4rTNKKLxQx8VeMV8NJBA7JpbJSx9t0sPtfTX5tbxN5YUqPf EWglztaz5Ph5WxfmAmG0DeQeohJ89YkYuATaiUtk= Received: by mail-lj1-f178.google.com with SMTP id k18so11574652ljc.11 for ; Mon, 24 Jun 2019 00:41:40 -0700 (PDT) X-Gm-Message-State: APjAAAUKcQj9Gd6YJdhfOn1ANCCjL7CWBolBpr+AZBqlxXVVPrBUU6aI 7z+llOaDkmXs+5QhtvpBfYD7pCr3oZEYW9w7DhQ= X-Google-Smtp-Source: APXvYqyRaeX7TDpnwHIcIB85B+1Xs+snbFiN+OxL0vV5dvoDI7HDxPRSomSVeOWM1E7yFBBSG3qrtNjtyuH0wVO/59s= X-Received: by 2002:a2e:8155:: with SMTP id t21mr28115717ljg.80.1561362099155; Mon, 24 Jun 2019 00:41:39 -0700 (PDT) MIME-Version: 1.0 References: <20190621155845.7079-1-krzk@kernel.org> <20190621155845.7079-3-krzk@kernel.org> In-Reply-To: From: Krzysztof Kozlowski Date: Mon, 24 Jun 2019 09:41:27 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 3/4] ARM: dts: exynos: Add regulator suspend configuration to Odroid XU3/XU4/HC1 family To: Marek Szyprowski X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190624_004143_401317_C9793C55 X-CRM114-Status: GOOD ( 17.44 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree , "linux-samsung-soc@vger.kernel.org" , Linux Kernel , Kukjin Kim , linux-arm-kernel Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, 24 Jun 2019 at 09:20, Marek Szyprowski wrote: > > Hi Anand, > > On 2019-06-23 18:02, Anand Moon wrote: > > Thanks for this patch. Please add my > > > > Tested-by: Anand Moon > > > > [snip] > > > > Could you integrate below small changes into this patch. > > with these below changes suspend and resume work correctly at my end. > > > > [1] XU4_suspendresume.patch > > > > As per S2MPS11B PMIC 1.2.1 Regulator (Features) > > Fix the min max value for *Buck7* and *Buck8* > > > > -- Buck7 (VDD_1.0V_LDO) 1.5 A (1.2 V to 1.5 V, 12.5 mV step, default on 1.35 V) > > -- Buck8 (VDD_1.8V_LDO) 2.5 A (1.8 V to 2.1 V, 12.5 mV step, default on 2.0 V) > > Could you elaborate why such change for Buck7 and Buck8 is needed? Anand has here valid point - the constraints in DTS do not match hardware manual. This leads to question whether voltage table in driver is proper... Another point is the voltage itself. The schematics describes them as at specific voltage (1.35 V and 2.0 V) but after boot they are 1.2 V and 1.85 V. Maybe this shift comes from the problem above. > > > Also add suspend-off for *Buck9* > > Buck9 internally controls the power of USB hub. > > Adding suspend the this node help proper reset of USB hub on Odroid > > XU4 / HC1/ XU3 > > during suspend and resume. Below it the logs from my testing. > > Disabling Buck9 in suspend indeed reduces the power consumed by the > board during suspend-to-ram from about 80mA to as little as 7-10mA, what > matches the results of OdroidXU3. Thanks for the hint! Although I did not get what is the difference in the logs (Anand pasted two logs but they look the same) but the power consumption is reason is good enough. I would be happy to put in the changelog entire consumption difference. I can measure it on XU3-Lite but can you give me the XU4 (before and after)? Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel