From: Krzysztof Kozlowski <krzk@kernel.org>
To: Sylwester Nawrocki <s.nawrocki@samsung.com>
Cc: devicetree@vger.kernel.org,
"linux-samsung-soc@vger.kernel.org"
<linux-samsung-soc@vger.kernel.org>,
linux-pm@vger.kernel.org, sboyd@kernel.org, vireshk@kernel.org,
"Bartłomiej Żołnierkiewicz" <b.zolnierkie@samsung.com>,
roger.lu@mediatek.com, robh+dt@kernel.org,
linux-arm-kernel@lists.infradead.org,
"Marek Szyprowski" <m.szyprowski@samsung.com>
Subject: Re: [PATCH v5 2/4] dt-bindings: arm: samsung: Update the CHIPID binding for ASV
Date: Wed, 16 Oct 2019 19:16:41 +0300 [thread overview]
Message-ID: <CAJKOXPeagcSRUm2Qwwby=NHfWGdQ6KVZ2htb3UmnU2GfX+Ckcg@mail.gmail.com> (raw)
In-Reply-To: <20191016145756.16004-3-s.nawrocki@samsung.com>
On Wed, 16 Oct 2019 at 17:58, Sylwester Nawrocki <s.nawrocki@samsung.com> wrote:
>
> This patch adds documentation of new optional "samsung,asv-bin"
> property in the chipid device node and documents requirement of
> "syscon" compatible string. These additions are needed to support
> Exynos ASV (Adaptive Supply Voltage) feature.
>
> Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
> ---
> Depends on patch ("8d0daa4c89c9 dt-bindings: arm: samsung: Convert
> Exynos Chipid bindings to json-schema") already applied to Rob's
> dt/next.
>
> Changes since v4:
> - converted to YAML
>
> Changes since v3:
> - none
>
> Changes since v2:
> - corrected patch summary line prefix, the patch moved in the
> sequence
>
> Changes since v1 (RFC):
> - new patch
>
> .../bindings/arm/samsung/exynos-chipid.yaml | 31 +++++++++++++++++--
> 1 file changed, 28 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/arm/samsung/exynos-chipid.yaml b/Documentation/devicetree/bindings/arm/samsung/exynos-chipid.yaml
> index 9c573ad7dc7d..df84d9e9f4c2 100644
> --- a/Documentation/devicetree/bindings/arm/samsung/exynos-chipid.yaml
> +++ b/Documentation/devicetree/bindings/arm/samsung/exynos-chipid.yaml
> @@ -9,17 +9,42 @@ title: Samsung Exynos SoC series Chipid driver
> maintainers:
> - Krzysztof Kozlowski <krzk@kernel.org>
>
> +# Custom select to avoid matching all nodes with 'syscon'
> +select:
> + properties:
> + compatible:
> + contains:
> + const: samsung,exynos4210-chipid
> + required:
> + - compatible
> +
> properties:
> compatible:
> - items:
> - - const: samsung,exynos4210-chipid
> + allOf:
I think it was my mistake to use allOf in other Exynos bindings. It
should not be needed.
Rest looks good so with allOf removal:
Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-10-16 16:17 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20191016145806eucas1p2d522901fc79e1ca6e03f1bb516a81370@eucas1p2.samsung.com>
2019-10-16 14:57 ` [PATCH v5 0/4] Exynos Adaptive Supply Voltage support Sylwester Nawrocki
[not found] ` <CGME20191016145810eucas1p1b31400c9b2e7f30cdf6deeb4ccee2788@eucas1p1.samsung.com>
2019-10-16 14:57 ` [PATCH v5 1/4] PM / OPP: Support adjusting OPP voltages at runtime Sylwester Nawrocki
2019-10-17 6:42 ` Viresh Kumar
2019-10-21 11:23 ` Krzysztof Kozlowski
2019-10-22 2:23 ` Viresh Kumar
2019-10-22 18:43 ` Krzysztof Kozlowski
[not found] ` <CGME20191016145812eucas1p1a3cf3f44a2cff4c32a2270334630c4a2@eucas1p1.samsung.com>
2019-10-16 14:57 ` [PATCH v5 2/4] dt-bindings: arm: samsung: Update the CHIPID binding for ASV Sylwester Nawrocki
2019-10-16 16:16 ` Krzysztof Kozlowski [this message]
2019-10-17 9:03 ` Sylwester Nawrocki
[not found] ` <CGME20191016145813eucas1p1623db169f1ee93f88cb2c75090804747@eucas1p1.samsung.com>
2019-10-16 14:57 ` [PATCH v5 3/4] soc: samsung: Add Exynos Adaptive Supply Voltage driver Sylwester Nawrocki
2019-10-22 19:04 ` Krzysztof Kozlowski
2019-10-23 10:48 ` Sylwester Nawrocki
2019-10-23 11:20 ` Krzysztof Kozlowski
[not found] ` <CGME20191016145814eucas1p10d50d438abb850fd82f622122b223196@eucas1p1.samsung.com>
2019-10-16 14:57 ` [PATCH v5 4/4] ARM: EXYNOS: Enable exynos-asv driver for ARCH_EXYNOS Sylwester Nawrocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJKOXPeagcSRUm2Qwwby=NHfWGdQ6KVZ2htb3UmnU2GfX+Ckcg@mail.gmail.com' \
--to=krzk@kernel.org \
--cc=b.zolnierkie@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=robh+dt@kernel.org \
--cc=roger.lu@mediatek.com \
--cc=s.nawrocki@samsung.com \
--cc=sboyd@kernel.org \
--cc=vireshk@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).