From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D65AC7618B for ; Thu, 25 Jul 2019 11:19:38 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3417A2238C for ; Thu, 25 Jul 2019 11:19:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="CoyvYQXJ"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="IyIyoZGX" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3417A2238C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=SC+FVhxgCnVKXn7lOkMYvdxSA1hwyXIRGPwrtwujeno=; b=CoyvYQXJtQCm6j 3F7NQxcqLWxvq1cd/KiogyhKza2edw75ADOjdeLYLP1PjQ3idVJFo3K2t5VJ0OuEMemifxH31WEc4 zFWkroNwUjaaLevGsiIiGRRp9Lj6SOpBYycF+Xe/bUs+GYtjczJwQrpGyPOLGwVPhCsH5LW7BqBJn 3ZZMtd/dywwbq6D8+rTzjW7aLcpDaiWhg4oy2QLHgzU43lA98cNnb6zZkvjHp5g0l7K27vMq9qN56 0rxc2lL5SwcJy6XhwsVReblGfrspyNtLXdLQ7ZEg/pyw0HfnIkXU76QfDZ/XIfUaNJ7CagAZXQkgF NYARGm8uzL95UQpdHbLQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hqbma-0005lm-Fj; Thu, 25 Jul 2019 11:19:36 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hqbmR-0005fR-B5 for linux-arm-kernel@lists.infradead.org; Thu, 25 Jul 2019 11:19:29 +0000 Received: from mail-lf1-f48.google.com (mail-lf1-f48.google.com [209.85.167.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 83AF522C7B for ; Thu, 25 Jul 2019 11:19:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1564053565; bh=RsITX6ePkAMVGG3hL+GoDv/TMw1QkOZFUsmJ32yFJHs=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=IyIyoZGXnqdm45B+CAVG+GX2HdB16KcPBTrEBHdeSpQNU6/JM5ZF6nX0OgHdhbFZY oW6VgopC311MpHX5NMZ7mOiBLJRlDrRj00ITyHeZtv+TpaeihVLOHjZgo57P+EHV52 Sd7Mdjt3MmyTcWgIMxYM3C9RX0iVl5sWiC0XRRc4= Received: by mail-lf1-f48.google.com with SMTP id q26so34286775lfc.3 for ; Thu, 25 Jul 2019 04:19:25 -0700 (PDT) X-Gm-Message-State: APjAAAWrxreaglV3gbDRPCJBQAh7Sz70J9iALfNiXGpPQhB8UYkPdhBg GejPCl4zu/EeRsl/HCwxKDkThPdLLqz2w30/iGg= X-Google-Smtp-Source: APXvYqx1lM65hedlAaq5hJ9vcQnP8ka92OsgDK7he9h2XV+2K7EJvucPEzFYBmj3wjtr7i5NjbNjx5LfPxJPbg3eueM= X-Received: by 2002:ac2:5601:: with SMTP id v1mr277121lfd.106.1564053563654; Thu, 25 Jul 2019 04:19:23 -0700 (PDT) MIME-Version: 1.0 References: <20190724072008.6272-1-guillaume.gardet@free.fr> <20190725083433.6505-1-guillaume.gardet@arm.com> In-Reply-To: <20190725083433.6505-1-guillaume.gardet@arm.com> From: Krzysztof Kozlowski Date: Thu, 25 Jul 2019 13:19:12 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH V2 1/2] arm: dts: exynos: Add GPU/Mali T604 node to exynos5250 To: Guillaume X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190725_041927_447310_B4690729 X-CRM114-Status: GOOD ( 18.02 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "linux-samsung-soc@vger.kernel.org" , Kukjin Kim , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 25 Jul 2019 at 10:34, Guillaume wrote: > > From: Guillaume GARDET > > Add nodes for GPU (Mali T604) to Exynos5250. > Tested with kmscube and glmark2-es2-drm on Chromebook snow. > Load tested on arndale board. > > Signed-off-by: Guillaume GARDET > > Cc: Kukjin Kim > Cc: Krzysztof Kozlowski > Cc: linux-arm-kernel@lists.infradead.org > --- > V2 changes: > * move mali node as /soc sub-node > * move gpu_opp_table as mali sub-node > * minor style updates > * test on arndale board > * enable by default I was not specific enough. It can stay disabled in the DTSI because not all resources are provided. The board DTSes (all or ones which are tested) will enable it and provide missing resources - mali-supply. Just like: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=f0a6208b90bdd44f48f5718c8bb0eb1e763d14c0 > * add dt bindings, in a separate patch Put the bindings before DTS change. > > arch/arm/boot/dts/exynos5250.dtsi | 47 +++++++++++++++++++++++++++++++ > 1 file changed, 47 insertions(+) > > diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi > index d5e0392b409e..f7f34d469bde 100644 > --- a/arch/arm/boot/dts/exynos5250.dtsi > +++ b/arch/arm/boot/dts/exynos5250.dtsi > @@ -328,6 +328,52 @@ > iommus = <&sysmmu_rotator>; > }; > > + mali: gpu@11800000 { > + compatible = "samsung,exynos5250-mali", "arm,mali-t604"; > + reg = <0x11800000 0x5000>; > + interrupts = , > + , > + ; > + interrupt-names = "job", "mmu", "gpu"; > + clocks = <&clock CLK_G3D>; > + clock-names = "g3d"; According to bindings this is not proper clock name. I wonder why it was working... it seems the driver expects first clock to be always the core clock. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel