From: Hsin-Yi Wang <hsinyi@chromium.org>
To: Matthias Brugger <matthias.bgg@gmail.com>, zhiyong.tao@mediatek.com
Cc: Rob Herring <robh+dt@kernel.org>,
Devicetree List <devicetree@vger.kernel.org>,
"moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@lists.infradead.org>,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] arm64: dts: mt8183: kukui: use generic pin configs for i2c pins
Date: Thu, 1 Jul 2021 14:59:27 +0800 [thread overview]
Message-ID: <CAJMQK-gPeepDhNVc0S1Z_FxyDgiSuZZ4We6k8oWbQ_BbLJZxsw@mail.gmail.com> (raw)
In-Reply-To: <20210630073311.2177374-1-hsinyi@chromium.org>
On Wed, Jun 30, 2021 at 3:33 PM Hsin-Yi Wang <hsinyi@chromium.org> wrote:
>
> mt8183 i2c pins don't support PUPD register, so change to use generic
> pin configs instead of let it fail and fallback.
Though PUPD can be skipped, if we set bias-pull-up, we may miss the r0
r1 set in mtk_pinconf_adv_pull_set().
Sent another fix to replace this patch here:
https://patchwork.kernel.org/project/linux-mediatek/patch/20210701065439.2527790-1-hsinyi@chromium.org/
>
> Fixes: cd894e274b74 ("arm64: dts: mt8183: Add krane-sku176 board")
> Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
> Reviewed-by: Chen-Yu Tsai <wenst@chromium.org>
> ---
> arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
> index ae549d55a94fc..69dc04c3f7fff 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
> @@ -426,7 +426,7 @@ i2c0_pins: i2c0 {
> pins_bus {
> pinmux = <PINMUX_GPIO82__FUNC_SDA0>,
> <PINMUX_GPIO83__FUNC_SCL0>;
> - mediatek,pull-up-adv = <3>;
> + bias-pull-up;
> mediatek,drive-strength-adv = <00>;
> };
> };
> @@ -435,7 +435,7 @@ i2c1_pins: i2c1 {
> pins_bus {
> pinmux = <PINMUX_GPIO81__FUNC_SDA1>,
> <PINMUX_GPIO84__FUNC_SCL1>;
> - mediatek,pull-up-adv = <3>;
> + bias-pull-up;
> mediatek,drive-strength-adv = <00>;
> };
> };
> @@ -453,7 +453,7 @@ i2c3_pins: i2c3 {
> pins_bus {
> pinmux = <PINMUX_GPIO50__FUNC_SCL3>,
> <PINMUX_GPIO51__FUNC_SDA3>;
> - mediatek,pull-up-adv = <3>;
> + bias-pull-up;
> mediatek,drive-strength-adv = <00>;
> };
> };
> @@ -471,7 +471,7 @@ i2c5_pins: i2c5 {
> pins_bus {
> pinmux = <PINMUX_GPIO48__FUNC_SCL5>,
> <PINMUX_GPIO49__FUNC_SDA5>;
> - mediatek,pull-up-adv = <3>;
> + bias-pull-up;
> mediatek,drive-strength-adv = <00>;
> };
> };
> --
> 2.32.0.93.g670b81a890-goog
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2021-07-01 7:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-30 7:33 [PATCH v2] arm64: dts: mt8183: kukui: use generic pin configs for i2c pins Hsin-Yi Wang
2021-07-01 6:59 ` Hsin-Yi Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJMQK-gPeepDhNVc0S1Z_FxyDgiSuZZ4We6k8oWbQ_BbLJZxsw@mail.gmail.com \
--to=hsinyi@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
--cc=zhiyong.tao@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).