From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A5D4C2BA83 for ; Fri, 14 Feb 2020 12:00:09 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 34E132187F for ; Fri, 14 Feb 2020 12:00:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="q/7rVaZd"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="U30YN/B2" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 34E132187F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=saqRkKgU31ExLOf0v7a2Hsio+SqJwCsWmmjr6Jk761o=; b=q/7rVaZddbKG1/ xSR+lTDkcREqj8dcmG9vAdD/gLTaNVoLfuJ9ovEUdgxl37h7Y6PJ5MkW/OPPN4XqQ3z0ufGyYp9w3 WyI5Xip2rMF5gAYtKCqrtKZZz71h226jiRXDIU/wOYQvuqDmAnDQvMmroeJa5PAZ+RIGWQeFuljLI NEtpNC84AqVhzSZ1vmxQ+Y5zMBc4dAUzdj3k1xOvsAh/rBtosQV2GgVLOs4XApgajQqBPpTcmE25H qOGfgVEH+xpAjo5NqWaFxPz9UQWPTlPGoSqC3Qgg7uyEJjhdK0xkr24Zm8TQGU0iJYL6l2sfnIHAu l3cCZv6bF5BbdRqXHHzQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1j2ZdZ-0002TO-O3; Fri, 14 Feb 2020 12:00:01 +0000 Received: from mail-io1-xd42.google.com ([2607:f8b0:4864:20::d42]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1j2ZdW-0002ST-AO for linux-arm-kernel@lists.infradead.org; Fri, 14 Feb 2020 11:59:59 +0000 Received: by mail-io1-xd42.google.com with SMTP id c16so10257023ioh.6 for ; Fri, 14 Feb 2020 03:59:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=1uraVtsrzVMHzePG2yR6DCPEUMyavhEyjVs6nxEu24o=; b=U30YN/B2MumWYRiXps0fXkEWwSbju05SSBqJ4/raPl8BGRwatykH4NN5BhmTGAAcSP t0MWzBlOIlELWnQbS7pogaTu9V3noHu3hw2QYvs8WYZ93cF4NLKnuYa/kfrmCHch/ADb lbs1t4fy6PqAkeECeCkNqgUuytFbP1GcOSaDU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=1uraVtsrzVMHzePG2yR6DCPEUMyavhEyjVs6nxEu24o=; b=i6Rr0GaPcGwcX100W5GqUsSL5cRPvOCzhs2YpyuXs6AUM8uY1fBKBP752mMPlFWn7E OdgyQAst/DRuLoIMEace9Dz1M0s4GNHrOSNWFPY4tv24uIDwGz/6DU0+YESQKBfpOKDz hURYqBwnIIKvTrEQ+47iPmZKOdn8Ph4RfC2afTjeuhCUFPTfJVFSFN0gaWfY8T7xk92N 2dJJf7aUOLGUcKGN3B8ZJ/MD409Y8a1nb5yvzU5g4dHO+cFsAZijoSJljZ1JZpgtkKYQ Mvq+hiXcPPToRsGzr4EWxYdLazCkR/UL/uKI7UlNnVDMPt5TMTSr0wn7qGPw19nMhD+8 hNaQ== X-Gm-Message-State: APjAAAVoUK7tNkqtUSH5qSYF+omePb2WBzHiWQkRJLnwiMocDt4EZd8i Xkq6DszK9snqnNmaYVU5W/TRln2LWI+7vNuFneEkzQ== X-Google-Smtp-Source: APXvYqxMO1/xuTDVrtKd0ZSFbiILKTJtYtsmXOvsUOD0CpbVMimQ6kn9e/yNKOWoZ4c8M8RRzOmpBWPZFwTqt9iA31E= X-Received: by 2002:a6b:3845:: with SMTP id f66mr2068307ioa.102.1581681596283; Fri, 14 Feb 2020 03:59:56 -0800 (PST) MIME-Version: 1.0 References: <20200210035351.227499-1-hsinyi@chromium.org> In-Reply-To: From: Hsin-Yi Wang Date: Fri, 14 Feb 2020 19:59:30 +0800 Message-ID: Subject: Re: [PATCH] media: mtk-vpu: avoid unaligned access to DTCM buffer. To: Hans Verkuil X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200214_035958_388542_60D5544F X-CRM114-Status: GOOD ( 13.50 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew-CT Chen , Minghsiu Tsai , Enric Balletbo i Serra , lkml , Houlong Wei , Matthias Brugger , linux-mediatek@lists.infradead.org, Mauro Carvalho Chehab , Tiffany Lin , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , linux-media@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Feb 14, 2020 at 6:52 PM Hans Verkuil wrote: > > Hi Hsin-Yi Wang, > > On 2/10/20 4:53 AM, Hsin-Yi Wang wrote: > > struct vpu_run *run in vpu_init_ipi_handler() is an ioremapped DTCM (Data > > Tightly Coupled Memory) buffer shared with AP. It's not able to do > > unaligned access. Otherwise kernel would crash due to unable to handle > > kernel paging request. > > > > struct vpu_run { > > u32 signaled; > > char fw_ver[VPU_FW_VER_LEN]; > > unsigned int dec_capability; > > unsigned int enc_capability; > > wait_queue_head_t wq; > > }; > > > > fw_ver starts at 4 byte boundary. If system enables > > CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS, strscpy() will do > > read_word_at_a_time(), which tries to read 8-byte: *(unsigned long *)addr > > > > Copy the string by memcpy_fromio() for this buffer to avoid unaligned > > access. > > > > Fixes: 85709cbf1524 ("media: replace strncpy() by strscpy()") > > Signed-off-by: Hsin-Yi Wang > > This patch results in the following sparse warnings: > > sparse: WARNINGS > SPARSE:mtk-vpu/mtk_vpu.c mtk-vpu/mtk_vpu.c:834:52: warning: incorrect type in argument 3 (incompatible argument 1 (different address spaces)) > SPARSE:mtk-vpu/mtk_vpu.c mtk-vpu/mtk_vpu.c:609:29: warning: dereference of noderef expression > SPARSE:mtk-vpu/mtk_vpu.c mtk-vpu/mtk_vpu.c:613:35: warning: dereference of noderef expression > SPARSE:mtk-vpu/mtk_vpu.c mtk-vpu/mtk_vpu.c:614:35: warning: dereference of noderef expression > > Can you take a look? > > Regards, > > Hans > Thanks, I'll send a v2 to fix this _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel