From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92EE1C3A5A4 for ; Fri, 23 Aug 2019 08:14:09 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 699B2233A2 for ; Fri, 23 Aug 2019 08:14:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="hBw4gMjE"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="KQoYmM1k" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 699B2233A2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=qiENzFhUgaHvIM9gI8AsN+xekPw8lJxR+FwRGQPpG0Y=; b=hBw4gMjEiJk77N UAL7ziDxDbUgu2bytGYL/zfWjP67UIIQj1qWQzGv6UTMpB+oJZt3OZ9wos8Q7McJven47PnOTdNEi iNuiixWbbl2mdCOuaWtwxtzd0FaQlBEAr7GBz8Z/Cvb1/4hmBVKGrVhQZ0FsqU8wHwSPxl0tm0ium UDWvg7ic6bxe1oKIpncbeKuw4owSo9X+D1xKtnQS5F05Aqvkmf9kPfiWnRbdvpJL5F6SYE4YkBFWh +pIGD9VI5LjE5TiaFjcwewB01p4H3zhXv0FE0jp68uBPt4eSK4ME557cteTwj4IEoLE9iGI2fh/E6 nwdYCJOYSHmTjf6wlebg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1i14hu-00088j-NF; Fri, 23 Aug 2019 08:14:02 +0000 Received: from mail-qt1-x843.google.com ([2607:f8b0:4864:20::843]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1i14hs-00087W-6W for linux-arm-kernel@lists.infradead.org; Fri, 23 Aug 2019 08:14:01 +0000 Received: by mail-qt1-x843.google.com with SMTP id k13so10379430qtm.12 for ; Fri, 23 Aug 2019 01:13:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=+iEZzmAuZ9VlWo1rY1HoUVRqOc3pQbx/jL7+3U6XUrE=; b=KQoYmM1kiPcUeWePSRh/MATRSKtGHbDYwmscEnDEJex+ScfK8GC0Pn565Cm8BTQ7fS TN0P76B44uAatP3B3BZ61Hp3/1ZaAhV2sP1r/Qzr+VQI42UarAvsX6fIFMwnvDohlRBM i/SnM/kjB9KyiVRKnmaBnb4WhhIpto3GuckqI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=+iEZzmAuZ9VlWo1rY1HoUVRqOc3pQbx/jL7+3U6XUrE=; b=trzj63jORbA3gG+Sk2LNN/uHKpCDhCfs3GPfS/BYYB2/QUyV1Kqsl2px+spHjeQGOm dcLIsvBmq5ObYasoPY8M1MxkC7HQq9TUai8e0NR1Kufs9jkj8bveDikU/IxF5KHR6Dgy CuUK8AKLwEEeeh84iOE+rifEq0CXtHeoswFItgWtd8WLPTCelhYC1vI031pW8OdBkBxK DmGV04FyAxvaX/uzTSQvKc1e0u5ZqsyTH6BK4k3QzYXt8p7WVuyGkOe8URy5k+tqplo2 12UPqOKtJqCeNtDG5wBd7znL88HfCroZmFKHqB2rP+PBXaWIFfmUfqsVo+4f+CLvoHlf mAzA== X-Gm-Message-State: APjAAAXwVZ3a9Y1jBnkw9ug/JDtjAQhky30ux/0lphD/9LnHJrg46gb+ ako6CveG0yWMQc0se+DiaJSX469NhwA7exefnWyffQ== X-Google-Smtp-Source: APXvYqxNnLStOk4ZXp11RN7jSj7XJVMznct6ojLcGz5Yls6xfN9NE4mhgE85LSRowXYs50aMoWOgyWYV7b4IKr4cJAE= X-Received: by 2002:ac8:1e1c:: with SMTP id n28mr3591243qtl.78.1566548035657; Fri, 23 Aug 2019 01:13:55 -0700 (PDT) MIME-Version: 1.0 References: <20190822094516.55130-1-hsinyi@chromium.org> <1566547772.19935.2.camel@mhfsdcap03> In-Reply-To: <1566547772.19935.2.camel@mhfsdcap03> From: Hsin-Yi Wang Date: Fri, 23 Aug 2019 16:13:29 +0800 Message-ID: Subject: Re: [PATCH v2] i2c: mediatek: disable zero-length transfers for mt8183 To: Qii Wang X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190823_011400_268526_CA04E0C1 X-CRM114-Status: UNSURE ( 9.04 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Nicolas Boichat , Alexandru M Stan , Wolfram Sang , Jun Gao , lkml , linux-mediatek@lists.infradead.org, linux-i2c@vger.kernel.org, Matthias Brugger , Yingjoe Chen , Thomas Gleixner , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Aug 23, 2019 at 4:09 PM Qii Wang wrote: > > > > static u32 mtk_i2c_functionality(struct i2c_adapter *adap) > > { > > - return I2C_FUNC_I2C | I2C_FUNC_SMBUS_EMUL; > > + if (adap->quirks->flags & I2C_AQ_NO_ZERO_LEN) > > + return I2C_FUNC_I2C | > > + (I2C_FUNC_SMBUS_EMUL & ~I2C_FUNC_SMBUS_QUICK); > > + else > > + return I2C_FUNC_I2C | I2C_FUNC_SMBUS_EMUL; > > It can be removed? See previous discussion: https://patchwork.kernel.org/patch/10814391/#22484435 but not all SoC's quirks has I2C_AQ_NO_ZERO_LEN. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel