From: Hsin-Yi Wang <hsinyi@chromium.org>
To: Chen-Yu Tsai <wenst@chromium.org>
Cc: Enric Balletbo i Serra <enric.balletbo@collabora.com>,
Fabien Parent <fparent@baylibre.com>,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@lists.infradead.org>,
"moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>,
linux-gpio@vger.kernel.org,
Devicetree List <devicetree@vger.kernel.org>,
Zhiyong Tao <zhiyong.tao@mediatek.com>
Subject: Re: arm64: dts: mt8183: Incorrect mediatek,pull-*-adv values
Date: Mon, 26 Jul 2021 16:50:27 +0800 [thread overview]
Message-ID: <CAJMQK-hH5HM5iN4q6UgUf8T5fwj+0oULKPw=XafYOPrki-aDkg@mail.gmail.com> (raw)
In-Reply-To: <CAGXv+5Ev4QU72cMqMW7sA=dijzh7-DCsfHY+Lmqd36uzg_7Nww@mail.gmail.com>
On Mon, Jul 26, 2021 at 4:20 PM Chen-Yu Tsai <wenst@chromium.org> wrote:
>
> Hi,
>
> I was looking at MTK pinctrl stuff upstream, and it seems there are a few
> `mediatek,pull-*-adv` entries that have invalid values:
>
> arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi:
> mediatek,pull-down-adv = <10>;
> arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi:
> mediatek,pull-down-adv = <10>;
> arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi:
> mediatek,pull-down-adv = <10>;
> arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi:
> mediatek,pull-up-adv = <10>;
> arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi:
> mediatek,pull-down-adv = <10>;
> arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi:
> mediatek,pull-up-adv = <10>;
> arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi:
> mediatek,pull-down-adv = <10>;
> arch/arm64/boot/dts/mediatek/mt8183-pumpkin.dts:
> mediatek,pull-down-adv = <10>;
> arch/arm64/boot/dts/mediatek/mt8183-pumpkin.dts:
> mediatek,pull-down-adv = <10>;
> arch/arm64/boot/dts/mediatek/mt8183-pumpkin.dts:
> mediatek,pull-down-adv = <10>;
> arch/arm64/boot/dts/mediatek/mt8183-pumpkin.dts:
> mediatek,pull-up-adv = <10>;
> arch/arm64/boot/dts/mediatek/mt8183-pumpkin.dts:
> mediatek,pull-down-adv = <10>;
> arch/arm64/boot/dts/mediatek/mt8183-pumpkin.dts:
> mediatek,pull-up-adv = <10>;
>
> According to the bindings, the values should 0~3. <10> is probably a
> incorrect attempt at using binary representation, which is wrong. This
> probably leads to the pull-up/down getting disabled or ignored.
>
> Cound people still working on these two devices take a look?
>
Thanks for pointing this out. It's an incorrect value but 10=0b1010 so
the result is same as 2, since the driver test the value by checking
the last 2 bit. We should still fix this in dts.
>
> Regards
> ChenYu
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-07-26 8:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-26 8:20 arm64: dts: mt8183: Incorrect mediatek,pull-*-adv values Chen-Yu Tsai
2021-07-26 8:50 ` Hsin-Yi Wang [this message]
2021-07-26 8:58 ` Chen-Yu Tsai
2021-07-26 9:48 ` Enric Balletbo Serra
2021-07-27 11:06 ` Hsin-Yi Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJMQK-hH5HM5iN4q6UgUf8T5fwj+0oULKPw=XafYOPrki-aDkg@mail.gmail.com' \
--to=hsinyi@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=enric.balletbo@collabora.com \
--cc=fparent@baylibre.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=wenst@chromium.org \
--cc=zhiyong.tao@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).