From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1E6D4C4338F for ; Tue, 27 Jul 2021 11:08:33 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D3DC86187C for ; Tue, 27 Jul 2021 11:08:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org D3DC86187C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=3sKHB0xjTNKcnOqydec8ZnX8dKPrDSH/KPn2ofNE6gQ=; b=MTO6TtIHbSQ5k8 fOJSDoGpW2lb99rfqQo9sD7RFDwjzHjl/qq2bLSHqgpLHpIXRu0ANHFzhBVY6rBy6UFTJc8TUl9ro qEwvekIl3FM4Ad7MYIjVxSk90AJXtHk00gsNGL3Qt4SBw7RldyIjhuvvKh1ecH/Jp2qP1CYiTYOMT AT/l6yKnXGNmf2Piux0ZgQsxPOEOoOD+G4KQU1zJo6eZt6kdtWlgUKF3pdsJbTsk0P0cVE0PMSzEO FJITt5+Rz34rlaH7cxWcg4yKK5JKkmq6OODV4+lXpg9xeFuHb/Gn+XHqOQQX5YK2UjqatTMQZYGiL 1aVI+lruOVwBBfv1zVpg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m8Kuu-00EYqM-CA; Tue, 27 Jul 2021 11:06:32 +0000 Received: from mail-il1-x12e.google.com ([2607:f8b0:4864:20::12e]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m8Kuq-00EYoj-Sj for linux-arm-kernel@lists.infradead.org; Tue, 27 Jul 2021 11:06:30 +0000 Received: by mail-il1-x12e.google.com with SMTP id o7so10492955ilh.11 for ; Tue, 27 Jul 2021 04:06:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=KaH6OTwrWG90914prFT1/hBGveSe1LpJn6vY9Adila8=; b=SDh/ZiBj+wM/6RLopNPtxhhmjY4AOhwtUlsj7CBXB5kWyYXr4/eEwwMraRCCYOGBu8 4+gwT7UhgkK6MDRdhMlBprwwCgOKmjdnT+99U8rD/ZksvEtppzkTxzsX/KkM4vygStQR 5W8tG5BXychsijrX3WI5DDmbAZsvu6Xwzxre0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=KaH6OTwrWG90914prFT1/hBGveSe1LpJn6vY9Adila8=; b=jtQFWQrAjSYEq/W6AXHvH77NOfiJPrLVP6rEJodOnKlMR8is1QaEjJVouBkKHQKWhd JdhjkhAdBefY15ggung3UVezD1+bpL3IDBqmS+ReBMtz0aFpFtuixcxl5iNJT6ibeLj0 b1Ef+Xyoqda9J9YjhRAGU/13xtgF3p4fee0mtMUFZIA9vfWvqIBEbYkK4aUXAytMmhCV 2O+kdKsMCoqHUa+vbXZt9pxbsR/b1Pt0R92quX5LbBIUKk/4aR1FyPF2oIO2mJDJGDam uxI19RD+fsNydfiznfLept1PUgqYqhyAHM6y5lp911vQcAh2viFLS4LIodCyaJMomy8D /UlQ== X-Gm-Message-State: AOAM53153adPP22sAiqIK7qWmTkTBt/dAp/ttUDCAc/Y2uQNLXr3Mth0 WLOfPT7LJKoxuGufVJ3x0yBTC2VrUnbTgzGZqTN/hA== X-Google-Smtp-Source: ABdhPJzN3bMcohyLx+BmCBR3X6vZL0tTvooFjXp3y2FFWtT9H5YBTmKIeAGF+vyrAAa7JitBin1NHaVrXGI4vBGiKTs= X-Received: by 2002:a05:6e02:13e2:: with SMTP id w2mr16501620ilj.308.1627383986040; Tue, 27 Jul 2021 04:06:26 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Hsin-Yi Wang Date: Tue, 27 Jul 2021 19:06:00 +0800 Message-ID: Subject: Re: arm64: dts: mt8183: Incorrect mediatek,pull-*-adv values To: Enric Balletbo Serra Cc: Chen-Yu Tsai , Enric Balletbo i Serra , Fabien Parent , "moderated list:ARM/Mediatek SoC support" , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , linux-gpio@vger.kernel.org, Devicetree List , Zhiyong Tao X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210727_040628_956188_52C9BD5F X-CRM114-Status: GOOD ( 24.27 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jul 26, 2021 at 5:48 PM Enric Balletbo Serra wrote: > > Hi Chen-Yu and Hsin-Yi, > > > Missatge de Chen-Yu Tsai del dia dl., 26 de jul. > 2021 a les 10:58: > > > > On Mon, Jul 26, 2021 at 4:50 PM Hsin-Yi Wang wrote: > > > > > > On Mon, Jul 26, 2021 at 4:20 PM Chen-Yu Tsai wrote: > > > > > > > > Hi, > > > > > > > > I was looking at MTK pinctrl stuff upstream, and it seems there are a few > > > > `mediatek,pull-*-adv` entries that have invalid values: > > > > > > > > arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi: > > > > mediatek,pull-down-adv = <10>; > > The confusion comes probably because the binding says that this value > is valid, see > > Documentation/devicetree/bindings/pinctrl/pinctrl-mt8183.txt > > it'd be nice to convert that binding and the others to yaml format and > remove the possibility to specify it in binary format. > > Documentation/devicetree/bindings/pinctrl/pinctrl-mt65xx.txt > Documentation/devicetree/bindings/pinctrl/pinctrl-mt7622.txt > Documentation/devicetree/bindings/pinctrl/pinctrl-mt6797.txt > > Should be pretty easy as there is already an example: > Documentation/devicetree/bindings/pinctrl/mediatek,mt6779-pinctrl.yaml > Hi Enric, I've sent a patch for converting these into yaml here: https://lore.kernel.org/patchwork/patch/1468449/ Thanks > Thanks, > Enric > > > > > arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi: > > > > mediatek,pull-down-adv = <10>; > > > > arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi: > > > > mediatek,pull-down-adv = <10>; > > > > arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi: > > > > mediatek,pull-up-adv = <10>; > > > > arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi: > > > > mediatek,pull-down-adv = <10>; > > > > arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi: > > > > mediatek,pull-up-adv = <10>; > > > > arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi: > > > > mediatek,pull-down-adv = <10>; > > > > arch/arm64/boot/dts/mediatek/mt8183-pumpkin.dts: > > > > mediatek,pull-down-adv = <10>; > > > > arch/arm64/boot/dts/mediatek/mt8183-pumpkin.dts: > > > > mediatek,pull-down-adv = <10>; > > > > arch/arm64/boot/dts/mediatek/mt8183-pumpkin.dts: > > > > mediatek,pull-down-adv = <10>; > > > > arch/arm64/boot/dts/mediatek/mt8183-pumpkin.dts: > > > > mediatek,pull-up-adv = <10>; > > > > arch/arm64/boot/dts/mediatek/mt8183-pumpkin.dts: > > > > mediatek,pull-down-adv = <10>; > > > > arch/arm64/boot/dts/mediatek/mt8183-pumpkin.dts: > > > > mediatek,pull-up-adv = <10>; > > > > > > > > According to the bindings, the values should 0~3. <10> is probably a > > > > incorrect attempt at using binary representation, which is wrong. This > > > > probably leads to the pull-up/down getting disabled or ignored. > > > > > > > > Cound people still working on these two devices take a look? > > > > > > > Thanks for pointing this out. It's an incorrect value but 10=0b1010 so > > > the result is same as 2, since the driver test the value by checking > > > the last 2 bit. We should still fix this in dts. > > > > I see that the are > > > > > That probably explains why no one noticed. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel