From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 221A8C83003 for ; Wed, 29 Apr 2020 10:26:37 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DFED22073E for ; Wed, 29 Apr 2020 10:26:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="sVORgaYM" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DFED22073E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=X3akiZxbZCjc2R9f3YJrH+BiKI4fkDCsthUk5tRvnDA=; b=sVORgaYMKSWhRW L6uCxRoAkG688FesVkv6enPqZ9unp9dSj+MZnekE/hkguDEv1c1Hrqhe1dybs+SR0+kRbvm8PPJsu b3/O5rC4pziL+7GRPYThoQQsymtk8A0zoc+uS3li22tx3kz2rBLCtL+Cz0EvxaBN39OPhbsDCn7rC zzRZcLJBiv4pso5BnJzPi9ayDSRAdBK+k+UHAGcvoYdNpwSPmgYXCz3E7sz7tVstGeC9SVSG8+5am j1rDj2LeyvNq80Vq6ZT4oKckL1B4NPLV+cm0JJPEDYMIaqeuwks1bpPfLhSl9dROGpndcb5kh5jdO JpB+WlIfnq86VVksHAGQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jTjvH-0003vT-1y; Wed, 29 Apr 2020 10:26:35 +0000 Received: from mail-ot1-f65.google.com ([209.85.210.65]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jTjv9-0003o4-5X for linux-arm-kernel@lists.infradead.org; Wed, 29 Apr 2020 10:26:28 +0000 Received: by mail-ot1-f65.google.com with SMTP id m13so1232309otf.6 for ; Wed, 29 Apr 2020 03:26:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=mvIHWhU04g3v6LjKSsky5pEk63GBz533E/sobmoo7Wc=; b=B43mNTPvn05b7zC3wVLBAWVD8tooebpq02I7cLhICFsTdeLGf1wmj2M0sInByuuHa+ RcbrsPuGi7FvWD4chdRf08r4PGSsxvXo7pIM4UImuK1v5yocGuFC9klQ2gqdhq815muP PGXpeRRI1iqM0tGFTIzamgYFA5sLDhZNVYOXrtapT5PFo08eUx0tRPwE9nUl8tNIwmbY 3aXgCVNSRrof/8CDg9roRyOJpkUPdOmHaQXBHqoCeGpvkS23CqxYklhPaSxex2yZvWcU vhYB9yfpYVy965/Gm5t8rIGJWb6u17OIXTRxHtCIWXFBnpJI82LT2tVbpdjjNE1i/Yi9 TIPw== X-Gm-Message-State: AGi0PuYwJ3JJSPMqoDv9GM4QbUun+HcUylRL74mJ+YZgF5bboju8lMqU FKhBOt923219JsEX+zjGE4kp1IhdZYyUkcWcACU= X-Google-Smtp-Source: APiQypJnyzo4VqldDo304UGZQtLY+7AXB7jFtaFmqclX/7CuNEy43JujxFtdEqaZN6afWwi2LXcTKDkxwr3nMu1panQ= X-Received: by 2002:a9d:6ac8:: with SMTP id m8mr26003040otq.262.1588155984780; Wed, 29 Apr 2020 03:26:24 -0700 (PDT) MIME-Version: 1.0 References: <20200427132409.23664-1-calvin.johnson@oss.nxp.com> <20200427135820.GH25745@shell.armlinux.org.uk> <20200427143238.GA26436@lsv03152.swis.in-blr01.nxp.com> <20200427144806.GI25745@shell.armlinux.org.uk> <20200429053753.GA12533@lsv03152.swis.in-blr01.nxp.com> In-Reply-To: <20200429053753.GA12533@lsv03152.swis.in-blr01.nxp.com> From: "Rafael J. Wysocki" Date: Wed, 29 Apr 2020 12:26:12 +0200 Message-ID: Subject: Re: [net-next PATCH v2 0/3] Introduce new APIs to support phylink and phy layers To: Calvin Johnson X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200429_032627_227216_CF617AF4 X-CRM114-Status: GOOD ( 26.22 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew Lunn , Heikki Krogerus , Cristi Sovaiala , Ioana Ciornei , Florian Fainelli , "Rajesh V . Bikkina" , Pankaj Bansal , Russell King - ARM Linux admin , Diana Madalina Craciun , ACPI Devel Maling List , Andy Shevchenko , Florin Laurentiu Chiculita , Len Brown , Madalin Bucur , Makarand Pawagi , Varun Sethi , Marcin Wojtas , Linux ARM , Laurentiu Tudor , Greg Kroah-Hartman , "Rafael J. Wysocki" , Linux Kernel Mailing List , Jeremy Linton , linux.cj@gmail.com, netdev , "David S. Miller" , Heiner Kallweit Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Apr 29, 2020 at 7:38 AM Calvin Johnson wrote: > > On Mon, Apr 27, 2020 at 03:48:07PM +0100, Russell King - ARM Linux admin wrote: > > On Mon, Apr 27, 2020 at 08:02:38PM +0530, Calvin Johnson wrote: > > > On Mon, Apr 27, 2020 at 02:58:20PM +0100, Russell King - ARM Linux admin wrote: > > > > On Mon, Apr 27, 2020 at 06:54:06PM +0530, Calvin Johnson wrote: > > > > > Following functions are defined: > > > > > phylink_fwnode_phy_connect() > > > > > phylink_device_phy_connect() > > > > > fwnode_phy_find_device() > > > > > device_phy_find_device() > > > > > fwnode_get_phy_node() > > > > > > > > > > First two help in connecting phy to phylink instance. > > > > > Next two help in finding a phy on a mdiobus. > > > > > Last one helps in getting phy_node from a fwnode. > > > > > > > > > > Changes in v2: > > > > > move phy code from base/property.c to net/phy/phy_device.c > > > > > replace acpi & of code to get phy-handle with fwnode_find_reference > > > > > replace of_ and acpi_ code with generic fwnode to get phy-handle. > > > > > > > > > > Calvin Johnson (3): > > > > > device property: Introduce phy related fwnode functions > > > > > net: phy: alphabetically sort header includes > > > > > phylink: Introduce phylink_fwnode_phy_connect() > > > > > > > > Thanks for this, but there's more work that needs to be done here. I > > > > also think that we must have an ack from ACPI people before this can be > > > > accepted - you are in effect proposing a new way for representing PHYs > > > > in ACPI. > > > > > > Thanks for your review. > > > > > > Agree that we need an ack from ACPI people. > > > However, I don't think it is a completely new way as similar acpi approach to > > > get phy-handle is already in place. > > > Please see this: > > > https://elixir.bootlin.com/linux/v5.7-rc3/source/drivers/net/ethernet/apm/xgene/xgene_enet_hw.c#L832 > > > > That was added by: > > > > commit 8089a96f601bdfe3e1b41d14bb703aafaf1b8f34 > > Author: Iyappan Subramanian > > Date: Mon Jul 25 17:12:41 2016 -0700 > > > > drivers: net: xgene: Add backward compatibility > > > > This patch adds xgene_enet_check_phy_hanlde() function that checks whether > > MDIO driver is probed successfully and sets pdata->mdio_driver to true. > > If MDIO driver is not probed, ethernet driver falls back to backward > > compatibility mode. > > > > Since enum xgene_enet_cmd is used by MDIO driver, removing this from > > ethernet driver. > > > > Signed-off-by: Iyappan Subramanian > > Tested-by: Fushen Chen > > Tested-by: Toan Le > > Signed-off-by: David S. Miller > > > > The commit message says nothing about adding ACPI stuff, and searching > > the 'net for the posting of this patch seems to suggest that it wasn't > > obviously copied to any ACPI people: > > > > https://lists.openwall.net/netdev/2016/07/26/11 > > > > Annoyingly, searching for: > > > > "drivers: net: xgene: Add backward compatibility" site:lore.kernel.org > > > > doesn't find it on lore, so can't get the full headers and therefore > > addresses. > > > > So, yes, there's another driver using it, but the ACPI folk probably > > never got a look-in on that instance. Even if they had been copied, > > the patch description is probably sufficiently poor that they wouldn't > > have read the patch. > > > > I'd say there's questions over whether ACPI people will find this an > > acceptable approach. > > > > Given that your patch moves this from one driver to a subsystem thing, > > it needs to be ratified by ACPI people, because it's effectively > > becoming a standardised way to represent a PHY in ACPI. > > How can we get attention/response from ACPI people? This is in my queue, but the processing of this has been slow for a while, sorry about that. If you have a new version of the series, please submit it, otherwise ping me in a couple of days if I don't respond to the patches in the meantime. Thanks! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel