From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C83C0C433F5 for ; Mon, 13 Sep 2021 16:14:56 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8CF9160F58 for ; Mon, 13 Sep 2021 16:14:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 8CF9160F58 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=tbHYmq9if1+F8oVXJv+McE99aRX3sNOQapo6xBka4lQ=; b=hw/64JnVVBh3cL UULuNOWdEKMKkqkiBg/etnLZvsF4uH3Q6tDo5OhYI+AtDG3Y5MYk2YGR92BqtClhczkElOFHvxKjI gliqmlUL/QK9wXMeyNn9ccvNhfVl5J4UtlQDk/6CL/PEO25TWiXlKWu8jNjkhAuM2YgVMdZhD8wFP gLCkoGIDQaIr4OdQvHqmHir+AK7jwTrhgq+VBAmgDKTkKDTFPwnGVXKdhs/Iv5txOVKge1SmIklv8 J58EIK3IBZNaTKzmY70PEv9gbHzMRX7eL+3ztRl0RQbvXN+WAeaG9RiL1YNDiV6Xm9sZm1HFmjAse NUtOWHRRcBE5Sbffng4w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mPoZO-002JTM-NG; Mon, 13 Sep 2021 16:12:34 +0000 Received: from mail-ot1-f45.google.com ([209.85.210.45]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mPoZ6-002JIO-2q; Mon, 13 Sep 2021 16:12:17 +0000 Received: by mail-ot1-f45.google.com with SMTP id x10-20020a056830408a00b004f26cead745so14004856ott.10; Mon, 13 Sep 2021 09:12:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Iy17siULBUCrxqk6rYwdXsHfKX1tLqgQIZ1fMrLHGuE=; b=axtrTIV50U/IdSw29e0tQvclYX5L5hd0gtyl+FPIzgbkHx4sN1u42Gjh5jtDXRf9kN dNNKrKXFXjXLDKizlnpz2fTCBonhM7az7S6R1i0UBTcGUKvE+RMm7LZzpkotlUZ35SU7 DFlGapdKuBffrNguTAnjWawl2AZwLFL6Weg2J0ROEbkzG+7q9eEo7m7r/ZFI7ZH4VtTi niozb/2/xJTfxnFfi2U1wG6WkjWcFziXW+Owa0URNdAhuM2PehHv1R86tp8hOeUHfTB4 RYH/NHQ7YUJ+VdN0IUIbHW6mAPHsmaO+YivdlP7OCsKtfT50La30AKusKeTFfReVrb3U vFFA== X-Gm-Message-State: AOAM533ez1OW4kMXUl6QwRxoI3R0bhTYB5GNeoa1tlMEiH8vWMwnQpLp XCW/hhPw0jID2X6emOLIQ4qA+D6k7Y1bdqP+RAoIM6B9 X-Google-Smtp-Source: ABdhPJyzy1gv4uHNCOt/N4YjLvqkL6bUSLtCw1mbHgDLvA+w27AsuD5majS0JTZdRDoKIGoAddUwuwPZfNW4hzFkdjM= X-Received: by 2002:a9d:4d93:: with SMTP id u19mr10246317otk.86.1631549534058; Mon, 13 Sep 2021 09:12:14 -0700 (PDT) MIME-Version: 1.0 References: <20210826071557.29239-1-jeremy.linton@arm.com> <20210826071557.29239-4-jeremy.linton@arm.com> In-Reply-To: <20210826071557.29239-4-jeremy.linton@arm.com> From: "Rafael J. Wysocki" Date: Mon, 13 Sep 2021 18:12:03 +0200 Message-ID: Subject: Re: [PATCH v3 3/4] PCI/ACPI: Add Broadcom bcm2711 MCFG quirk To: Jeremy Linton Cc: Linux PCI , Lorenzo Pieralisi , nsaenz@kernel.org, Bjorn Helgaas , "Rafael J. Wysocki" , Len Brown , Rob Herring , =?UTF-8?Q?Krzysztof_Wilczy=C5=84ski?= , Florian Fainelli , bcm-kernel-feedback-list@broadcom.com, ACPI Devel Maling List , Linux ARM , linux-rpi-kernel@lists.infradead.org, Linux Kernel Mailing List X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210913_091216_186743_488A9F6E X-CRM114-Status: GOOD ( 20.76 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Aug 26, 2021 at 9:16 AM Jeremy Linton wrote: > > Now that there is a bcm2711 quirk, it needs to be enabled when the > MCFG is missing. Use an ACPI namespace _DSD property > "linux-ecam-quirk-id" as an alternative to the MCFG OEM. > > Signed-off-by: Jeremy Linton > Acked-by: Florian Fainelli > Acked-by: Bjorn Helgaas Acked-by: Rafael J. Wysocki > --- > drivers/acpi/pci_mcfg.c | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) > > diff --git a/drivers/acpi/pci_mcfg.c b/drivers/acpi/pci_mcfg.c > index 53cab975f612..04c517418365 100644 > --- a/drivers/acpi/pci_mcfg.c > +++ b/drivers/acpi/pci_mcfg.c > @@ -169,6 +169,9 @@ static struct mcfg_fixup mcfg_quirks[] = { > ALTRA_ECAM_QUIRK(1, 13), > ALTRA_ECAM_QUIRK(1, 14), > ALTRA_ECAM_QUIRK(1, 15), > + > + { "bc2711", "", 0, 0, MCFG_BUS_ANY, &bcm2711_pcie_ops, > + DEFINE_RES_MEM(0xFD500000, 0xA000) }, > }; > > static char mcfg_oem_id[ACPI_OEM_ID_SIZE]; > @@ -198,8 +201,22 @@ static void pci_mcfg_apply_quirks(struct acpi_pci_root *root, > u16 segment = root->segment; > struct resource *bus_range = &root->secondary; > struct mcfg_fixup *f; > + const char *soc; > int i; > > + /* > + * This may be a machine with a PCI/SMC conduit, which means it doesn't > + * have an MCFG. Use an ACPI namespace definition instead. > + */ > + if (!fwnode_property_read_string(acpi_fwnode_handle(root->device), > + "linux-ecam-quirk-id", &soc)) { > + if (strlen(soc) != ACPI_OEM_ID_SIZE) > + dev_err(&root->device->dev, "ECAM quirk should be %d characters\n", > + ACPI_OEM_ID_SIZE); > + else > + memcpy(mcfg_oem_id, soc, ACPI_OEM_ID_SIZE); > + } > + > for (i = 0, f = mcfg_quirks; i < ARRAY_SIZE(mcfg_quirks); i++, f++) { > if (pci_mcfg_quirk_matches(f, segment, bus_range)) { > if (f->cfgres.start) > -- > 2.31.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel