From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0CF94C4363D for ; Fri, 2 Oct 2020 14:15:46 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9CE2E206DD for ; Fri, 2 Oct 2020 14:15:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="PO5zftDA" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9CE2E206DD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=yEahgSnVmBTRv5OUFERvhhSw4a2Z4FKMY68m2lv5xuc=; b=PO5zftDAjQ2CvHstBEw0ZWho2 F7Q7prCylGRDKftv369B14znKJhEIr+zMCoAWdPk8t5y+uDLIxfjsaqqhQZlyfwaU9BhGaOInxmse iYWw9ARyOgqZTleKo4BpUzCh9uP7VuQhQcAtbaWUkDiJw9PBnbQgyKObcJ6/aeeTlT07LuAe7hTl0 2VR/hiTOa0m9wrXgqRlUDLqklQiyldorH8Mw0jk40iwrYm1UV48psUA0pg202IaW192xlxskkCktP Me9TerhtAcufIMJlKwvB5skxjePT2C1b1Pfy5EYSM/zSPLhyIz8GDyQelMk29NHneDp6Z+VfuKokp bWJzaLILA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kOLp6-000738-Vs; Fri, 02 Oct 2020 14:14:13 +0000 Received: from mail-ot1-f68.google.com ([209.85.210.68]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kOLp3-00071x-7D for linux-arm-kernel@lists.infradead.org; Fri, 02 Oct 2020 14:14:10 +0000 Received: by mail-ot1-f68.google.com with SMTP id h17so1492821otr.1 for ; Fri, 02 Oct 2020 07:14:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ihMziQ36Im0zrWKhCpCw4BTS3PLugco3lRz9KFCDqE8=; b=N6Oq8EovhwG8/XS6ytdYV6aUpLf6xIkEvXGYMczcx12tKvwG2J4L1XlE31ZGqC1fPe z8Oy+i+eb/J2DkHGosAHW0le2fLjGqd/N3dp5oxobhCH+3hNgOUma3p9ZC4MYHY68pJb 0ZG8/FEzQ3goKqGjSJOHDJF9K8nQF2A/7W2s/vkLbULnH5IUE60C4A0THtPo1k32wR1C XQFdeqEe7w5vQL6NQMrDqw1MmZWd8OfVMQzS5ng/+4Xg5tvt9SfgGW47NGrBuFi92K/n SzOhFZRn0Ri7rXSrq4c2dlbV3CKxoi6rrTmH5F1ma9KQ9R5gvyU5wb41Tsv6U2j0evjc CqLw== X-Gm-Message-State: AOAM53291JBmSm3HcSrDmTT2kci6YKW4TgEDK1VeiasMKCngv9T1vjLJ xGEK2RaJcpedZOGrbSzd+xwA1nIJy0zbBAZnA4s= X-Google-Smtp-Source: ABdhPJyZyRzl3PSCyG+0F3xvXXLMMo72pPpSBbPEGYzFl5a+viQSZv8vrl+z4BcyLgLlDH9lRF5gIuLcbG9Trd8Z6xw= X-Received: by 2002:a9d:718a:: with SMTP id o10mr1878239otj.262.1601648046490; Fri, 02 Oct 2020 07:14:06 -0700 (PDT) MIME-Version: 1.0 References: <20200930160430.7908-1-calvin.johnson@oss.nxp.com> <20200930160430.7908-2-calvin.johnson@oss.nxp.com> <39b9a51d-56f6-75f8-a88e-71a7e01b9f55@arm.com> In-Reply-To: <39b9a51d-56f6-75f8-a88e-71a7e01b9f55@arm.com> From: "Rafael J. Wysocki" Date: Fri, 2 Oct 2020 16:13:54 +0200 Message-ID: Subject: Re: [net-next PATCH v1 1/7] Documentation: ACPI: DSD: Document MDIO PHY To: Grant Likely X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201002_101409_301125_2D8D5846 X-CRM114-Status: GOOD ( 33.44 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew Lunn , Heikki Krogerus , "Rafael J. Wysocki" , Cristi Sovaiala , Calvin Johnson , Ioana Ciornei , Florian Fainelli , Russell King - ARM Linux admin , Diana Madalina Craciun , ACPI Devel Maling List , Andy Shevchenko , Florin Laurentiu Chiculita , Len Brown , Madalin Bucur , nd , Linux ARM , Laurentiu Tudor , netdev , "Rafael J. Wysocki" , Linux Kernel Mailing List , Jeremy Linton , linux.cj@gmail.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Oct 2, 2020 at 1:09 PM Grant Likely wrote: > > > > On 30/09/2020 17:37, Rafael J. Wysocki wrote: > > On Wed, Sep 30, 2020 at 6:05 PM Calvin Johnson > > wrote: > >> > >> Introduce ACPI mechanism to get PHYs registered on a MDIO bus and > >> provide them to be connected to MAC. > >> > >> Describe properties "phy-handle" and "phy-mode". > >> > >> Signed-off-by: Calvin Johnson > >> --- > >> > >> Documentation/firmware-guide/acpi/dsd/phy.rst | 78 +++++++++++++++++++ > >> 1 file changed, 78 insertions(+) > >> create mode 100644 Documentation/firmware-guide/acpi/dsd/phy.rst > >> > >> diff --git a/Documentation/firmware-guide/acpi/dsd/phy.rst b/Documentation/firmware-guide/acpi/dsd/phy.rst > >> new file mode 100644 > >> index 000000000000..f10feb24ec1c > >> --- /dev/null > >> +++ b/Documentation/firmware-guide/acpi/dsd/phy.rst > >> @@ -0,0 +1,78 @@ > >> +.. SPDX-License-Identifier: GPL-2.0 > >> + > >> +========================= > >> +MDIO bus and PHYs in ACPI > >> +========================= > >> + > >> +The PHYs on an mdiobus are probed and registered using > >> +fwnode_mdiobus_register_phy(). > >> +Later, for connecting these PHYs to MAC, the PHYs registered on the > >> +mdiobus have to be referenced. > >> + > >> +phy-handle > >> +----------- > >> +For each MAC node, a property "phy-handle" is used to reference the > >> +PHY that is registered on an MDIO bus. > > > > It is not clear what "a property" means in this context. > > > > This should refer to the documents introducing the _DSD-based generic > > device properties rules, including the GUID used below. > > > > You need to say whether or not the property is mandatory and if it > > isn't mandatory, you need to say what the lack of it means. > > > >> + > >> +phy-mode > >> +-------- > >> +Property "phy-mode" defines the type of PHY interface. > > > > This needs to be more detailed too, IMO. At the very least, please > > list all of the possible values of it and document their meaning. > > If the goal is to align with DT, it would be appropriate to point to > where those properties are defined for DT rather than to have a separate > description here. I suggest something along the lines of: > > The "phy-mode" _DSD property is used to describe the connection to > the PHY. The valid values for "phy-mode" are defined in > Documentation/devicetree/bindings/ethernet-controller.yaml > > > > >> + > >> +An example of this is shown below:: > >> + > >> +DSDT entry for MACs where PHY nodes are referenced > >> +-------------------------------------------------- > >> + Scope(\_SB.MCE0.PR17) // 1G > >> + { > >> + Name (_DSD, Package () { > >> + ToUUID("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"), > >> + Package () { > >> + Package (2) {"phy-mode", "rgmii-id"}, > >> + Package (2) {"phy-handle", Package (){\_SB.MDI0.PHY1}} > > > > What is "phy-handle"? > > > > You haven't introduced it above. > > Can you elaborate? "phy-handle" has a section to itself in this > document. Yes, it does. I overlooked it, sorry. > Agree that it needs to be defined more, but it does read to me > as having been defined. Yup. Cheers! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel