From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A5537C433EF for ; Tue, 8 Mar 2022 18:07:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=633hEIWnT54Rjit/OfAmkx/NV3pOwRgSRKyNU4w0dQc=; b=wPUTSt7tw2TOdw cdL96k9P6FicAbarvNgES456yLPPVVWs0F0jo6kckOwRbKSgJvFge5ba1YTSeCjtHM99nSf3i1Xis EwGCBsfBV7iQ8Ua2yQ9qPJYL9VFBCAMjcl+2bYTiMXN0G+VYI0IJ/P8pGOfyuddZZc0YQENDoxDhw oK4+7uKTC3weYMxk4dWSqH/C5GxI5OpkGWm+BxvsfNxpxhYUci7sGPXp2FfoKevhpMcQyw8fmH0xb RtviAFtFDEcV5rxPdVZaED9Ys0zeKbiJKrPy1MMPDcOtHmILM7ukjFRA85dLvqcEoqEDoV+pihjsh M63ECTWWpsa6+EN+Dq+g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nReDs-005iTH-36; Tue, 08 Mar 2022 18:06:13 +0000 Received: from mail-yb1-f182.google.com ([209.85.219.182]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nReDl-005iRM-06 for linux-arm-kernel@lists.infradead.org; Tue, 08 Mar 2022 18:06:06 +0000 Received: by mail-yb1-f182.google.com with SMTP id f38so39437042ybi.3 for ; Tue, 08 Mar 2022 10:06:03 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=fPR7/VGPV23k4djwaMrNbwv3yAQLYJoAwhpzcs5Yyug=; b=v01df1c80cE8oNjXau8Dp+P/e88ahhrIQqxRFdlVmw1F5thZGDTVg3TZUh77eNmAka R0CKlMvehgUtKQg9k3g0JfDwft+M4KMY4iyZymw/zjFaMr/FqFkZpkHMzGJNLQPC+myj 0B6cHus1bxRJPyDAkXqrtVd5p4D/2VaU31kd2y8JHRtG87RDD4wKL375EtRzStOp8Q3F mq4T8GBHyjyHzxJZ9cSOizGZ63BQir7DYMc0c/J7h0/11Q4b6Jdp/AHT9fZlWeu8vECh qBhvdCM9sgqNBW5Vgs9p6hc0fTwGj+XKyvGkhkheyAyTfIyYex5UIuw2uc1Rdzet8iKT l8qQ== X-Gm-Message-State: AOAM532LA8zwIsup96+PASrnb0po/KR0S4YFyw+/+OWCsDGnkRcTZNHS CVomx1JYX3cMebO6c5p5e6fc4hwy/RJ4q69SWCA= X-Google-Smtp-Source: ABdhPJwigo7JBM7noPglHYlHuR7oj7u0a4NOcWUIiDMhwSSasf1J7aZ7/2k+5D/dzpr1ZajSbc2vxcu4tar5e/CJIxw= X-Received: by 2002:a25:bbc1:0:b0:610:b4ce:31db with SMTP id c1-20020a25bbc1000000b00610b4ce31dbmr13302933ybk.482.1646762763032; Tue, 08 Mar 2022 10:06:03 -0800 (PST) MIME-Version: 1.0 References: <20220302180913.13229-1-ionela.voinescu@arm.com> <20220302180913.13229-2-ionela.voinescu@arm.com> In-Reply-To: <20220302180913.13229-2-ionela.voinescu@arm.com> From: "Rafael J. Wysocki" Date: Tue, 8 Mar 2022 19:05:52 +0100 Message-ID: Subject: Re: [PATCH v3 1/3] x86, ACPI: rename init_freq_invariance_cppc to arch_init_invariance_cppc To: Ionela Voinescu Cc: Sudeep Holla , "Rafael J . Wysocki" , Thomas Gleixner , Ingo Molnar , Giovanni Gherdovich , Catalin Marinas , Will Deacon , Valentin Schneider , Dietmar Eggemann , Sean Kelley , Pierre Gondois , Linux Kernel Mailing List , ACPI Devel Maling List , Linux ARM X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220308_100605_093587_E33496F5 X-CRM114-Status: GOOD ( 20.17 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Mar 2, 2022 at 7:10 PM Ionela Voinescu wrote: > > init_freq_invariance_cppc() was called in acpi_cppc_processor_probe(), > after CPU performance information and controls were populated from the > per-cpu _CPC objects. > > But these _CPC objects provide information that helps with both CPU > (u-arch) and frequency invariance. Therefore, change the function name > to a more generic one, while adding the arch_ prefix, as this function > is expected to be defined differently by different architectures. > > Signed-off-by: Ionela Voinescu > Tested-by: Valentin Schneider > Cc: Thomas Gleixner > Cc: Ingo Molnar > Cc: Giovanni Gherdovich > Cc: "Rafael J. Wysocki" Acked-by: Rafael J. Wysocki and who's expected to pick this up? > --- > arch/x86/include/asm/topology.h | 2 +- > drivers/acpi/cppc_acpi.c | 6 +++--- > 2 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/arch/x86/include/asm/topology.h b/arch/x86/include/asm/topology.h > index 2f0b6be8eaab..5ec70f186775 100644 > --- a/arch/x86/include/asm/topology.h > +++ b/arch/x86/include/asm/topology.h > @@ -223,7 +223,7 @@ static inline void arch_set_max_freq_ratio(bool turbo_disabled) > > #if defined(CONFIG_ACPI_CPPC_LIB) && defined(CONFIG_SMP) > void init_freq_invariance_cppc(void); > -#define init_freq_invariance_cppc init_freq_invariance_cppc > +#define arch_init_invariance_cppc init_freq_invariance_cppc > #endif > > #endif /* _ASM_X86_TOPOLOGY_H */ > diff --git a/drivers/acpi/cppc_acpi.c b/drivers/acpi/cppc_acpi.c > index 866560cbb082..bfd142ab4e07 100644 > --- a/drivers/acpi/cppc_acpi.c > +++ b/drivers/acpi/cppc_acpi.c > @@ -633,8 +633,8 @@ static bool is_cppc_supported(int revision, int num_ent) > * ) > */ > > -#ifndef init_freq_invariance_cppc > -static inline void init_freq_invariance_cppc(void) { } > +#ifndef arch_init_invariance_cppc > +static inline void arch_init_invariance_cppc(void) { } > #endif > > /** > @@ -816,7 +816,7 @@ int acpi_cppc_processor_probe(struct acpi_processor *pr) > goto out_free; > } > > - init_freq_invariance_cppc(); > + arch_init_invariance_cppc(); > > kfree(output.pointer); > return 0; > -- > 2.25.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel