From mboxrd@z Thu Jan 1 00:00:00 1970 From: jaswinder.singh@linaro.org (Jassi Brar) Date: Fri, 9 Sep 2011 00:47:56 +0530 Subject: [PATCH v2] ASoC: omap: convert per-board modules to platform drivers In-Reply-To: References: <1315503297-8365-1-git-send-email-mans.rullgard@linaro.org> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 9 September 2011 00:35, Mans Rullgard wrote: > On 8 September 2011 19:17, Jassi Brar wrote: >> On Thu, Sep 8, 2011 at 11:04 PM, Mans Rullgard wrote: >>> This converts the per-board modules to platform drivers for a >>> device created by in main platform setup. ?These drivers call >>> snd_soc_register_card() directly instead of going via a "soc-audio" >>> device and the corresponding driver in soc-core. >>> >>> Signed-off-by: Mans Rullgard >>> --- >>> Platform device names fixed. >>> N8x0 changed to get clocks before registering card. >>> --- >>> ?arch/arm/mach-omap2/board-3430sdp.c ? ? ? ? ?| ? ?6 ++ >>> ?arch/arm/mach-omap2/board-4430sdp.c ? ? ? ? ?| ? ?6 ++ >>> ?arch/arm/mach-omap2/board-am3517evm.c ? ? ? ?| ? ?7 +++ >>> ?arch/arm/mach-omap2/board-devkit8000.c ? ? ? | ? ?6 ++ >>> ?arch/arm/mach-omap2/board-igep0020.c ? ? ? ? | ? ?6 ++ >>> ?arch/arm/mach-omap2/board-n8x0.c ? ? ? ? ? ? | ? ?6 ++ >>> ?arch/arm/mach-omap2/board-omap3beagle.c ? ? ?| ? ?6 ++ >>> ?arch/arm/mach-omap2/board-omap3evm.c ? ? ? ? | ? ?7 +++ >>> ?arch/arm/mach-omap2/board-omap3pandora.c ? ? | ? ?6 ++ >>> ?arch/arm/mach-omap2/board-overo.c ? ? ? ? ? ?| ? 17 ++++++ >>> ?arch/arm/mach-omap2/board-rx51.c ? ? ? ? ? ? | ? ?6 ++ >>> ?arch/arm/mach-omap2/board-zoom-peripherals.c | ? ?6 ++ >> >> Can't we do by having omap_init_audio() in arch/arm/mach-omap2/devices.c >> generate a platform device of name depending upon machine_is_* ? > > I had the same thought, but I couldn't find a suitable string anywhere. > Are you suggesting an if(machine_is_foo()) cascade in omap_init_audio()? Yes. And you could assign same names as you do now in board init files.