From: "Clément Péron" <peron.clem@gmail.com>
To: Maxime Ripard <mripard@kernel.org>
Cc: "Mark Rutland" <mark.rutland@arm.com>,
linux-pwm@vger.kernel.org,
"Jernej Skrabec" <jernej.skrabec@siol.net>,
devicetree <devicetree@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
"Rob Herring" <robh+dt@kernel.org>,
"Chen-Yu Tsai" <wens@csie.org>,
"Thierry Reding" <thierry.reding@gmail.com>,
"Pengutronix Kernel Team" <kernel@pengutronix.de>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v2 1/7] dt-bindings: pwm: allwinner: Add H6 PWM description
Date: Wed, 6 Nov 2019 10:25:31 +0100 [thread overview]
Message-ID: <CAJiuCcdQzXScxu=nOP6HaKyFK6Q--gvQubNR8wezTVvPctVf7w@mail.gmail.com> (raw)
In-Reply-To: <20191105173208.GA46143@gilmour.lan>
Hi,
On Tue, 5 Nov 2019 at 18:32, Maxime Ripard <mripard@kernel.org> wrote:
>
> On Tue, Nov 05, 2019 at 01:34:37PM +0100, Clément Péron wrote:
> > On Tue, 5 Nov 2019 at 12:11, Maxime Ripard <mripard@kernel.org> wrote:
> > >
> > > Hi Clement, Uwe,
> > >
> > > On Mon, Nov 04, 2019 at 09:03:59AM +0100, Uwe Kleine-König wrote:
> > > > On Sun, Nov 03, 2019 at 09:33:28PM +0100, Clément Péron wrote:
> > > > > From: Jernej Skrabec <jernej.skrabec@siol.net>
> > > > >
> > > > > H6 PWM block is basically the same as A20 PWM, except that it also has
> > > > > bus clock and reset line which needs to be handled accordingly.
> > > > >
> > > > > Expand Allwinner PWM binding with H6 PWM specifics.
> > > > >
> > > > > Signed-off-by: Jernej Skrabec <jernej.skrabec@siol.net>
> > > > > Signed-off-by: Clément Péron <peron.clem@gmail.com>
> > > > > ---
> > > > > .../bindings/pwm/allwinner,sun4i-a10-pwm.yaml | 45 ++++++++++++++++++-
> > > > > 1 file changed, 44 insertions(+), 1 deletion(-)
> > > > >
> > > > > diff --git a/Documentation/devicetree/bindings/pwm/allwinner,sun4i-a10-pwm.yaml b/Documentation/devicetree/bindings/pwm/allwinner,sun4i-a10-pwm.yaml
> > > > > index 0ac52f83a58c..bf36ea509f31 100644
> > > > > --- a/Documentation/devicetree/bindings/pwm/allwinner,sun4i-a10-pwm.yaml
> > > > > +++ b/Documentation/devicetree/bindings/pwm/allwinner,sun4i-a10-pwm.yaml
> > > > > @@ -30,13 +30,46 @@ properties:
> > > > > - items:
> > > > > - const: allwinner,sun50i-h5-pwm
> > > > > - const: allwinner,sun5i-a13-pwm
> > > > > + - const: allwinner,sun50i-h6-pwm
> > > > >
> > > > > reg:
> > > > > maxItems: 1
> > > > >
> > > > > - clocks:
> > > > > + # Even though it only applies to subschemas under the conditionals,
> > > > > + # not listing them here will trigger a warning because of the
> > > > > + # additionalsProperties set to false.
> > > > > + clocks: true
> > > > > + clock-names: true
> > > > > + resets:
> > > > > maxItems: 1
> > > > >
> > > > > + if:
> > > > > + properties:
> > > > > + compatible:
> > > > > + contains:
> > > > > + const: allwinner,sun50i-h6-pwm
> > > > > +
> > > > > + then:
> > > > > + properties:
> > > > > + clocks:
> > > > > + items:
> > > > > + - description: Module Clock
> > > > > + - description: Bus Clock
> > > > > +
> > > > > + clock-names:
> > > > > + items:
> > > > > + - const: mod
> > > > > + - const: bus
> > > > > +
> > > > > + required:
> > > > > + - clock-names
> > > > > + - resets
> > > > > +
> > > > > + else:
> > > > > + properties:
> > > > > + clocks:
> > > > > + maxItems: 1
> > > > > +
> > > >
> > > > I guess this hunk says "If this is a allwinner,sun50i-h6-pwm, a mod and
> > > > bus clock is required.", right?
> > > >
> > > > I wonder if it is sensible to require a clock-names property in the else
> > > > branch, too. This would make it obvious if the clock there corresponds
> > > > to the "mod" or the "bus" clock on H6. (I guess it's "mod".)
> > >
> > > This can be done a bit differently and could address your concerns
> > >
> > > Something like
> > >
> > > properties:
> > > ...
> > >
> > > clocks:
> > > minItems: 1
> > > maxItems: 2
> > > items:
> > > - description: Bus Clock
> > > - description: Module Clock
> > >
> > > required:
> > > - clocks
> > >
> > > if:
> > > ...
> > >
> > > then:
> > > properties:
> > > clocks:
> > > maxItems: 2
> >
> > Here we should set minItems to 2 right ?
> > so Max = Min = 2
>
> It's done automatically by the tooling when the other is missing.
Ok thanks,
I will update in v4.
Regards,
Clément
>
> Maxime
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-11-06 9:25 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-03 20:33 [PATCH v2 0/7] Add support for H6 PWM Clément Péron
2019-11-03 20:33 ` [PATCH v2 1/7] dt-bindings: pwm: allwinner: Add H6 PWM description Clément Péron
2019-11-04 8:03 ` Uwe Kleine-König
2019-11-04 17:49 ` Clément Péron
2019-11-05 11:11 ` Maxime Ripard
2019-11-05 12:34 ` Clément Péron
2019-11-05 17:32 ` Maxime Ripard
2019-11-06 9:25 ` Clément Péron [this message]
2019-11-03 20:33 ` [PATCH v2 2/7] pwm: sun4i: Add an optional probe for reset line Clément Péron
2019-11-04 8:11 ` Uwe Kleine-König
2019-11-04 17:50 ` Clément Péron
2019-11-05 7:01 ` Philipp Zabel
2019-11-05 13:03 ` Clément Péron
2019-11-03 20:33 ` [PATCH v2 3/7] pwm: sun4i: Add an optional probe for bus clock Clément Péron
2019-11-04 8:24 ` Uwe Kleine-König
2019-11-04 18:07 ` Clément Péron
2019-11-04 20:10 ` Uwe Kleine-König
2019-11-04 20:19 ` Jernej Škrabec
2019-11-04 20:27 ` Clément Péron
2019-11-04 20:38 ` Jernej Škrabec
2019-11-03 20:33 ` [PATCH v2 4/7] pwm: sun4i: Add support to output source clock directly Clément Péron
2019-11-03 22:30 ` kbuild test robot
2019-11-03 22:41 ` Clément Péron
2019-11-03 22:58 ` kbuild test robot
2019-11-04 8:38 ` Uwe Kleine-König
2019-11-04 21:28 ` Clément Péron
2019-11-05 7:29 ` Uwe Kleine-König
2019-11-05 12:58 ` Clément Péron
2019-11-05 13:12 ` Uwe Kleine-König
2019-11-05 13:12 ` Clément Péron
2019-11-03 20:33 ` [PATCH v2 5/7] pwm: sun4i: Add support for H6 PWM Clément Péron
2019-11-03 20:33 ` [PATCH v2 6/7] arm64: dts: allwinner: h6: Add PWM node Clément Péron
2019-11-03 20:33 ` [PATCH v2 7/7] [DO NOT MERGE] arm64: allwinner: h6: enable Beelink GS1 PWM Clément Péron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJiuCcdQzXScxu=nOP6HaKyFK6Q--gvQubNR8wezTVvPctVf7w@mail.gmail.com' \
--to=peron.clem@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=jernej.skrabec@siol.net \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mripard@kernel.org \
--cc=robh+dt@kernel.org \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).