From: "Clément Péron" <peron.clem@gmail.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Mark Rutland <mark.rutland@arm.com>,
linux-pwm@vger.kernel.org,
Jernej Skrabec <jernej.skrabec@siol.net>,
devicetree <devicetree@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Maxime Ripard <mripard@kernel.org>,
Rob Herring <robh+dt@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
Thierry Reding <thierry.reding@gmail.com>,
Philipp Zabel <pza@pengutronix.de>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v3 3/7] pwm: sun4i: Add an optional probe for bus clock
Date: Tue, 5 Nov 2019 15:06:17 +0100 [thread overview]
Message-ID: <CAJiuCceg4CeHf-ZtK0A=SzQGGQD5D7CK2Zcy5dzDshmY=yP9sg@mail.gmail.com> (raw)
In-Reply-To: <20191105135745.mf63pelpbekmitgm@pengutronix.de>
Hi Uwe,
On Tue, 5 Nov 2019 at 14:57, Uwe Kleine-König
<u.kleine-koenig@pengutronix.de> wrote:
>
> On Tue, Nov 05, 2019 at 02:14:52PM +0100, Clément Péron wrote:
> > From: Jernej Skrabec <jernej.skrabec@siol.net>
> >
> > H6 PWM core needs bus clock to be enabled in order to work.
> >
> > Add an optional probe for it and a fallback for previous
> > bindings without name on module clock.
> >
> > Signed-off-by: Jernej Skrabec <jernej.skrabec@siol.net>
> > Signed-off-by: Clément Péron <peron.clem@gmail.com>
> > ---
> > drivers/pwm/pwm-sun4i.c | 45 +++++++++++++++++++++++++++++++++++++++--
> > 1 file changed, 43 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/pwm/pwm-sun4i.c b/drivers/pwm/pwm-sun4i.c
> > index 9ba83769a478..54e19fa56a4e 100644
> > --- a/drivers/pwm/pwm-sun4i.c
> > +++ b/drivers/pwm/pwm-sun4i.c
> > @@ -78,6 +78,7 @@ struct sun4i_pwm_data {
> >
> > struct sun4i_pwm_chip {
> > struct pwm_chip chip;
> > + struct clk *bus_clk;
> > struct clk *clk;
> > struct reset_control *rst;
> > void __iomem *base;
> > @@ -363,9 +364,35 @@ static int sun4i_pwm_probe(struct platform_device *pdev)
> > if (IS_ERR(pwm->base))
> > return PTR_ERR(pwm->base);
> >
> > - pwm->clk = devm_clk_get(&pdev->dev, NULL);
> > - if (IS_ERR(pwm->clk))
> > + /* Get all clocks and reset line */
> > + pwm->clk = devm_clk_get_optional(&pdev->dev, "mod");
> > + if (IS_ERR(pwm->clk)) {
> > + dev_err(&pdev->dev, "get clock failed %ld\n",
> > + PTR_ERR(pwm->clk));
>
> Please only print this message if PTR_ERR(pwm->clk) != -EPROBE_DEFER.
I didn't do it because the sunxi clock can't be compiled as module but
indeed i can change it so it's more generic.
> You might also want to make use of commit 57f5677e535b ("printf: add
> support for printing symbolic error names") and use
>
> dev_err(&pdev->dev, "get clock failed: %pe\n", pwm->clk);
Thanks I will change it,
Regards,
Clément
>
> Other than that the patch is fine for me.
>
> Best regards
> Uwe
>
> --
> Pengutronix e.K. | Uwe Kleine-König |
> Industrial Linux Solutions | http://www.pengutronix.de/ |
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-11-05 14:06 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-05 13:14 [PATCH v3 0/7] Add support for H6 PWM Clément Péron
2019-11-05 13:14 ` [PATCH v3 1/7] dt-bindings: pwm: allwinner: Add H6 PWM description Clément Péron
2019-11-05 21:33 ` Rob Herring
2019-11-05 13:14 ` [PATCH v3 2/7] pwm: sun4i: Add an optional probe for reset line Clément Péron
2019-11-05 13:36 ` Philipp Zabel
2019-11-05 14:01 ` Clément Péron
2019-11-05 13:53 ` Uwe Kleine-König
2019-11-05 13:14 ` [PATCH v3 3/7] pwm: sun4i: Add an optional probe for bus clock Clément Péron
2019-11-05 13:57 ` Uwe Kleine-König
2019-11-05 14:06 ` Clément Péron [this message]
2019-11-05 13:14 ` [PATCH v3 4/7] pwm: sun4i: Add support to output source clock directly Clément Péron
2019-11-05 14:56 ` Uwe Kleine-König
2019-11-06 21:24 ` Clément Péron
2019-11-07 6:51 ` Uwe Kleine-König
2019-11-08 8:34 ` Clément Péron
2019-11-05 13:14 ` [PATCH v3 5/7] pwm: sun4i: Add support for H6 PWM Clément Péron
2019-11-05 14:57 ` Uwe Kleine-König
2019-11-05 13:14 ` [PATCH v3 6/7] arm64: dts: allwinner: h6: Add PWM node Clément Péron
2019-11-05 13:14 ` [PATCH v3 7/7] [DO NOT MERGE] arm64: allwinner: h6: enable Beelink GS1 PWM Clément Péron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJiuCceg4CeHf-ZtK0A=SzQGGQD5D7CK2Zcy5dzDshmY=yP9sg@mail.gmail.com' \
--to=peron.clem@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=jernej.skrabec@siol.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mripard@kernel.org \
--cc=pza@pengutronix.de \
--cc=robh+dt@kernel.org \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).