From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A6865ECAAD3 for ; Thu, 1 Sep 2022 23:19:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=W+XuYCyxrNGch7G11oGF2Eh1IOSlvJmdamBLajIj0VM=; b=f9azt16F5uxUFS ZsjHq4GdTRkG66y1OloiO3vwE1km2ISJVXQP4qxwwh1981AVCqURWoYjhlu2zYnz4GvS4IvYAiYUj BXQli5a1WSalXJbLvkucNWmb3IZ3bl8dMYEvdh4BEPy7oPqh7Le8Hmx1LJoLjqES3TitbHaMxnCbQ 5p3RXtF5nWoU/Du7skttCnCH/ZzbyvIGs5iDGf+YyDBIKHsw6kHr9NMaD1y0oQlXfAh5j5gcLF/8H FxYM18f4+sJNDxlEarsnboCgt39d6UneHYPl7viVkynz1+XK+wrKu1tHkJbbyiBxjjOYZgCZkOHra keblnaGkYdDGL11ApUow==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oTtS2-00FjWo-98; Thu, 01 Sep 2022 23:18:22 +0000 Received: from mail-yw1-x112a.google.com ([2607:f8b0:4864:20::112a]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oTtRy-00FjR9-Vi for linux-arm-kernel@lists.infradead.org; Thu, 01 Sep 2022 23:18:20 +0000 Received: by mail-yw1-x112a.google.com with SMTP id 00721157ae682-3413ad0640dso1736457b3.13 for ; Thu, 01 Sep 2022 16:18:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=rjiF9dcJ/mORZlmNTO18kEduhbATdpbM6SHMK6U+ruY=; b=miInjSJE+fzo5gS/eKt5cfKejZWjk/URgt0UsOF5yFYhBi4SW0mjlLLL/BxcWNS7q1 ZbX9dW3k1PQz07RhMq4TY0IKX8uDz5gqWib15fn/ENu8F4BQEoeMpBqRR4aXJyehSLYL rlX+s6DOoRRQDDNJOyrdh0XgYf16gCuBQ8/5nYMEbXay2V4G5ElxQsF4iKh7ls3v0nku D6GH4AzNn0lGwU6+bKnN6gfpnyUHAp3BKdNloRCyIKDJYsKSeK4d/tInEIryGNWiC42i SC0dR4U7pJvq0mNT8d7KhoSD0pTCfW3Ka8zPz/CWyWvVkBglY+I9aRF6ESuk5tijxW2i 1vog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=rjiF9dcJ/mORZlmNTO18kEduhbATdpbM6SHMK6U+ruY=; b=JXCFh82uv8w1K0O8nY/JINpwW4hIHEunCjllXgF6JYABy9q4KLUiii2Lpo9CmCIf0g fZwWzzZguci0cgDQjoGunNvv9kWoWdfPC95EZya1uQD/NZtyOdtqzIwLa6lnIL7MJkd3 LZgEZARgyWoKgnnvBsxUolFQwSXWFJHeNrMAZ/w8pNjOtkqoCMx9mmiMuGvBH12XZKn9 Ql4D41kmrZ/XcO11RESQydHgu2aRkuat1ET4sNB7mBaB0bXXPV4jwLmEy9cBRzLbMQ08 /zZ0X/SiF5ociSuYPblc04qG+yVh1FiQmqQIjNYhqQhZE2mvMkpEjkQjbj2zsg4cW4Ip OFqA== X-Gm-Message-State: ACgBeo05/9jgRyrIuiJlXKauqYKQJe/Iq9SaRvLRke8KqcY4G9W5TCah TMFlhWSYYRZVsQPyxbzRLCR98XPQ+UqXhqjFRIHqKQ== X-Google-Smtp-Source: AA6agR6m7scNwFemz6Af1WoGTDIcSPP5pnTPi8sC0t6BGCdPYrcUbrHz9JxtFN2qOLjSTkeI4M1Lodd/jngX9vslX64= X-Received: by 2002:a0d:c981:0:b0:330:dc03:7387 with SMTP id l123-20020a0dc981000000b00330dc037387mr25164956ywd.380.1662074295806; Thu, 01 Sep 2022 16:18:15 -0700 (PDT) MIME-Version: 1.0 References: <20220901173516.702122-1-surenb@google.com> <20220901173516.702122-4-surenb@google.com> <20220901202239.tnnzlbermiyvkmih@moria.home.lan> In-Reply-To: <20220901202239.tnnzlbermiyvkmih@moria.home.lan> From: Suren Baghdasaryan Date: Thu, 1 Sep 2022 16:18:04 -0700 Message-ID: Subject: Re: [RFC PATCH RESEND 03/28] mm: introduce __find_vma to be used without mmap_lock protection To: Kent Overstreet Cc: Andrew Morton , Michel Lespinasse , Jerome Glisse , Michal Hocko , Vlastimil Babka , Johannes Weiner , Mel Gorman , Davidlohr Bueso , Matthew Wilcox , "Liam R. Howlett" , Peter Zijlstra , Laurent Dufour , Laurent Dufour , "Paul E . McKenney" , Andy Lutomirski , Song Liu , Peter Xu , David Hildenbrand , dhowells@redhat.com, Hugh Dickins , bigeasy@linutronix.de, David Rientjes , Axel Rasmussen , Joel Fernandes , Minchan Kim , kernel-team , linux-mm , linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, x86@kernel.org, LKML X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220901_161819_052837_168DA9D1 X-CRM114-Status: GOOD ( 17.01 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Sep 1, 2022 at 1:22 PM Kent Overstreet wrote: > > On Thu, Sep 01, 2022 at 10:34:51AM -0700, Suren Baghdasaryan wrote: > > Add __find_vma function to be used for VMA lookup under rcu protection. > > So it was news to me that the rb tree code can be used for lockless lookups - > not having looked at lib/rbtree.c in over 10 years :) - I still think it should > be mentioned in the commit message that that's what you're doing and why it's > safe, because it's not exactly common knowledge and lockless stuff deserves > extra scrutiny. > > Probably worth a comment, too. Ack. > > Reviewed-by: Kent Overstreet Thanks! > > -- > To unsubscribe from this group and stop receiving emails from it, send an email to kernel-team+unsubscribe@android.com. > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel