From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 95B60ECAAD5 for ; Fri, 2 Sep 2022 17:47:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=K9SlYA60V2XxV/+TfvjxEtwDw0VfY3yBXvxLPXSOhWc=; b=Epv2bOQu8+o1Ju Wg2Z2UY432C9rl5PyzFzi9FKnIacMWVwBOaVlMDbE4judrKpTlcyR5yNRIQursHrixmTJeI+p53ik Y03XWQ+NgpyRgdQl0Qb0xVnen385LhdX7vfUumZuGAOUqvLcF4Z9TnfRB+Jnbxqk4sNrOTa8bpjgx p/bw4TvyeigXMHaqOLYPVOMwhAmcI0AxJ43wbJR1KMiSRKTuNwvlIB/oZ/QjTXv9dzODzOPOyas9R 8RLCSoNa3EpHKyZwtyhpEUNXt7cBh4kfVC9vLZi8I9hGFO3lNzZ4HkyDz28wz+Cx4QGoXZewXN6S5 kVAFXO5NVDmxFAtMfGKg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oUAkY-008Pav-3v; Fri, 02 Sep 2022 17:46:38 +0000 Received: from mail-yw1-x1134.google.com ([2607:f8b0:4864:20::1134]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oUAkV-008PTB-Du for linux-arm-kernel@lists.infradead.org; Fri, 02 Sep 2022 17:46:36 +0000 Received: by mail-yw1-x1134.google.com with SMTP id 00721157ae682-3321c2a8d4cso23306237b3.5 for ; Fri, 02 Sep 2022 10:46:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=NSRndixZOPtPP2wASFAk4jDgEuiWo0dI3vnvon4iVQw=; b=p7yNLbs3A5QrKhqddelaYGVcTxeyeBxU6V+CfdZl8egFvd/kd/WfV9WhezQZtduD6U ojUTPDqjmbVXUP/qOTQPhW1iVshOCe2/Kkhz9tx+/VHsbb3s9z+ix80u0zoMvuDVLsQB S/Cxva/vEynV/XJ7yvbf62BupfG2Y2C3SYRhWwecv+MxIs/2Pzdujt1V0m7EMZ54a3/6 19zervSnL1o4aOPUCovxya1eT+MWmyz2/s9L2sHGaXlBv/pUOAES9XRIbgskqOYZFOnW ylq4VF2M8F7Gfv/jH9DNcMnD9repohepfZJtVB3QBDZAJd9V4ggMFUAjBmSpxHZ+g1Yv 99IA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=NSRndixZOPtPP2wASFAk4jDgEuiWo0dI3vnvon4iVQw=; b=w99wAXf0+v3+ZljkpnGH1KCTrGAErJ7kie+K8iteOd6jKOZQNzcIK0MGGSH8kxQbGx l2FDAN/lmAMbv5Y1LNIuSy19T3p9SYHAEy3J/lUSVn8hNcO7wowCLWYUYZBnBwv+IJ22 I2/3XeapBpPqQKmc1Cs/HT2i3WQvAoEmsdN12aQdshV+qjFmJ54FptcKgYp0xYLRj7xj XcRBxKMIB9FI4lbODnm7QfASDawupj61Nw0BeOqoT++VLuabZOfyLuAvybF0A9IufXw6 VQz6UlEzX/cw9/mXEngnUHMjuYX8idrnf5K5rHM2rWasMlUuozYbE5GUFU9lYJP5hupL KBsA== X-Gm-Message-State: ACgBeo3x6ZN8p08xK8KLaq49R6NdG8OuURSe5xdv+z0D3irSDLMVnBjN GkWXWkH3kLVAt1wNVxxagO22wpv5YqtSLSalDzVYkw== X-Google-Smtp-Source: AA6agR6GDF9sHJzcyjUaya7fByUdhkEhzDw6yipl5NEBaRGv8CiuB2xbiyA1Dj0na3Efi1HIFlyduTjOsTurz7MleBc= X-Received: by 2002:a0d:e7c3:0:b0:344:8cee:c384 with SMTP id q186-20020a0de7c3000000b003448ceec384mr7800183ywe.514.1662140791101; Fri, 02 Sep 2022 10:46:31 -0700 (PDT) MIME-Version: 1.0 References: <20220901173516.702122-1-surenb@google.com> <20220901173516.702122-5-surenb@google.com> <20220901202409.e2fqegqghlijkzey@moria.home.lan> In-Reply-To: From: Suren Baghdasaryan Date: Fri, 2 Sep 2022 10:46:20 -0700 Message-ID: Subject: Re: [RFC PATCH RESEND 04/28] mm: move mmap_lock assert function definitions To: Sebastian Andrzej Siewior Cc: Kent Overstreet , Andrew Morton , Michel Lespinasse , Jerome Glisse , Michal Hocko , Vlastimil Babka , Johannes Weiner , Mel Gorman , Davidlohr Bueso , Matthew Wilcox , "Liam R. Howlett" , Peter Zijlstra , Laurent Dufour , Laurent Dufour , "Paul E . McKenney" , Andy Lutomirski , Song Liu , Peter Xu , David Hildenbrand , dhowells@redhat.com, Hugh Dickins , David Rientjes , Axel Rasmussen , Joel Fernandes , Minchan Kim , kernel-team , linux-mm , linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, x86@kernel.org, LKML X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220902_104635_478003_828622FF X-CRM114-Status: GOOD ( 19.85 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Sep 1, 2022 at 11:23 PM Sebastian Andrzej Siewior wrote: > > On 2022-09-01 16:24:09 [-0400], Kent Overstreet wrote: > > > --- a/include/linux/mmap_lock.h > > > +++ b/include/linux/mmap_lock.h > > > @@ -60,6 +60,18 @@ static inline void __mmap_lock_trace_released(struct mm_struct *mm, bool write) > > > > > > #endif /* CONFIG_TRACING */ > > > > > > +static inline void mmap_assert_locked(struct mm_struct *mm) > > > +{ > > > + lockdep_assert_held(&mm->mmap_lock); > > > + VM_BUG_ON_MM(!rwsem_is_locked(&mm->mmap_lock), mm); > > > > These look redundant to me - maybe there's a reason the VM developers want both, > > but I would drop the VM_BUG_ON() and just keep the lockdep_assert_held(), since > > that's the standard way to write that assertion. > > Exactly. rwsem_is_locked() returns true only if the lock is "locked" not > necessary by the caller. lockdep_assert_held() checks that the lock is > locked by the caller - this is the important part. Ok, if at the end of the day there is a consensus that this redundancy should be removed then I'll do that in a patch separate from this series. Please note that in this patch I'm not changing these functions in any way, just moving them. > > Sebastian > > -- > To unsubscribe from this group and stop receiving emails from it, send an email to kernel-team+unsubscribe@android.com. > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel