From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,T_DKIMWL_WL_HIGH,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96373C28CC0 for ; Fri, 31 May 2019 02:02:28 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6B8ED24459 for ; Fri, 31 May 2019 02:02:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="lR/hu/S8"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=nifty.com header.i=@nifty.com header.b="Gy9TmV6S" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6B8ED24459 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=socionext.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=zg3XxHuCPxam9IqlHQGwZ1eHId6Ul1WHkH7GaGDJADs=; b=lR/hu/S8ow59KK wL7+LdVhs11N3mpo+eT80gDCbgNV8RIP5jFi5DCWhBODAc1YMAZO9VKVsJarYGcs2Wa8dn1vRTcxx 6M5aR7NL8lxcrupRd/Xsjmm60ElDwuL0uaJ8tKJAoUTE+IG2OL7oO0uTdkPE43+KOLD0nE45LcIhP eAVJN6MzM7I2R8QyKc/nRKI69NkOAe8jDjQm1lCmRHLKeSY1XwvOz9EGu8ep1dIL5zp0KyJfQxET8 0tJ0tSmT5F4Rkwh6VkPkJfEa2oNKVlgmcCKywZF6v5KBsF3CUNFSMCQXqswXqWriA2WqZSmouzbti VtnlMOgBpJNQNIQP5uUg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hWWsE-0001fQ-7V; Fri, 31 May 2019 02:02:26 +0000 Received: from conssluserg-03.nifty.com ([210.131.2.82]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hWWsA-0001es-Ug for linux-arm-kernel@lists.infradead.org; Fri, 31 May 2019 02:02:24 +0000 Received: from mail-vs1-f46.google.com (mail-vs1-f46.google.com [209.85.217.46]) (authenticated) by conssluserg-03.nifty.com with ESMTP id x4V220IG026218 for ; Fri, 31 May 2019 11:02:00 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conssluserg-03.nifty.com x4V220IG026218 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1559268121; bh=JFKrCexjwszU8gfQr6gW63eXVh2Hm+G6S4mj7tEbXBk=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=Gy9TmV6St9w3knc6CLRQIxjO90p3aOCozwt75d8GEjJesM/ZEDgxL8yKNCQezIlMc HVCUNTVU3t2OD7wFo49b/0s5+H1p8zXmzTxBkh0pLyIo5CaZbZeRoUY1gSowgEymjy TuHvd6Lqwpt3rRaSn9PoSC76moqRKXBaqC3eHlLE/4kx/sqIMn99GMJGKPF2n4T+Ln +3Net432SjsjP6bO0ADHtZdEs8SXhz4pQWYuW4rYy/iu4aSPLm02HrBieQUlI76e9w kFq0h9gnBHlNrm938clEM/L8KGz9VputCTg6OE0Jcv0/UMElkP3QO1F6Xh5ykq4NFW xHLYv63EaCg1Q== X-Nifty-SrcIP: [209.85.217.46] Received: by mail-vs1-f46.google.com with SMTP id d128so5688274vsc.10 for ; Thu, 30 May 2019 19:02:00 -0700 (PDT) X-Gm-Message-State: APjAAAX1xpZKfH3bQ3wGm2drhzTkDS2FTb5l9T65BbKHhbQRNB+X6apr 9q0rsTgsK35RVv8uNmbGbuTvNMmhpmTmcXMeGjI= X-Google-Smtp-Source: APXvYqzVzNfAFknY7H7mEOgb5wDJU1a317iny5D7E6KvkLWcVJbVf3bJmiOMvqJe5LYISJjwZVa1Kmh96JHDJfwhpUY= X-Received: by 2002:a67:b109:: with SMTP id w9mr3599220vsl.155.1559268119666; Thu, 30 May 2019 19:01:59 -0700 (PDT) MIME-Version: 1.0 References: <20190529182324.8140-1-Jason@zx2c4.com> In-Reply-To: <20190529182324.8140-1-Jason@zx2c4.com> From: Masahiro Yamada Date: Fri, 31 May 2019 11:01:23 +0900 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] arm: vdso: pass --be8 to linker if necessary To: "Jason A. Donenfeld" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190530_190223_201297_106D9775 X-CRM114-Status: GOOD ( 14.63 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Russell King , Arnd Bergmann , Linux Kernel Mailing List , linux-arm-kernel , Ard Biesheuvel Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Jason, Thanks for catching this. On Thu, May 30, 2019 at 3:26 AM Jason A. Donenfeld wrote: > > The commit fe00e50b2db8 ("ARM: 8858/1: vdso: use $(LD) instead of $(CC) > to link VDSO") removed the passing of CFLAGS, since ld doesn't take > those directly. However, prior, big-endian ARM was relying on gcc to > translate its -mbe8 option into ld's --be8 option. Lacking this, ld 'git grep -- -mbe8' has no hit. Is it a toolchain internal flag? > generated be32 code, making the VDSO generate SIGILL when called by > userspace. > > This commit passes --be8 if CONFIG_CPU_ENDIAN_BE8 is enabled. > > Signed-off-by: Jason A. Donenfeld > Cc: Masahiro Yamada > Cc: Russell King > Cc: Arnd Bergmann > Cc: Ard Biesheuvel > --- > arch/arm/vdso/Makefile | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/vdso/Makefile b/arch/arm/vdso/Makefile > index fadf554d9391..1f5ec9741e6d 100644 > --- a/arch/arm/vdso/Makefile > +++ b/arch/arm/vdso/Makefile > @@ -10,9 +10,10 @@ obj-vdso := $(addprefix $(obj)/, $(obj-vdso)) > ccflags-y := -fPIC -fno-common -fno-builtin -fno-stack-protector > ccflags-y += -DDISABLE_BRANCH_PROFILING > > -ldflags-y = -Bsymbolic --no-undefined -soname=linux-vdso.so.1 \ > +ldflags-$(CONFIG_CPU_ENDIAN_BE8) := --be8 > +ldflags-y := -Bsymbolic --no-undefined -soname=linux-vdso.so.1 \ > -z max-page-size=4096 -z common-page-size=4096 \ > - -nostdlib -shared \ > + -nostdlib -shared $(ldflags-y) \ > $(call ld-option, --hash-style=sysv) \ > $(call ld-option, --build-id) \ > -T > -- > 2.21.0 > -- Best Regards Masahiro Yamada _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel