From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12F83C32792 for ; Mon, 30 Sep 2019 13:11:44 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DA14A215EA for ; Mon, 30 Sep 2019 13:11:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="r5SvlFPP" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DA14A215EA Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arndb.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=hWfkqm/Z+pBncY4Q1VRHqLVSuxLC6bT4FdOb+8aNlX0=; b=r5SvlFPPOTugL9 cO7uuNNo7zRvO25FOrpp1XaqEZJg6UXNOuYZ/ngYYImB3RNi5IqUE84uGnD0FypjokFBNiSfQm+hs u8Z4Ue4fA6Uej86o9WP7aFs7voiMmEP06ZbrYvAGNfuNjsxRrXsba2wXMfWC0rFDW3CAhd4YMa7T5 /dNAx5SODr9BQY6wBTSJdgGmtlAK2OdJK/Wv6SLyOp+8RvLZZZoZMeE4e6XuczsHKLMXahHddCsEs XE5DOCWuUcBatgpmNMNQG+YFj/gEpzsS+EuDsLtYCQIY8cGY8qMAzguZHfRsiWiWFXJvrbN5fDYFV o3CV00HimIlVS9nEcBbw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.2 #3 (Red Hat Linux)) id 1iEvSj-0005jx-0l; Mon, 30 Sep 2019 13:11:37 +0000 Received: from mail-qk1-f194.google.com ([209.85.222.194]) by bombadil.infradead.org with esmtps (Exim 4.92.2 #3 (Red Hat Linux)) id 1iEvSg-0005j8-Bm for linux-arm-kernel@lists.infradead.org; Mon, 30 Sep 2019 13:11:35 +0000 Received: by mail-qk1-f194.google.com with SMTP id z67so7630475qkb.12 for ; Mon, 30 Sep 2019 06:11:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=yvTBruD6zaxn4sjv75YBQD/wvJnGfoapWmbizXNwOe4=; b=m7y+6KyesSkJKxyclDhkAoTsCsFznzBiUS2fGHfR4RxlnPFM3vJB75hs2txCtVb35d a5cZog6VKNoU6PsZEWyOidF0oquFcHe8jy9pY1vFuUa+TqmA2iWesAYuZ5oCanO3wwNc KHv1nONNL7wYfKhJZx7YiD+omgXfS7SbimaDz1x6TxdcqunTkbR6R+tMJb84JLEUluo2 kgk75mH5W7XXecDgwIYZYAIHdgaraMmadJxskfOnxEroYduMoFGYA2YWA/ljPivkBkEK hBQUXCxhk0cpiRWQj4o3tzOt7hsQ/QtJM3/g+HeQt+qwoOQ0xi/UTCIm2eSlZkcnxZ85 AVKQ== X-Gm-Message-State: APjAAAUFCgrWK7/13dJDZsUv2GaP6Pf0N7+MNGIXTVP1F0YN3mWLE7cu Qok2YiJyfbdMYpv4a5SXT2xKL5/nyvpPT8T8ZD4= X-Google-Smtp-Source: APXvYqxTTAYfkhCHkzMgXzRRscqOu03R0zgUehRs/wbuLHGGTGki2kNYI5vG0oUjtCDGe/Os6ctHOkQ9bUK6AsOCYAI= X-Received: by 2002:ae9:ef8c:: with SMTP id d134mr18891406qkg.286.1569849091986; Mon, 30 Sep 2019 06:11:31 -0700 (PDT) MIME-Version: 1.0 References: <8879f74a8cc5dffdb14d553c321d64c63ea9fe2d.1569831229.git.Jose.Abreu@synopsys.com> In-Reply-To: <8879f74a8cc5dffdb14d553c321d64c63ea9fe2d.1569831229.git.Jose.Abreu@synopsys.com> From: Arnd Bergmann Date: Mon, 30 Sep 2019 15:11:15 +0200 Message-ID: Subject: Re: [PATCH v2 net 9/9] net: stmmac: xgmac: Fix RSS writing wrong keys To: Jose Abreu X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190930_061134_399806_0633BC99 X-CRM114-Status: GOOD ( 10.48 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Joao Pinto , Alexandre Torgue , Networking , "linux-kernel@vger.kernel.org" , linux-stm32@st-md-mailman.stormreply.com, Maxime Coquelin , Giuseppe Cavallaro , "David S. Miller" , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Sep 30, 2019 at 10:19 AM Jose Abreu wrote: > > Commit b6b6cc9acd7b, changed the call to dwxgmac2_rss_write_reg() > passing it the variable cfg->key[i]. > > As key is an u8 but we write 32 bits at a time we need to cast it into > an u32 so that the correct key values are written. Notice that the for > loop already takes this into account so we don't try to write past the > keys size. Right, sorry about my mistake. > Fixes: b6b6cc9acd7b ("net: stmmac: selftest: avoid large stack usage") > Signed-off-by: Jose Abreu Reviewed-by: Arnd Bergmann _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel