From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9FC87C48BD1 for ; Fri, 11 Jun 2021 10:18:38 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 608FF613E7 for ; Fri, 11 Jun 2021 10:18:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 608FF613E7 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arndb.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=oYssW1l/m0cn8AzSHP2HeQkgHj48c7c1yWv8SvoZ3Bs=; b=zDpqXEFbvanGUX sDcKiBV8vWprq3zTxFcbBhUA0Py47c7H52KiTYwl9ryF8iXCrH5goOIrhT5V16WzletJIClG9M5Xq GgKrRv7zIW1kmY1p4fzv9ij47OcnnZu3bGkNvYwwm2ZG91JWiuXCxyPcJaUoF9WJEEOklqDjyXvOf AbHaTRUSM05jPadLGlyDc5pIRa9wnEOD+dij6zhIvUswrxnJD2t8h/YE1tM0w7VU8+lIV5gyqvkYS MtoLaBz70mMtQGj45qUi5XHN/zbannWmXmEb1vFHhv/+0g7jiesisUXvY3sLjyH0SVyvd9MwKFV8m Ipz4mz2HWLfUWGb6mBxQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lreDB-004fsT-8w; Fri, 11 Jun 2021 10:16:25 +0000 Received: from mout.kundenserver.de ([212.227.17.10]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lreD7-004frW-Je for linux-arm-kernel@lists.infradead.org; Fri, 11 Jun 2021 10:16:23 +0000 Received: from mail-wm1-f43.google.com ([209.85.128.43]) by mrelayeu.kundenserver.de (mreue109 [213.165.67.113]) with ESMTPSA (Nemesis) id 1MoNyA-1lXwVb1wO8-00opp5 for ; Fri, 11 Jun 2021 12:16:15 +0200 Received: by mail-wm1-f43.google.com with SMTP id d184so7815498wmd.0 for ; Fri, 11 Jun 2021 03:16:15 -0700 (PDT) X-Gm-Message-State: AOAM530W0S+ctS71N3bRFHgYjJqZ/2J0uHHl7IqAv91YmKe/l84mwWnU sNtPxzIoB8CnAn9SDJd9rWoG+kvx8iFFmCcH4y4= X-Google-Smtp-Source: ABdhPJwvIg3HpxOv75nM9BOMbEzE2jwmrEUq21Zij8BiOyxLK61h50K5zknxBGr7ZYt1Cd5AINvFLRK9+qn+Ye8ETGY= X-Received: by 2002:a1c:7d15:: with SMTP id y21mr19184270wmc.120.1623406574665; Fri, 11 Jun 2021 03:16:14 -0700 (PDT) MIME-Version: 1.0 References: <20210610035412.93682-1-joel@jms.id.au> <20210610035412.93682-3-joel@jms.id.au> In-Reply-To: From: Arnd Bergmann Date: Fri, 11 Jun 2021 12:14:17 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 2/6] ARM: config: multi v7: Clean up enabled by default options To: Joel Stanley Cc: Linux ARM X-Provags-ID: V03:K1:ocPl91VGclDsKiaRm0I7sO/hm4quMAzGqjZ6FWp3Z+QgXGmxZ2l TD3tzu4GQKi8ipgJ6LBaprq2HlQEYzA3rz+mEKZmXcVUbHcu4nky80YeGgmeYae2Dh9iu7T 4YPZ/6M55Z1CqYHgOHMK02S8hQ2ImLvuFCBVQl6bKa84h2HlgkrJt3QSalpyREy/9ajebvG I76UkgeKFckYH6cYEpjvw== X-UI-Out-Filterresults: notjunk:1;V03:K0:C6NehvOufQI=:wFODSrsy0fCHuZ0wcU8n63 kDodI3NY8lXkiRCd2uVuQgn5QDb2Vpv9YAT+/Pss8vQoaA5gm3cEQTsp/EnxYu2e3JN7lZiFl B4GHB66YVMbZoTscJbzLtteO+JJ6QZ6ILC1/o6ao3AMhojW8yKwFkPHYOvOdHPT/bFtiQUIkO LiEnaw01GWaQ8/H8EAcVSwTgdiaB5wyfstrAE5CCdTinIrL2mXPbklg7tP5gSPy4loxHrJmWU k+qLXaMbJC1ncwSxJ5C8JzFKKZRnX/tuIghQtQBwz/Ehc81t1ykuQqKGim/pCbusaaTx1oS32 HOIAYAJ0nW7AvsFMkMwE1lpkqgIgQScowsy4Im5ZGbitW/zy4pqrWH7SH1Xik3gq+icbrQ5Jf 12m/EUUZyJd0HFXrSrKGOymhpu4aa31tuYsnWY8x15gaB+R6ZLzpdtoDyu7M9ca6IKVBx8TL6 KBr6646IBd/5fkzfKbYrUF2TcZteu2idgeNvdp7hbu6gew2MJeiOiwcOFQWdYdb8H3J7qWPAe HS9fbTW+asZf8CWxYW6MPjpYJRwxznL7qXJ+aasZjgkk8qpH4+wo9AEUbCHib9OMLwlrZiBpw fxEkmRuuRa8W1UsfT1NZ8++x8GiYeP3eyfJglMcEnoZkacpGEN/QkEYWK5wFxhPjNICgpY9En nRko= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210611_031621_963866_F51AF80F X-CRM114-Status: GOOD ( 20.97 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jun 11, 2021 at 5:29 AM Joel Stanley wrote: > > On Thu, 10 Jun 2021 at 07:58, Arnd Bergmann wrote: > > > > PTP_1588_CLOCK is implied by enabled drivers STMMAC_ETH, IGB, E1000E and FEC. > > > > I still feel a little uneasy about not enabling PTP_1588_CLOCK in case > > we get rid of that > > 'imply', the rest looks good. > > If we got rid of the imply, would it become a select? > > I realise that's bad form, but if these drivers need that functionality... That would need some further discussion. I think we have two distinct cases: - some drivers can use the PTP_1588_CLOCK feature if that symbol is built-in, or both the driver and the ptp support are loadable modules. If the drivers are built-in, but PTP_1588_CLOCK=m, they currently silently break, which is unfortunate and often unexpected. The 'imply' keyword was originally intended to work around this problem but doesn't do that any more. - Some drivers have a separate Kconfig symbol for enabling PTP support within a driver that is controlled separately. These tend to use 'depends on PTP_1588_CLOCK'. I would hope that we can at least be consistent with 'select' vs 'depends on' here, but either solution is possible. One option that would work is to have a global setting that decides whether PTP support is available to drivers at all, and then another symbol that gets selected by drivers to decide whether it ends up built-in or in a loadable module. > Happy to re-roll with that change dropped, just let me know. That would be my preference, yes. Arnd _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel